From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC226C43381 for ; Fri, 15 Mar 2019 20:57:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 997B8218A1 for ; Fri, 15 Mar 2019 20:57:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=fomichev-me.20150623.gappssmtp.com header.i=@fomichev-me.20150623.gappssmtp.com header.b="HM/IYfCU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726097AbfCOU5C (ORCPT ); Fri, 15 Mar 2019 16:57:02 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:43645 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726676AbfCOU4z (ORCPT ); Fri, 15 Mar 2019 16:56:55 -0400 Received: by mail-pg1-f193.google.com with SMTP id l11so7242649pgq.10 for ; Fri, 15 Mar 2019 13:56:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fomichev-me.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=AAff4RmUaSYnml/Ko+UEfMQ8m682UchLUHVPeub+JoY=; b=HM/IYfCUNaX6xr6koQG7rd2dJ78nKEkPNkkoNQP+wU6BIl0Lunr0MnY5C3vsJ6Au0T MSfKIbIj+zskUwzvojddEYN7rzKngJn9Qygt5FdnbKvpskyLqAZlp8GQ0Lu2/Ks62zpg GUdX4WQfLgO3QNJWTPv++HBRVkbsgANRQKlachmmszhwEn9zPtTb/Ca81XmLp6V/Hr28 yR7FTtsGe2wC4lgUj/wnc7zbD02yZmcPD1/NXniex0Gb93qwejRxi2WhizYV3uZaVLI4 DJat8JdlLj1OIPE5GtgGxTGQNFy5FrDgSXtvXha4a6D6Ihq/TRBG0SNfHY114zLrouN1 IJ2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=AAff4RmUaSYnml/Ko+UEfMQ8m682UchLUHVPeub+JoY=; b=IktTiUFD99aR7j3sIE3zrhn5gDX4ZmjSjaqadk5zJ9mVbjfPj8IdVEMo2ws4/+3YgB 21/M1GjTi7nHr0aIYydeSB9cXzu4hzzlwr6z20SeJPq2qGHRy6OFTb/YDWu5Kz86unen 2/gHCINv6eI/MXDWnORc4lpl6p6wOdyX/qNGzQcdARvgzYi8/KWMGU59YpLHVpEI6sPK Fj3Y9hs4rc5FD/qiWBiW9+LEQBCIkMrOH1Ejl+uwSF2FTEHLwU4wb4DIbuPgI493oKc9 kNsz2FCX3ubYDwRiZhu0YB+oOomKKHgu0iasM69PgsY6i148zReQg7vRymdaob/5xNOI 4jJA== X-Gm-Message-State: APjAAAXg4vx7Og70fjdwPADMkeYkNKq2sjkmIHSi2P/Pr6XHpNaShpy1 COX+OKv8dRLgg+DL8mn2foEd1Q== X-Google-Smtp-Source: APXvYqyvsL2K0RjChi9YcUPHlPxu0EdOiPDO/OPrf/9riTAJCC3qXXKbhR/qYliElcRHsAPUHmLlqw== X-Received: by 2002:a17:902:29ca:: with SMTP id h68mr6324756plb.297.1552683413985; Fri, 15 Mar 2019 13:56:53 -0700 (PDT) Received: from localhost ([2601:646:8f00:18d9:d0fa:7a4b:764f:de48]) by smtp.gmail.com with ESMTPSA id j71sm6334015pfc.6.2019.03.15.13.56.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 15 Mar 2019 13:56:53 -0700 (PDT) Date: Fri, 15 Mar 2019 13:56:52 -0700 From: Stanislav Fomichev To: Ivan Vecera Cc: netdev@vger.kernel.org, Shuah Khan , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , "open list:KERNEL SELFTEST FRAMEWORK" , "open list:BPF (Safe dynamic programs and tools)" , open list Subject: Re: [PATCH net-next] selftests: bpf: modify urandom_read and link it non-statically Message-ID: <20190315205652.GD5481@mini-arch.hsd1.ca.comcast.net> References: <20190315200414.32346-1-ivecera@redhat.com> <20190315200847.GC5481@mini-arch.hsd1.ca.comcast.net> <2dcdc11c-4d04-4b0e-ddb7-04d969d04651@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2dcdc11c-4d04-4b0e-ddb7-04d969d04651@redhat.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On 03/15, Ivan Vecera wrote: > On 15. 03. 19 21:08, Stanislav Fomichev wrote: > > On 03/15, Ivan Vecera wrote: > > > After some experiences I found that urandom_read does not need to be > > > linked statically. When the 'read' syscall call is moved to separate > > > non-inlined function then bpf_get_stackid() is able to find > > > the executable in stack trace and extract its build_id from it. > > But why? Do you have some problems with it being linked statically? > > > Dependency... you don't need to install static glibc to compile the bpf > samples. Shared libc is available everytime. Oh, the distros that do -devel _and_ -static packages :-) So your patch essentially adds a call, that leaves a trace on the stack with our build-id. I guess that works as well. > > Ivan