From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Stanislav Fomichev <sdf@fomichev.me>
Cc: Yonghong Song <yhs@fb.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Shuah Khan <shuah@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Stanislav Fomichev <sdf@google.com>,
Daniel Borkmann <daniel@iogearbox.net>, Martin Lau <kafai@fb.com>,
Song Liu <songliubraving@fb.com>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>
Subject: Re: [PATCHv2 bpf-next 1/3] bpf, tests: tweak endianness selection
Date: Thu, 21 Mar 2019 09:34:26 +0900 [thread overview]
Message-ID: <20190321003426.GB2097@jagdpanzerIV> (raw)
In-Reply-To: <20190320222759.GQ7431@mini-arch.hsd1.ca.comcast.net>
On (03/20/19 15:27), Stanislav Fomichev wrote:
[..]
> > Inside kernel clang compiler header (linux/compiler-clang.h) does not
> > define __HAVE_BUILTIN_BSWAP16__. So it will go to the "else" branch in
> > the above. So I think it should work with clang + bpf.
> Hm, isn't it the opposite of what we want then? I think for llvm+bpf we always
> want to use the builtins to make it properly generate
> BPF_TO_BE/BPF_TO_LE instructions.
Oh, hmm, OK. I see your point now. bpf insn set for variables.
-ss
next prev parent reply other threads:[~2019-03-21 0:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 12:53 [PATCHv2 bpf-next 1/3] bpf, tests: tweak endianness selection Sergey Senozhatsky
2019-03-20 12:53 ` [PATCHv2 bpf-next 2/3] bpf, tests: drop unused __bpf_constant_foo defines Sergey Senozhatsky
2019-03-20 12:56 ` Sergey Senozhatsky
2019-03-20 12:53 ` [PATCHv2 bpf-next 3/3] bpf, tests: don't use __bpf_constant_htons() Sergey Senozhatsky
2019-03-20 12:55 ` Sergey Senozhatsky
2019-03-20 17:13 ` [PATCHv2 bpf-next 1/3] bpf, tests: tweak endianness selection Stanislav Fomichev
2019-03-20 22:20 ` Yonghong Song
2019-03-20 22:27 ` Stanislav Fomichev
2019-03-20 22:45 ` Yonghong Song
2019-03-20 23:08 ` Daniel Borkmann
2019-03-21 0:03 ` Stanislav Fomichev
2019-03-21 0:23 ` Yonghong Song
2019-03-21 0:34 ` Sergey Senozhatsky [this message]
2019-03-21 0:22 ` Sergey Senozhatsky
2019-03-21 3:24 ` Alexei Starovoitov
2019-03-21 5:08 ` Sergey Senozhatsky
2019-03-21 15:49 ` Stanislav Fomichev
2019-03-22 2:46 ` Sergey Senozhatsky
2019-03-22 3:12 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190321003426.GB2097@jagdpanzerIV \
--to=sergey.senozhatsky.work@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kafai@fb.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sdf@fomichev.me \
--cc=sdf@google.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=shuah@kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).