From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Stanislav Fomichev <sdf@fomichev.me>
Cc: Stanislav Fomichev <sdf@google.com>,
netdev@vger.kernel.org, bpf@vger.kernel.org, davem@davemloft.net,
ast@kernel.org, daniel@iogearbox.net, simon.horman@netronome.com,
willemb@google.com, peterpenkov96@gmail.com
Subject: Re: [RFC bpf-next v3 6/8] flow_dissector: handle no-skb use case
Date: Fri, 22 Mar 2019 18:41:03 -0700 [thread overview]
Message-ID: <20190323014101.mxeey4tw3gt7o4yi@ast-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <20190323011957.GY7431@mini-arch.hsd1.ca.comcast.net>
On Fri, Mar 22, 2019 at 06:19:57PM -0700, Stanislav Fomichev wrote:
> Are we ok with breaking api in this case? I'm all in on removing this
> extra information. We can always put it back if somebody complains (and
> manually parse in eth_get_headlen case).
Fine. That seems to be the only way forward to clean it all up.
Could you submit patch 1 to bpf tree disallowing vlan fields?
Patch 3 looks like candidate as well?
> We can still have protocol, because in both skb/skb-less cases we have
> it.
proto can work in both cases, but is it needed ? Does program benefit from it?
The kernel side burns extra bytes by copying it and extra branches to handle it.
May be drop it as well?
next prev parent reply other threads:[~2019-03-23 1:41 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 19:58 [RFC bpf-next v3 0/8] net: flow_dissector: trigger BPF hook when called from eth_get_headlen Stanislav Fomichev
2019-03-22 19:58 ` [RFC bpf-next v3 1/8] flow_dissector: allow access only to a subset of __sk_buff fields Stanislav Fomichev
2019-03-22 19:58 ` [RFC bpf-next v3 2/8] flow_dissector: switch kernel context to struct bpf_flow_dissector Stanislav Fomichev
2019-03-22 19:58 ` [RFC bpf-next v3 3/8] flow_dissector: fix clamping of BPF flow_keys for non-zero nhoff Stanislav Fomichev
2019-03-22 19:58 ` [RFC bpf-next v3 4/8] bpf: when doing BPF_PROG_TEST_RUN for flow dissector use no-skb mode Stanislav Fomichev
2019-03-22 19:59 ` [RFC bpf-next v3 5/8] net: plumb network namespace into __skb_flow_dissect Stanislav Fomichev
2019-03-22 19:59 ` [RFC bpf-next v3 6/8] flow_dissector: handle no-skb use case Stanislav Fomichev
2019-03-23 1:00 ` Alexei Starovoitov
2019-03-23 1:19 ` Stanislav Fomichev
2019-03-23 1:41 ` Alexei Starovoitov [this message]
2019-03-23 16:05 ` Stanislav Fomichev
2019-03-26 0:35 ` Alexei Starovoitov
2019-03-26 16:45 ` Stanislav Fomichev
2019-03-26 17:48 ` Alexei Starovoitov
2019-03-26 17:51 ` Willem de Bruijn
2019-03-26 18:08 ` Alexei Starovoitov
2019-03-26 18:17 ` Stanislav Fomichev
2019-03-26 18:30 ` Alexei Starovoitov
2019-03-26 18:54 ` Stanislav Fomichev
2019-03-27 1:41 ` Alexei Starovoitov
2019-03-27 2:44 ` Stanislav Fomichev
2019-03-27 17:55 ` Alexei Starovoitov
2019-03-27 19:58 ` Stanislav Fomichev
2019-03-28 1:26 ` Alexei Starovoitov
2019-03-28 3:14 ` Willem de Bruijn
2019-03-28 3:32 ` Alexei Starovoitov
2019-03-28 4:17 ` Stanislav Fomichev
2019-03-28 12:58 ` Willem de Bruijn
2019-04-01 16:30 ` Stanislav Fomichev
2019-03-22 19:59 ` [RFC bpf-next v3 7/8] net: pass net argument to the eth_get_headlen Stanislav Fomichev
2019-03-22 19:59 ` [RFC bpf-next v3 8/8] selftests/bpf: add flow dissector bpf_skb_load_bytes helper test Stanislav Fomichev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190323014101.mxeey4tw3gt7o4yi@ast-mbp.dhcp.thefacebook.com \
--to=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=peterpenkov96@gmail.com \
--cc=sdf@fomichev.me \
--cc=sdf@google.com \
--cc=simon.horman@netronome.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).