From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Alexei Starovoitov <ast@kernel.org>
Cc: <davem@davemloft.net>, <daniel@iogearbox.net>,
<netdev@vger.kernel.org>, <bpf@vger.kernel.org>,
<kernel-team@fb.com>
Subject: Re: [PATCH bpf-next 1/3] bpf: cleanup explored_states
Date: Tue, 21 May 2019 18:04:03 -0700 [thread overview]
Message-ID: <20190521180403.0a24e0e9@cakuba.netronome.com> (raw)
In-Reply-To: <20190521230635.2142522-2-ast@kernel.org>
On Tue, 21 May 2019 16:06:33 -0700, Alexei Starovoitov wrote:
> clean up explored_states to prep for introduction of hashtable
> No functional changes.
>
> Signed-off-by: Alexei Starovoitov <ast@kernel.org>
> ---
> kernel/bpf/verifier.c | 30 +++++++++++++++++++++---------
> 1 file changed, 21 insertions(+), 9 deletions(-)
>
> diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
> index 95f9354495ad..a171b2940382 100644
> --- a/kernel/bpf/verifier.c
> +++ b/kernel/bpf/verifier.c
> @@ -5436,6 +5436,18 @@ enum {
> };
>
> #define STATE_LIST_MARK ((struct bpf_verifier_state_list *) -1L)
> +static struct bpf_verifier_state_list **explored_state(
> + struct bpf_verifier_env *env,
> + int idx)
> +{
> + return &env->explored_states[idx];
> +}
> +
> +static void init_explored_state(struct bpf_verifier_env *env, int idx)
> +{
> + env->explored_states[idx] = STATE_LIST_MARK;
> +}
> +
nit: extra new line here
>
next prev parent reply other threads:[~2019-05-22 1:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 23:06 [PATCH bpf-next 0/3] bpf: optimize explored_states Alexei Starovoitov
2019-05-21 23:06 ` [PATCH bpf-next 1/3] bpf: cleanup explored_states Alexei Starovoitov
2019-05-22 1:04 ` Jakub Kicinski [this message]
2019-05-21 23:06 ` [PATCH bpf-next 2/3] bpf: split explored_states Alexei Starovoitov
2019-05-21 23:06 ` [PATCH bpf-next 3/3] bpf: convert explored_states to hash table Alexei Starovoitov
2019-05-22 0:55 ` Andrii Nakryiko
2019-05-22 2:17 ` Alexei Starovoitov
2019-05-22 4:09 ` Andrii Nakryiko
2019-05-22 4:18 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190521180403.0a24e0e9@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).