From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BE9EC2BCA1 for ; Fri, 7 Jun 2019 18:33:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 35F28208E3 for ; Fri, 7 Jun 2019 18:33:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Er9Haffn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731179AbfFGSdB (ORCPT ); Fri, 7 Jun 2019 14:33:01 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:44473 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730870AbfFGSdA (ORCPT ); Fri, 7 Jun 2019 14:33:00 -0400 Received: by mail-qt1-f193.google.com with SMTP id x47so3387697qtk.11; Fri, 07 Jun 2019 11:33:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=5GYL4fUKk00yP4HXvUNZ6Fi+8Ufg5Y3SKrb4tcTkGv4=; b=Er9Haffn8ymi5u7v6whd1+YGF4s/uaDHMom/eLld0djCyg42kKyXN4TEC/UE2hHkG+ JC1MdoWB4bISksLxecXalDGdIMlo62BwnGRPNB9peeXKNcA1MUNrzw36J015vMEaa0uD RWJPYcnze0Zh1hxLeHvCHxrkL3AO1M5P83Y2jysQSfFELXvWLJ4LPCh2ZzXAyJlPqDwL PMoWEfi7ADRLzSzpB/2HZtnXZktZXZ6EEI+Kp5vkQG6eE9x4atGjGC0R8utDlDzIyqT0 oe5ZoIG4RfMmeeObNUScT5vRb/4haAEq84Wo3vihCdxEmWeqZSV46x47jHHjFRqlcYxl b6eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=5GYL4fUKk00yP4HXvUNZ6Fi+8Ufg5Y3SKrb4tcTkGv4=; b=W5atWO0rx+EZ6knUYsYfjDk2kzI02aFbb2UXhmUU3GRuiLXZ2nfUbVA273DtYGtV5y REjzfpJSfn3KRGXuzcDZ0qS3g8+hQRfRsQhzOhwPnPrzvm25GdsqgBim41A6Lf70q/ZA H5jk8qVcEPNOVXaSUJ3m75yBJ23rWEiGytu0Oed6PrvCG7i56Gup/R2Z2gmXQCjXnJ2F DXGkWbdUsbptm9wMzC/yJ0RKbkrvojqhzj4rf5FcLuk58ArIDXzmQnNuHIgtSoUo94n9 R4eu8EIrljc7R3UxmFa7KuBjqimEaVY29eTi7mfll3X7PsCtDlHHqPByDwANEzOMsZ/P 2G7Q== X-Gm-Message-State: APjAAAVIVI0XpRrLrXVLtGiu5Nfy+yN46ilfpMBK8aOdrg/8K3L0zTKS 54v/OW6f3kTdD7Cj18Wb8bk= X-Google-Smtp-Source: APXvYqz70lCRh739won9H5qXaTU9fvSzxLj46nPTcb4qmQOkP9x5eHZsfgZiCIQP/4l7xDriedsOJA== X-Received: by 2002:a0c:ae31:: with SMTP id y46mr14635450qvc.172.1559932379563; Fri, 07 Jun 2019 11:32:59 -0700 (PDT) Received: from quaco.ghostprotocols.net (187-26-97-17.3g.claro.net.br. [187.26.97.17]) by smtp.gmail.com with ESMTPSA id p13sm1340288qkj.4.2019.06.07.11.32.58 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 07 Jun 2019 11:32:58 -0700 (PDT) From: Arnaldo Carvalho de Melo X-Google-Original-From: Arnaldo Carvalho de Melo Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 0776F41149; Fri, 7 Jun 2019 15:32:55 -0300 (-03) Date: Fri, 7 Jun 2019 15:32:54 -0300 To: Leo Yan Cc: Alexander Shishkin , Jiri Olsa , Namhyung Kim , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andi Kleen , Mark Drayton , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH] perf config: Update default value for llvm.clang-bpf-cmd-template Message-ID: <20190607183254.GM21245@kernel.org> References: <20190607143508.18141-1-leo.yan@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190607143508.18141-1-leo.yan@linaro.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.11.3 (2019-02-01) Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Em Fri, Jun 07, 2019 at 10:35:08PM +0800, Leo Yan escreveu: > The clang bpf cmdline template has defined default value in the file > tools/perf/util/llvm-utils.c, which has been changed for several times. > > This patch updates the documentation to reflect the latest default value > for the configuration llvm.clang-bpf-cmd-template. > > Fixes: d35b168c3dcd ("perf bpf: Give precedence to bpf header dir") > Fixes: cb76371441d0 ("perf llvm: Allow passing options to llc in addition to clang") > Fixes: 1b16fffa389d ("perf llvm-utils: Add bpf include path to clang command line") Well done! Three fixes! :-) Who was it that made the changes and forgot to update the docs... oops, it was me 8-) Thanks, applied. - Arnaldo > Signed-off-by: Leo Yan > --- > tools/perf/Documentation/perf-config.txt | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/tools/perf/Documentation/perf-config.txt b/tools/perf/Documentation/perf-config.txt > index 462b3cde0675..e4aa268d2e38 100644 > --- a/tools/perf/Documentation/perf-config.txt > +++ b/tools/perf/Documentation/perf-config.txt > @@ -564,9 +564,12 @@ llvm.*:: > llvm.clang-bpf-cmd-template:: > Cmdline template. Below lines show its default value. Environment > variable is used to pass options. > - "$CLANG_EXEC -D__KERNEL__ $CLANG_OPTIONS $KERNEL_INC_OPTIONS \ > - -Wno-unused-value -Wno-pointer-sign -working-directory \ > - $WORKING_DIR -c $CLANG_SOURCE -target bpf -O2 -o -" > + "$CLANG_EXEC -D__KERNEL__ -D__NR_CPUS__=$NR_CPUS "\ > + "-DLINUX_VERSION_CODE=$LINUX_VERSION_CODE " \ > + "$CLANG_OPTIONS $PERF_BPF_INC_OPTIONS $KERNEL_INC_OPTIONS " \ > + "-Wno-unused-value -Wno-pointer-sign " \ > + "-working-directory $WORKING_DIR " \ > + "-c \"$CLANG_SOURCE\" -target bpf $CLANG_EMIT_LLVM -O2 -o - $LLVM_OPTIONS_PIPE" > > llvm.clang-opt:: > Options passed to clang. > -- > 2.17.1 -- - Arnaldo