From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80D97C31E50 for ; Fri, 14 Jun 2019 23:54:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 46EB12070B for ; Fri, 14 Jun 2019 23:54:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726072AbfFNXyZ (ORCPT ); Fri, 14 Jun 2019 19:54:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42892 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725981AbfFNXyZ (ORCPT ); Fri, 14 Jun 2019 19:54:25 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BAE9F3083391; Fri, 14 Jun 2019 23:54:24 +0000 (UTC) Received: from treble (ovpn-112-39.rdu2.redhat.com [10.10.112.39]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E62DF60CA3; Fri, 14 Jun 2019 23:54:20 +0000 (UTC) Date: Fri, 14 Jun 2019 18:54:17 -0500 From: Josh Poimboeuf To: Alexei Starovoitov Cc: X86 ML , Alexei Starovoitov , LKML , Daniel Borkmann , Network Development , bpf , Peter Zijlstra , Song Liu , Kairui Song , Steven Rostedt , David Laight , Thomas Gleixner , Borislav Petkov , Ingo Molnar Subject: Re: [PATCH v2 4/5] x86/bpf: Fix 64-bit JIT frame pointer usage Message-ID: <20190614235417.7oagddee75xo7otp@treble> References: <178097de8c1bd6a877342304f3469eac4067daa4.1560534694.git.jpoimboe@redhat.com> <20190614210555.q4ictql3tzzjio4r@ast-mbp.dhcp.thefacebook.com> <20190614211916.jnxakyfwilcv6r57@treble> <20190614231311.gfeb47rpjoholuov@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Fri, 14 Jun 2019 23:54:24 +0000 (UTC) Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Fri, Jun 14, 2019 at 04:23:41PM -0700, Alexei Starovoitov wrote: > On Fri, Jun 14, 2019 at 4:13 PM Josh Poimboeuf wrote: > > > > On Fri, Jun 14, 2019 at 02:27:30PM -0700, Alexei Starovoitov wrote: > > > On Fri, Jun 14, 2019 at 2:19 PM Josh Poimboeuf wrote: > > > > > > > > On Fri, Jun 14, 2019 at 02:05:56PM -0700, Alexei Starovoitov wrote: > > > > > Have you tested it ? > > > > > I really doubt, since in my test both CONFIG_UNWINDER_ORC and > > > > > CONFIG_UNWINDER_FRAME_POINTER failed to unwind through such odd frame. > > > > > > > > Hm, are you seeing selftest failures? They seem to work for me. > > > > > > > > > Here is much simple patch that I mentioned in the email yesterday, > > > > > but you failed to listen instead of focusing on perceived 'code readability'. > > > > > > > > > > It makes one proper frame and both frame and orc unwinders are happy. > > > > > > > > I'm on my way out the door and I just skimmed it, but it looks fine. > > > > > > > > Some of the code and patch description look familiar, please be sure to > > > > give me proper credit. > > > > > > credit means something positive. > > > > So you only give credit for *good* stolen code. I must have missed that > > section of the kernel patch guidelines. > > what are you talking about? > you've posted one bad patch. I pointed out multiple issues in it. > Then proposed another bad idea. I pointed out another set of issues. > Than David proposed yet another idea that you've implemented > and claimed that it's working when it was not. > Then I got fed up with this thread and fix it for real by reverting > that old commit that I mentioned way earlier. > https://patchwork.ozlabs.org/patch/1116307/ > Where do you see your code or ideas being used? > I see none. Obviously I wasn't referring to this new whitewashed patch for which I wasn't even on Cc, despite being one of the people (along with Peter Z) who convinced you that there was a problem to begin with. The previous patch you posted has my patch description, push/pop and comment changes, with no credit: https://lkml.kernel.org/r/20190614210555.q4ictql3tzzjio4r@ast-mbp.dhcp.thefacebook.com -- Josh