From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4153EC31E51 for ; Sat, 15 Jun 2019 12:57:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 22C1721773 for ; Sat, 15 Jun 2019 12:57:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726582AbfFOM55 (ORCPT ); Sat, 15 Jun 2019 08:57:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35170 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726327AbfFOM55 (ORCPT ); Sat, 15 Jun 2019 08:57:57 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A174B308213A; Sat, 15 Jun 2019 12:57:55 +0000 (UTC) Received: from treble (ovpn-120-23.rdu2.redhat.com [10.10.120.23]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4A2B4379E; Sat, 15 Jun 2019 12:57:51 +0000 (UTC) Date: Sat, 15 Jun 2019 07:57:48 -0500 From: Josh Poimboeuf To: Alexei Starovoitov Cc: X86 ML , Alexei Starovoitov , LKML , Daniel Borkmann , Network Development , bpf , Peter Zijlstra , Song Liu , Kairui Song , Steven Rostedt , David Laight , Thomas Gleixner , Borislav Petkov , Ingo Molnar Subject: Re: [PATCH v2 4/5] x86/bpf: Fix 64-bit JIT frame pointer usage Message-ID: <20190615125748.2c4xpgfuccanjx5d@treble> References: <178097de8c1bd6a877342304f3469eac4067daa4.1560534694.git.jpoimboe@redhat.com> <20190614210555.q4ictql3tzzjio4r@ast-mbp.dhcp.thefacebook.com> <20190614211916.jnxakyfwilcv6r57@treble> <20190614231311.gfeb47rpjoholuov@treble> <20190614235417.7oagddee75xo7otp@treble> <20190615042747.awyy4djqe6vfmles@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Sat, 15 Jun 2019 12:57:56 +0000 (UTC) Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Fri, Jun 14, 2019 at 10:16:53PM -0700, Alexei Starovoitov wrote: > On Fri, Jun 14, 2019 at 9:27 PM Josh Poimboeuf wrote: > > > > On Fri, Jun 14, 2019 at 05:02:36PM -0700, Alexei Starovoitov wrote: > > > On Fri, Jun 14, 2019 at 4:54 PM Josh Poimboeuf wrote: > > > > The previous patch you posted has my patch description, push/pop and > > > > comment changes, with no credit: > > > > > > > > https://lkml.kernel.org/r/20190614210555.q4ictql3tzzjio4r@ast-mbp.dhcp.thefacebook.com > > > > > > I'm sorry for reusing one sentence from your commit log and > > > not realizing you want credit for that. > > > Will not happen again. > > > > Um. What are you talking about? The entire patch was clearly derived > > from mine. Not just "one sentence from your commit log". The title, > > the pushes/pops in the prologue/epilogue, the removal of the > > "ebpf_from_cbpf" argument, the code spacing, and some of the non trivial > > comment changes were the same. > > > > > I also suggest you never touch anything bpf related. > > > Just to avoid this credit claims and threads like this one. > > > > Wth. I made a simple request for credit. Anybody can see the patch was > > derived from mine. It's not like I really care. It's just basic human > > decency. > > derived? do you really think so ? > Please fix your orc stuff that is still broken. > Human decency is fixing stuff that you're responsible for. > Your commit d15d356887e7 on April 23 broke stack traces. > And we reported it 3 weeks ago. > Yet instead of fixing it you kept arguing about JIT frame pointers > that is orthogonal issue and was in this state for the last 2 years. Again you're not making sense. The fix has already been posted. That was the point of this patch set. It's your call if you want to cherry pick the FP fix (which is a dependency of the ORC fix) without taking the others. -- Josh