bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Petar Penkov <ppenkov.kernel@gmail.com>
Cc: kbuild-all@01.org, netdev@vger.kernel.org, bpf@vger.kernel.org,
	davem@davemloft.net, ast@kernel.org, daniel@iogearbox.net,
	edumazet@google.com, lmb@cloudflare.com, sdf@google.com,
	Petar Penkov <ppenkov@google.com>
Subject: Re: [bpf-next 2/6] tcp: add skb-less helpers to retrieve SYN cookie
Date: Wed, 24 Jul 2019 14:05:27 +0800	[thread overview]
Message-ID: <201907241434.kMg3X4RG%lkp@intel.com> (raw)
In-Reply-To: <20190723002042.105927-3-ppenkov.kernel@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2052 bytes --]

Hi Petar,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on bpf-next/master]

url:    https://github.com/0day-ci/linux/commits/Petar-Penkov/Introduce-a-BPF-helper-to-generate-SYN-cookies/20190723-235628
base:   https://kernel.googlesource.com/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: x86_64-randconfig-e004-201929 (attached as .config)
compiler: gcc-7 (Debian 7.4.0-10) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   ld: net/ipv4/tcp_input.o: in function `tcp_get_syncookie':
>> net/ipv4/tcp_input.c:6538: undefined reference to `__cookie_v6_init_sequence'

vim +6538 net/ipv4/tcp_input.c

  6509	
  6510	u16 tcp_get_syncookie(struct request_sock_ops *rsk_ops,
  6511			      const struct tcp_request_sock_ops *af_ops,
  6512			      struct sock *sk, void *iph, struct tcphdr *th,
  6513			      u32 *cookie)
  6514	{
  6515		u16 mss = 0;
  6516	#ifdef CONFIG_SYN_COOKIES
  6517		bool is_v4 = rsk_ops->family == AF_INET;
  6518		struct tcp_sock *tp = tcp_sk(sk);
  6519	
  6520		if (sock_net(sk)->ipv4.sysctl_tcp_syncookies != 2 &&
  6521		    !inet_csk_reqsk_queue_is_full(sk))
  6522			return 0;
  6523	
  6524		if (!tcp_syn_flood_action(sk, rsk_ops->slab_name))
  6525			return 0;
  6526	
  6527		if (sk_acceptq_is_full(sk)) {
  6528			NET_INC_STATS(sock_net(sk), LINUX_MIB_LISTENOVERFLOWS);
  6529			return 0;
  6530		}
  6531	
  6532		mss = tcp_parse_mss_option(th, tp->rx_opt.user_mss);
  6533		if (!mss)
  6534			mss = af_ops->mss_clamp;
  6535	
  6536		tcp_synq_overflow(sk);
  6537		*cookie = is_v4 ? __cookie_v4_init_sequence(iph, th, &mss)
> 6538				: __cookie_v6_init_sequence(iph, th, &mss);
  6539	#endif
  6540		return mss;
  6541	}
  6542	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 34310 bytes --]

  reply	other threads:[~2019-07-24  6:05 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-23  0:20 [bpf-next 0/6] Introduce a BPF helper to generate SYN cookies Petar Penkov
2019-07-23  0:20 ` [bpf-next 1/6] tcp: tcp_syn_flood_action read port from socket Petar Penkov
2019-07-23  0:20 ` [bpf-next 2/6] tcp: add skb-less helpers to retrieve SYN cookie Petar Penkov
2019-07-24  6:05   ` kbuild test robot [this message]
2019-07-24  6:19   ` kbuild test robot
2019-07-23  0:20 ` [bpf-next 3/6] bpf: add bpf_tcp_gen_syncookie helper Petar Penkov
2019-07-23 12:33   ` Toke Høiland-Jørgensen
2019-07-24  0:15     ` Petar Penkov
2019-07-23  0:20 ` [bpf-next 4/6] bpf: sync bpf.h to tools/ Petar Penkov
2019-07-23  0:20 ` [bpf-next 5/6] selftests/bpf: bpf_tcp_gen_syncookie->bpf_helpers Petar Penkov
2019-07-23  0:20 ` [bpf-next 6/6] selftests/bpf: add test for bpf_tcp_gen_syncookie Petar Penkov
2019-07-23  9:37   ` Lorenz Bauer
2019-07-23 20:46     ` Alexei Starovoitov
2019-07-23  6:30 ` [bpf-next 0/6] Introduce a BPF helper to generate SYN cookies Eric Dumazet
2019-07-23 10:27 ` Lorenz Bauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201907241434.kMg3X4RG%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kbuild-all@01.org \
    --cc=lmb@cloudflare.com \
    --cc=netdev@vger.kernel.org \
    --cc=ppenkov.kernel@gmail.com \
    --cc=ppenkov@google.com \
    --cc=sdf@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).