From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13DBCC433FF for ; Tue, 6 Aug 2019 00:11:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C8C9D2070D for ; Tue, 6 Aug 2019 00:11:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="XTNHuX5D" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730717AbfHFALG (ORCPT ); Mon, 5 Aug 2019 20:11:06 -0400 Received: from mail-qt1-f196.google.com ([209.85.160.196]:45059 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728483AbfHFALG (ORCPT ); Mon, 5 Aug 2019 20:11:06 -0400 Received: by mail-qt1-f196.google.com with SMTP id x22so9429352qtp.12 for ; Mon, 05 Aug 2019 17:11:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=8QBvLZD2PtMjFWXLXZHRh5JdLumVA7S4w1kwQFmHur8=; b=XTNHuX5DCsnABH8UbCWgalC8QIqM/NWIuoOu4eNtX/bnTvxaYXVbP+S7ZqRX5FT2Ar VIcg/qY+Gx3jm+zMyHPCRJMNlpl7RGUOmeVJl21jmF3KZpGWPDKMLUaDKM8x8nlAogTH uQs8DqlDKjB+KZa23cbpFFlh0N/ORtd8Sl0iN+N3t8tMGnXk8KsY2ErgJJVsO2I7d2e3 TRPN6HL8FafrvUFZFWnKJFELdL1ZNznoTq0dL1jjEeAiUzoGtaIebBlRV0es+M1zYHG6 gO23dbnKGRtpJTnwsSnzsjoWyqaXwd8MP2ngc+zKO6VY3FPfiX3iq7jmUAImG2apEYZc jTbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=8QBvLZD2PtMjFWXLXZHRh5JdLumVA7S4w1kwQFmHur8=; b=RlPVu+IN8vHq/jfld5KnidJw/RxbWDM5dRef829jS/cTQBYNixJnreYFKhzl39FBG4 JFiWireLIUqJeq07mA2HfmfXk0TeB9e8Ud62fEQ0BdUCxMzzQ0q0H4WBk6kBvErNWF72 +LHNpwv/huhwyrzKT1Ro2VrT7dyN6RYv37ibgu2vpmN5e+IfpKRPYS+TN35x0kI85c4o InbCHk0LbjB2jMF1jwLIyqk6BFCN1hw9RsMIlvdgaT2XjHEB39n/XK5lAzD0dRrBo+/b 7oEwRoiAS/GABRVRU0rM10A9DdkJcZLmJuegYIod6xIQxq6/+D0SdWG5syjos1hNa6b5 yyvw== X-Gm-Message-State: APjAAAWoC95RFXCChZmBLCw3dZ3wmO3zedepghi85DSWfVEZPqyTHG+l 3pTfTEz/ksuXrAlPUnLDoRuERg== X-Google-Smtp-Source: APXvYqxJ5lPwiTVrHhNS0rW//zm2Mrk1T+bbsBVChBxwMn3Z9syXgDfBjLhoVKUZRNxA/hs1EcTy7Q== X-Received: by 2002:a0c:f8c5:: with SMTP id h5mr609172qvo.12.1565050264988; Mon, 05 Aug 2019 17:11:04 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id c5sm39049453qkb.41.2019.08.05.17.11.03 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 05 Aug 2019 17:11:04 -0700 (PDT) Date: Mon, 5 Aug 2019 17:10:36 -0700 From: Jakub Kicinski To: Y Song , Alexei Starovoitov Cc: Farid Zakaria , Daniel Borkmann , netdev , bpf Subject: Re: [PATCH 1/1] bpf: introduce new helper udp_flow_src_port Message-ID: <20190805171036.5a5bf790@cakuba.netronome.com> In-Reply-To: References: <20190803044320.5530-1-farid.m.zakaria@gmail.com> <20190803044320.5530-2-farid.m.zakaria@gmail.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Sat, 3 Aug 2019 23:52:16 -0700, Y Song wrote: > > include/uapi/linux/bpf.h | 21 +++++++-- > > net/core/filter.c | 20 ++++++++ > > tools/include/uapi/linux/bpf.h | 21 +++++++-- > > tools/testing/selftests/bpf/bpf_helpers.h | 2 + > > .../bpf/prog_tests/udp_flow_src_port.c | 28 +++++++++++ > > .../bpf/progs/test_udp_flow_src_port_kern.c | 47 +++++++++++++++++++ > > 6 files changed, 131 insertions(+), 8 deletions(-) > > create mode 100644 tools/testing/selftests/bpf/prog_tests/udp_flow_src_port.c > > create mode 100644 tools/testing/selftests/bpf/progs/test_udp_flow_src_port_kern.c > > First, for each review, backport and sync with libbpf repo, in the future, > could you break the patch to two patches? > 1. kernel changes (net/core/filter.c, include/uapi/linux/bpf.h) > 2. tools/include/uapi/linux/bpf.h > 3. tools/testing/ changes A lot of people get caught off by this, could explain why this is necessary? git can deal with this scenario without missing a step, format-patch takes paths: $ git show --oneline -s 1002f3e955d7 (HEAD) bpf: introduce new helper udp_flow_src_port $ git format-patch HEAD~ -- tools/include/uapi/linux/bpf.h 0001-bpf-introduce-new-helper-udp_flow_src_port.patch $ grep -B1 changed 0001-bpf-introduce-new-helper-udp_flow_src_port.patch tools/include/uapi/linux/bpf.h | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) $ cd ../libbpf $ git am -p2 ../linux/0001-bpf-introduce-new-helper-udp_flow_src_port.patch Applying: bpf: introduce new helper udp_flow_src_port error: patch failed: include/uapi/linux/bpf.h:2853 error: include/uapi/linux/bpf.h: patch does not apply ... Well, the patch doesn't apply to libbpf right now, but git finds the right paths and all that. IMO it'd be good to not have this artificial process obstacle and all the "sync headers" commits in the tree.