From: Daniel Borkmann <daniel@iogearbox.net>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, m@lambda.lt,
edumazet@google.com, ast@kernel.org, willemb@google.com,
Daniel Borkmann <daniel@iogearbox.net>
Subject: [PATCH net v2 0/2] Fix collisions in socket cookie generation
Date: Thu, 8 Aug 2019 13:57:24 +0200 [thread overview]
Message-ID: <20190808115726.31703-1-daniel@iogearbox.net> (raw)
This change makes the socket cookie generator as a global counter
instead of per netns in order to fix cookie collisions for BPF use
cases we ran into. See main patch #1 for more details.
Given the change is small/trivial and fixes an issue we're seeing
my preference would be net tree (though it cleanly applies to
net-next as well). Went for net tree instead of bpf tree here given
the main change is in net/core/sock_diag.c, but either way would be
fine with me.
Thanks a lot!
v1 -> v2:
- Fix up commit description in patch #1, thanks Eric!
Daniel Borkmann (2):
sock: make cookie generation global instead of per netns
bpf: sync bpf.h to tools infrastructure
include/net/net_namespace.h | 1 -
include/uapi/linux/bpf.h | 4 ++--
net/core/sock_diag.c | 3 ++-
tools/include/uapi/linux/bpf.h | 11 +++++++----
4 files changed, 11 insertions(+), 8 deletions(-)
--
2.17.1
next reply other threads:[~2019-08-08 11:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 11:57 Daniel Borkmann [this message]
2019-08-08 11:57 ` [PATCH net v2 1/2] sock: make cookie generation global instead of per netns Daniel Borkmann
2019-08-08 11:57 ` [PATCH net v2 2/2] bpf: sync bpf.h to tools infrastructure Daniel Borkmann
2019-08-09 20:15 ` [PATCH net v2 0/2] Fix collisions in socket cookie generation David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190808115726.31703-1-daniel@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=m@lambda.lt \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).