From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D6D4C32753 for ; Tue, 13 Aug 2019 13:09:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 422212067D for ; Tue, 13 Aug 2019 13:09:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="FA3IsM7W" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728796AbfHMNJl (ORCPT ); Tue, 13 Aug 2019 09:09:41 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:53973 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728749AbfHMNJk (ORCPT ); Tue, 13 Aug 2019 09:09:40 -0400 Received: by mail-wm1-f67.google.com with SMTP id 10so1458961wmp.3 for ; Tue, 13 Aug 2019 06:09:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=5t2Cjkq2qCeaG9kNbXuJM01Wwz49tMsT0IYIprvtUF8=; b=FA3IsM7WCftMDKM0KjEbh9ABTtcFnjKmj12/6SWB8PeXc4fR7K44ra8Iab2SO4Jp4e QTtTaobooTjCmkDrYD5zV9oRRHGwGiwUs/ASEtee0k4otrCtjM+4QMwUj0DEYLsgltQ5 +i3zSu29EgB1vmd5SX3Q6epR3pQoDAZPhV53t6ILZV9oDXPujLuvSI3fmfa8mshpdUq3 9K8m7sEkSHL4WceaASxVo6HTFdkbmssFWnLray1mqp3BdPBAZERNtQLPanSKjd2aOkOA ylK+I6iOb9OeSHse0mCeQg505nQxGFk1oZtYLqDb6fpoRFsppMbeh/aXkieG23D3WGe+ JiKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=5t2Cjkq2qCeaG9kNbXuJM01Wwz49tMsT0IYIprvtUF8=; b=TY3+CKapsjhRW5kx2HE6ggmVkYUfsa9CcRZpwezb8kflybd6oOXyVcfUi1CY8u5byH ZwFtbpdkIykzt4T54vlK0lwQo4jjLdudkUl5qq4bMURSnbzvv0CBYgLL5ew+4Da3S9Pe y6JdZP2fMV2NR/p3yhWVQZlmvXEZLNt2styv2lKs51eNOpPzeUOPRFyGDBcBOQTN5A3s R0unNgEBgZ6d8u2z+BYmfWnkDU0Oyrcuu+8pB00KbnE2NjRQ9bsONF5aDdfpSh258iwg Fb70J+tidirwaN3BvuE3Jpq3sepKbn/fbkgASVtzaZx68aHcegdTkY6Zea7LTbeeEmCG KTVA== X-Gm-Message-State: APjAAAUZQuFo5oGtWAIldEBSO0wqmIbvrAcDScrar32YKq8+giWhSRtK hmXaonT3Y5XSUJEJnZ3bOnXANlp5ozw= X-Google-Smtp-Source: APXvYqxc+qQGpvM2IgwsH3+RygwGjsblkYoJEGg1sDVSn/qkgvJxBi2OIVQW+kU7lZtysghRtLpIlw== X-Received: by 2002:a05:600c:2411:: with SMTP id 17mr2853483wmp.171.1565701778589; Tue, 13 Aug 2019 06:09:38 -0700 (PDT) Received: from cbtest32.netronome.com ([217.38.71.146]) by smtp.gmail.com with ESMTPSA id e3sm130534191wrs.37.2019.08.13.06.09.37 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 13 Aug 2019 06:09:37 -0700 (PDT) From: Quentin Monnet To: Alexei Starovoitov , Daniel Borkmann Cc: bpf@vger.kernel.org, netdev@vger.kernel.org, oss-drivers@netronome.com, Quentin Monnet Subject: [RFC bpf-next 2/3] tools: bpftool: make comment more explicit for count of dumped entries Date: Tue, 13 Aug 2019 14:09:20 +0100 Message-Id: <20190813130921.10704-3-quentin.monnet@netronome.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190813130921.10704-1-quentin.monnet@netronome.com> References: <20190813130921.10704-1-quentin.monnet@netronome.com> Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org The counter printed at the end of plain map dump does not reflect the exact number of entries in the map, but the number of entries bpftool managed to dump (some of them could not be read, or made no sense to dump (map-in-map...)). Edit slightly the message to make this more explicit. Signed-off-by: Quentin Monnet Reviewed-by: Jakub Kicinski --- tools/bpf/bpftool/map.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/bpf/bpftool/map.c b/tools/bpf/bpftool/map.c index 206ee46189d9..cead639b3ab1 100644 --- a/tools/bpf/bpftool/map.c +++ b/tools/bpf/bpftool/map.c @@ -809,7 +809,7 @@ static int do_dump(int argc, char **argv) jsonw_end_array(btf_wtr); jsonw_destroy(&btf_wtr); } else { - printf("Found %u element%s\n", num_elems, + printf("Found %u element%s to dump\n", num_elems, num_elems != 1 ? "s" : ""); } -- 2.17.1