BPF Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v1] tools: Keep list of tools in alphabetical order
@ 2019-06-28 17:22 Andy Shevchenko
  2019-06-28 17:53 ` Song Liu
  0 siblings, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2019-06-28 17:22 UTC (permalink / raw)
  To: Alexei Starovoitov, Daniel Borkmann, bpf, Martin KaFai Lau,
	Song Liu, Yonghong Song
  Cc: Andy Shevchenko

When `make help` is executed it lists the possible tools to build,
though couple of entries is kept unordered. Fix it here.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 tools/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/Makefile b/tools/Makefile
index 3dfd72ae6c1a..02585735320c 100644
--- a/tools/Makefile
+++ b/tools/Makefile
@@ -10,6 +10,7 @@ help:
 	@echo 'Possible targets:'
 	@echo ''
 	@echo '  acpi                   - ACPI tools'
+	@echo '  bpf                    - misc BPF tools'
 	@echo '  cgroup                 - cgroup tools'
 	@echo '  cpupower               - a tool for all things x86 CPU power'
 	@echo '  debugging              - tools for debugging'
@@ -22,12 +23,11 @@ help:
 	@echo '  kvm_stat               - top-like utility for displaying kvm statistics'
 	@echo '  leds                   - LEDs  tools'
 	@echo '  liblockdep             - user-space wrapper for kernel locking-validator'
-	@echo '  bpf                    - misc BPF tools'
+	@echo '  objtool                - an ELF object analysis tool'
 	@echo '  pci                    - PCI tools'
 	@echo '  perf                   - Linux performance measurement and analysis tool'
 	@echo '  selftests              - various kernel selftests'
 	@echo '  spi                    - spi tools'
-	@echo '  objtool                - an ELF object analysis tool'
 	@echo '  tmon                   - thermal monitoring and tuning tool'
 	@echo '  turbostat              - Intel CPU idle stats and freq reporting tool'
 	@echo '  usb                    - USB testing tools'
-- 
2.20.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v1] tools: Keep list of tools in alphabetical order
  2019-06-28 17:22 [PATCH v1] tools: Keep list of tools in alphabetical order Andy Shevchenko
@ 2019-06-28 17:53 ` Song Liu
  2019-08-12 18:27   ` Andy Shevchenko
  2019-08-13 14:17   ` Arnaldo Carvalho de Melo
  0 siblings, 2 replies; 4+ messages in thread
From: Song Liu @ 2019-06-28 17:53 UTC (permalink / raw)
  To: Andy Shevchenko
  Cc: Alexei Starovoitov, Daniel Borkmann, bpf, Martin KaFai Lau,
	Song Liu, Yonghong Song

On Fri, Jun 28, 2019 at 10:23 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> When `make help` is executed it lists the possible tools to build,
> though couple of entries is kept unordered. Fix it here.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Acked-by: Song Liu <songliubraving@fb.com>

> ---
>  tools/Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/Makefile b/tools/Makefile
> index 3dfd72ae6c1a..02585735320c 100644
> --- a/tools/Makefile
> +++ b/tools/Makefile
> @@ -10,6 +10,7 @@ help:
>         @echo 'Possible targets:'
>         @echo ''
>         @echo '  acpi                   - ACPI tools'
> +       @echo '  bpf                    - misc BPF tools'
>         @echo '  cgroup                 - cgroup tools'
>         @echo '  cpupower               - a tool for all things x86 CPU power'
>         @echo '  debugging              - tools for debugging'
> @@ -22,12 +23,11 @@ help:
>         @echo '  kvm_stat               - top-like utility for displaying kvm statistics'
>         @echo '  leds                   - LEDs  tools'
>         @echo '  liblockdep             - user-space wrapper for kernel locking-validator'
> -       @echo '  bpf                    - misc BPF tools'
> +       @echo '  objtool                - an ELF object analysis tool'
>         @echo '  pci                    - PCI tools'
>         @echo '  perf                   - Linux performance measurement and analysis tool'
>         @echo '  selftests              - various kernel selftests'
>         @echo '  spi                    - spi tools'
> -       @echo '  objtool                - an ELF object analysis tool'
>         @echo '  tmon                   - thermal monitoring and tuning tool'
>         @echo '  turbostat              - Intel CPU idle stats and freq reporting tool'
>         @echo '  usb                    - USB testing tools'
> --
> 2.20.1
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v1] tools: Keep list of tools in alphabetical order
  2019-06-28 17:53 ` Song Liu
@ 2019-08-12 18:27   ` Andy Shevchenko
  2019-08-13 14:17   ` Arnaldo Carvalho de Melo
  1 sibling, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2019-08-12 18:27 UTC (permalink / raw)
  To: Song Liu
  Cc: Alexei Starovoitov, Daniel Borkmann, bpf, Martin KaFai Lau,
	Song Liu, Yonghong Song

On Fri, Jun 28, 2019 at 10:53:27AM -0700, Song Liu wrote:
> On Fri, Jun 28, 2019 at 10:23 AM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > When `make help` is executed it lists the possible tools to build,
> > though couple of entries is kept unordered. Fix it here.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> Acked-by: Song Liu <songliubraving@fb.com>

Thank you.
I am wondering who can apply it. Alexei?

> 
> > ---
> >  tools/Makefile | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/tools/Makefile b/tools/Makefile
> > index 3dfd72ae6c1a..02585735320c 100644
> > --- a/tools/Makefile
> > +++ b/tools/Makefile
> > @@ -10,6 +10,7 @@ help:
> >         @echo 'Possible targets:'
> >         @echo ''
> >         @echo '  acpi                   - ACPI tools'
> > +       @echo '  bpf                    - misc BPF tools'
> >         @echo '  cgroup                 - cgroup tools'
> >         @echo '  cpupower               - a tool for all things x86 CPU power'
> >         @echo '  debugging              - tools for debugging'
> > @@ -22,12 +23,11 @@ help:
> >         @echo '  kvm_stat               - top-like utility for displaying kvm statistics'
> >         @echo '  leds                   - LEDs  tools'
> >         @echo '  liblockdep             - user-space wrapper for kernel locking-validator'
> > -       @echo '  bpf                    - misc BPF tools'
> > +       @echo '  objtool                - an ELF object analysis tool'
> >         @echo '  pci                    - PCI tools'
> >         @echo '  perf                   - Linux performance measurement and analysis tool'
> >         @echo '  selftests              - various kernel selftests'
> >         @echo '  spi                    - spi tools'
> > -       @echo '  objtool                - an ELF object analysis tool'
> >         @echo '  tmon                   - thermal monitoring and tuning tool'
> >         @echo '  turbostat              - Intel CPU idle stats and freq reporting tool'
> >         @echo '  usb                    - USB testing tools'
> > --
> > 2.20.1
> >

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v1] tools: Keep list of tools in alphabetical order
  2019-06-28 17:53 ` Song Liu
  2019-08-12 18:27   ` Andy Shevchenko
@ 2019-08-13 14:17   ` Arnaldo Carvalho de Melo
  1 sibling, 0 replies; 4+ messages in thread
From: Arnaldo Carvalho de Melo @ 2019-08-13 14:17 UTC (permalink / raw)
  To: Song Liu
  Cc: Andy Shevchenko, Alexei Starovoitov, Daniel Borkmann, bpf,
	Martin KaFai Lau, Song Liu, Yonghong Song

Em Fri, Jun 28, 2019 at 10:53:27AM -0700, Song Liu escreveu:
> On Fri, Jun 28, 2019 at 10:23 AM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > When `make help` is executed it lists the possible tools to build,
> > though couple of entries is kept unordered. Fix it here.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> Acked-by: Song Liu <songliubraving@fb.com>

Thanks, applied.

- Arnaldo

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-28 17:22 [PATCH v1] tools: Keep list of tools in alphabetical order Andy Shevchenko
2019-06-28 17:53 ` Song Liu
2019-08-12 18:27   ` Andy Shevchenko
2019-08-13 14:17   ` Arnaldo Carvalho de Melo

BPF Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/bpf/0 bpf/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 bpf bpf/ https://lore.kernel.org/bpf \
		bpf@vger.kernel.org bpf@archiver.kernel.org
	public-inbox-index bpf


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.bpf


AGPL code for this site: git clone https://public-inbox.org/ public-inbox