From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C695C32750 for ; Tue, 13 Aug 2019 17:08:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1CB5620840 for ; Tue, 13 Aug 2019 17:08:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565716118; bh=65STqoKxZejhRA8D9TwQa+K2PAMisn1xsEutBY/kUY0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=fv0nmac4vbS7XAO34utn2/OA33u/vO35XF8VqHHdquScfYdUwK4M9lK8XFOjS4GnX ZTk8WpivQBDLjEBV/n9QbfTR1s68NA5ZHEScOrI/HFnXGdhM4ZVV0w5Yqiu1ue3qCQ OPCVE/+9hYgY8jl1RTHNsii8eyebj8Zv87EvprPM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726155AbfHMRIh (ORCPT ); Tue, 13 Aug 2019 13:08:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:40334 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726094AbfHMRIh (ORCPT ); Tue, 13 Aug 2019 13:08:37 -0400 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 50A5020679; Tue, 13 Aug 2019 17:08:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565716117; bh=65STqoKxZejhRA8D9TwQa+K2PAMisn1xsEutBY/kUY0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=e8o5cKrg0h7l3Es4XUW2/tElqvpgDv1p8yDzOCq5FdWQnf1aMYy0Xzef2T/tELhCD s0upFTQQ5MtnqWUt7HUvO/2NRH2JQikPkh4tk9SAzwfYzOGXhtLhiE0lh5gNu7Nibj fm3edf+JH5WVs5yzATU7sOHcbCWCbW1hmNJjWplI= Date: Tue, 13 Aug 2019 18:08:30 +0100 From: Will Deacon To: Miguel Ojeda Cc: Nick Desaulniers , Andrew Morton , Sedat Dilek , Josh Poimboeuf , yhs@fb.com, clang-built-linux@googlegroups.com, Catalin Marinas , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Andrey Konovalov , Greg Kroah-Hartman , Enrico Weigelt , Suzuki K Poulose , Thomas Gleixner , Masayoshi Mizuma , Shaokun Zhang , Alexios Zavras , Allison Randal , Linux ARM , linux-kernel , Network Development , bpf@vger.kernel.org Subject: Re: [PATCH 12/16] arm64: prefer __section from compiler_attributes.h Message-ID: <20190813170829.c3lryb6va3eopxd7@willie-the-truck> References: <20190812215052.71840-1-ndesaulniers@google.com> <20190812215052.71840-12-ndesaulniers@google.com> <20190813082744.xmzmm4j675rqiz47@willie-the-truck> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Tue, Aug 13, 2019 at 02:36:06PM +0200, Miguel Ojeda wrote: > On Tue, Aug 13, 2019 at 10:27 AM Will Deacon wrote: > > On Mon, Aug 12, 2019 at 02:50:45PM -0700, Nick Desaulniers wrote: > > > GCC unescapes escaped string section names while Clang does not. Because > > > __section uses the `#` stringification operator for the section name, it > > > doesn't need to be escaped. > > > > > > This antipattern was found with: > > > $ grep -e __section\(\" -e __section__\(\" -r > > > > > > Reported-by: Sedat Dilek > > > Suggested-by: Josh Poimboeuf > > > Signed-off-by: Nick Desaulniers > > > --- > > > arch/arm64/include/asm/cache.h | 2 +- > > > arch/arm64/kernel/smp_spin_table.c | 2 +- > > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > Does this fix a build issue, or is it just cosmetic or do we end up with > > duplicate sections or something else? > > This should be cosmetic -- basically we are trying to move all users > of current available __attribute__s in compiler_attributes.h to the > __attr forms. I am also adding (slowly) new attributes that are > already used but we don't have them yet in __attr form. > > > Happy to route it via arm64, just having trouble working out whether it's > > 5.3 material! > > As you prefer! Those that are not taken by a maintainer I will pick up > and send via compiler-attributes. > > I would go for 5.4, since there is no particular rush anyway. Okey doke, I'll pick this one up for 5.4 then. Thanks for the explanation! Will