* [PATCH] selftests: bpf: install files test_xdp_vlan.sh
@ 2019-08-20 13:41 Anders Roxell
2019-08-20 14:07 ` Jesper Dangaard Brouer
2019-08-21 15:11 ` Daniel Borkmann
0 siblings, 2 replies; 3+ messages in thread
From: Anders Roxell @ 2019-08-20 13:41 UTC (permalink / raw)
To: shuah, ast, daniel, davem, jakub.kicinski, hawk, john.fastabend
Cc: linux-kselftest, netdev, bpf, linux-kernel, Anders Roxell
When ./test_xdp_vlan_mode_generic.sh runs it complains that it can't
find file test_xdp_vlan.sh.
# selftests: bpf: test_xdp_vlan_mode_generic.sh
# ./test_xdp_vlan_mode_generic.sh: line 9: ./test_xdp_vlan.sh: No such
file or directory
Rework so that test_xdp_vlan.sh gets installed, added to the variable
TEST_PROGS_EXTENDED.
Fixes: d35661fcf95d ("selftests/bpf: add wrapper scripts for test_xdp_vlan.sh")
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
tools/testing/selftests/bpf/Makefile | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
index 1faad0c3c3c9..d7968e20463c 100644
--- a/tools/testing/selftests/bpf/Makefile
+++ b/tools/testing/selftests/bpf/Makefile
@@ -68,7 +68,8 @@ TEST_PROGS := test_kmod.sh \
TEST_PROGS_EXTENDED := with_addr.sh \
with_tunnels.sh \
tcp_client.py \
- tcp_server.py
+ tcp_server.py \
+ test_xdp_vlan.sh
# Compile but not part of 'make run_tests'
TEST_GEN_PROGS_EXTENDED = test_libbpf_open test_sock_addr test_skb_cgroup_id_user \
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] selftests: bpf: install files test_xdp_vlan.sh
2019-08-20 13:41 [PATCH] selftests: bpf: install files test_xdp_vlan.sh Anders Roxell
@ 2019-08-20 14:07 ` Jesper Dangaard Brouer
2019-08-21 15:11 ` Daniel Borkmann
1 sibling, 0 replies; 3+ messages in thread
From: Jesper Dangaard Brouer @ 2019-08-20 14:07 UTC (permalink / raw)
To: Anders Roxell
Cc: shuah, ast, daniel, davem, jakub.kicinski, hawk, john.fastabend,
linux-kselftest, netdev, bpf, linux-kernel
On Tue, 20 Aug 2019 15:41:21 +0200
Anders Roxell <anders.roxell@linaro.org> wrote:
> When ./test_xdp_vlan_mode_generic.sh runs it complains that it can't
> find file test_xdp_vlan.sh.
>
> # selftests: bpf: test_xdp_vlan_mode_generic.sh
> # ./test_xdp_vlan_mode_generic.sh: line 9: ./test_xdp_vlan.sh: No such
> file or directory
>
> Rework so that test_xdp_vlan.sh gets installed, added to the variable
> TEST_PROGS_EXTENDED.
>
> Fixes: d35661fcf95d ("selftests/bpf: add wrapper scripts for test_xdp_vlan.sh")
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> ---
Thanks for catching this!
Acked-by: Jesper Dangaard Brouer <jbrouer@redhat.com>
> tools/testing/selftests/bpf/Makefile | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
> index 1faad0c3c3c9..d7968e20463c 100644
> --- a/tools/testing/selftests/bpf/Makefile
> +++ b/tools/testing/selftests/bpf/Makefile
> @@ -68,7 +68,8 @@ TEST_PROGS := test_kmod.sh \
> TEST_PROGS_EXTENDED := with_addr.sh \
> with_tunnels.sh \
> tcp_client.py \
> - tcp_server.py
> + tcp_server.py \
> + test_xdp_vlan.sh
>
> # Compile but not part of 'make run_tests'
> TEST_GEN_PROGS_EXTENDED = test_libbpf_open test_sock_addr test_skb_cgroup_id_user \
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] selftests: bpf: install files test_xdp_vlan.sh
2019-08-20 13:41 [PATCH] selftests: bpf: install files test_xdp_vlan.sh Anders Roxell
2019-08-20 14:07 ` Jesper Dangaard Brouer
@ 2019-08-21 15:11 ` Daniel Borkmann
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Borkmann @ 2019-08-21 15:11 UTC (permalink / raw)
To: Anders Roxell, shuah, ast, davem, jakub.kicinski, hawk, john.fastabend
Cc: linux-kselftest, netdev, bpf, linux-kernel
On 8/20/19 3:41 PM, Anders Roxell wrote:
> When ./test_xdp_vlan_mode_generic.sh runs it complains that it can't
> find file test_xdp_vlan.sh.
>
> # selftests: bpf: test_xdp_vlan_mode_generic.sh
> # ./test_xdp_vlan_mode_generic.sh: line 9: ./test_xdp_vlan.sh: No such
> file or directory
>
> Rework so that test_xdp_vlan.sh gets installed, added to the variable
> TEST_PROGS_EXTENDED.
>
> Fixes: d35661fcf95d ("selftests/bpf: add wrapper scripts for test_xdp_vlan.sh")
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-21 15:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-20 13:41 [PATCH] selftests: bpf: install files test_xdp_vlan.sh Anders Roxell
2019-08-20 14:07 ` Jesper Dangaard Brouer
2019-08-21 15:11 ` Daniel Borkmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).