From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Stanislav Fomichev <sdf@google.com>
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, davem@davemloft.net,
ast@kernel.org, daniel@iogearbox.net
Subject: Re: [PATCH bpf-next 0/6] selftests/bpf: move sockopt tests under test_progs
Date: Wed, 4 Sep 2019 16:03:33 -0700 [thread overview]
Message-ID: <20190904230331.ld4zsn4jgldu7l6q@ast-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <20190904162509.199561-1-sdf@google.com>
On Wed, Sep 04, 2019 at 09:25:03AM -0700, Stanislav Fomichev wrote:
> Now that test_progs is shaping into more generic test framework,
> let's convert sockopt tests to it. This requires adding
> a helper to create and join a cgroup first (test__join_cgroup).
> Since we already hijack stdout/stderr that shouldn't be
> a problem (cgroup helpers log to stderr).
>
> The rest of the patches just move sockopt tests files under prog_tests/
> and do the required small adjustments.
Looks good. Thank you for working on it.
Could you de-verbose setsockopt test a bit?
#23/32 setsockopt: deny write ctx->retval:OK
#23/33 setsockopt: deny read ctx->retval:OK
#23/34 setsockopt: deny writing to ctx->optval:OK
#23/35 setsockopt: deny writing to ctx->optval_end:OK
#23/36 setsockopt: allow IP_TOS <= 128:OK
#23/37 setsockopt: deny IP_TOS > 128:OK
37 subtests is a bit too much spam.
next prev parent reply other threads:[~2019-09-04 23:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 16:25 [PATCH bpf-next 0/6] selftests/bpf: move sockopt tests under test_progs Stanislav Fomichev
2019-09-04 16:25 ` [PATCH bpf-next 1/6] selftests/bpf: test_progs: add test__join_cgroup helper Stanislav Fomichev
2019-09-04 16:25 ` [PATCH bpf-next 2/6] selftests/bpf: test_progs: convert test_sockopt Stanislav Fomichev
2019-09-04 16:25 ` [PATCH bpf-next 3/6] selftests/bpf: test_progs: convert test_sockopt_sk Stanislav Fomichev
2019-09-04 16:25 ` [PATCH bpf-next 4/6] selftests/bpf: test_progs: convert test_sockopt_multi Stanislav Fomichev
2019-09-04 16:25 ` [PATCH bpf-next 5/6] selftests/bpf: test_progs: convert test_sockopt_inherit Stanislav Fomichev
2019-09-04 16:25 ` [PATCH bpf-next 6/6] selftests/bpf: test_progs: convert test_tcp_rtt Stanislav Fomichev
2019-09-04 23:03 ` Alexei Starovoitov [this message]
2019-09-06 9:32 ` [PATCH bpf-next 0/6] selftests/bpf: move sockopt tests under test_progs Andrii Nakryiko
2019-09-06 15:18 ` Stanislav Fomichev
2019-09-06 16:42 ` Alexei Starovoitov
2019-09-06 17:02 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190904230331.ld4zsn4jgldu7l6q@ast-mbp.dhcp.thefacebook.com \
--to=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sdf@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).