bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: ast@kernel.org, daniel@iogearbox.net, yhs@fb.com,
	davem@davemloft.net, jakub.kicinski@netronome.com,
	hawk@kernel.org, john.fastabend@gmail.com,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	bpf@vger.kernel.org, clang-built-linux@googlegroups.com
Subject: Re: [PATCH bpf-next 8/8] samples: bpf: Makefile: base progs build on Makefile.progs
Date: Sat, 7 Sep 2019 04:24:49 +0300	[thread overview]
Message-ID: <20190907012448.GC3053@khorivan> (raw)
In-Reply-To: <20190906233429.6ass5x5inaypvbpr@ast-mbp.dhcp.thefacebook.com>

On Fri, Sep 06, 2019 at 04:34:31PM -0700, Alexei Starovoitov wrote:
>On Thu, Sep 05, 2019 at 12:22:12AM +0300, Ivan Khoronzhuk wrote:
>> +
>> +If need to use environment of target board, the SYSROOT also can be set,
>> +pointing on FS of target board:
>> +
>> +make samples/bpf/ LLC=~/git/llvm/build/bin/llc \
>> +     CLANG=~/git/llvm/build/bin/clang \
>> +     SYSROOT=~/some_sdk/linux-devkit/sysroots/aarch64-linux-gnu
>
>Patches 7 and 8 look quite heavy. I don't have a way to test them
>which makes me a bit uneasy to accept them as-is.
>Would be great if somebody could give Tested-by.
>
I can try to split patch 8 in v2, but not significantly.

-- 
Regards,
Ivan Khoronzhuk

      reply	other threads:[~2019-09-07  1:25 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-04 21:22 [PATCH bpf-next 0/8] samples: bpf: improve/fix cross-compilation Ivan Khoronzhuk
2019-09-04 21:22 ` [PATCH bpf-next 1/8] samples: bpf: Makefile: use --target from cross-compile Ivan Khoronzhuk
2019-09-04 21:22 ` [PATCH bpf-next 2/8] samples: bpf: Makefile: remove target for native build Ivan Khoronzhuk
2019-09-06 23:31   ` Alexei Starovoitov
2019-09-06 23:52     ` Ivan Khoronzhuk
2019-09-07  0:04       ` Alexei Starovoitov
2019-09-07  0:19         ` Ivan Khoronzhuk
2019-09-04 21:22 ` [PATCH bpf-next 3/8] libbpf: Makefile: add C/CXX/LDFLAGS to libbpf.so and test_libpf targets Ivan Khoronzhuk
2019-09-04 21:22 ` [PATCH bpf-next 4/8] samples: bpf: use own EXTRA_CFLAGS for clang commands Ivan Khoronzhuk
2019-09-04 21:22 ` [PATCH bpf-next 5/8] samples: bpf: Makefile: use vars from KBUILD_CFLAGS to handle linux headers Ivan Khoronzhuk
2019-09-04 21:22 ` [PATCH bpf-next 6/8] samples: bpf: makefile: fix HDR_PROBE "echo" Ivan Khoronzhuk
2019-09-04 21:22 ` [PATCH bpf-next 7/8] samples: bpf: add makefile.prog for separate CC build Ivan Khoronzhuk
2019-09-04 21:22 ` [PATCH bpf-next 8/8] samples: bpf: Makefile: base progs build on Makefile.progs Ivan Khoronzhuk
2019-09-06 23:34   ` Alexei Starovoitov
2019-09-07  1:24     ` Ivan Khoronzhuk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190907012448.GC3053@khorivan \
    --to=ivan.khoronzhuk@linaro.org \
    --cc=alexei.starovoitov@gmail.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=clang-built-linux@googlegroups.com \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=hawk@kernel.org \
    --cc=jakub.kicinski@netronome.com \
    --cc=john.fastabend@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).