From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C9ECC4CEC8 for ; Fri, 13 Sep 2019 19:56:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 55B7520692 for ; Fri, 13 Sep 2019 19:56:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Lv802009" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388636AbfIMT4X (ORCPT ); Fri, 13 Sep 2019 15:56:23 -0400 Received: from mail-lj1-f193.google.com ([209.85.208.193]:34267 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730862AbfIMT4T (ORCPT ); Fri, 13 Sep 2019 15:56:19 -0400 Received: by mail-lj1-f193.google.com with SMTP id h2so21734433ljk.1 for ; Fri, 13 Sep 2019 12:56:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=YangW0nZxTvuxMasR2T71zvAAP15OctV2hgPwvy27lg=; b=Lv802009QJLjWjD4UFEK/0Dz70rSsQfJEfZlJop0qI82z5JcfLHl/2r2yyVgEryl7W 1V7VB3t+6OehDmsN2DQE6ni7NaHcNp2Qjk+v7bOHqiHHSz/ZfSd5aH8FGktHFz/WpMz/ D8RTy+RrxlShPKtX937BcbB6hfALtCl/w/SIvP1D5hP+Ix7kQz7pUK9Ag6Bd/qsGEfY5 KhFEStm+Ybxo1UKqlwTX0KMQD9eMED1Y042cfErh2l0YgwbTnPYwD9nVFRq3Gzh+TfHO fqaWvWl9PsK0qoDo6vcQ6e0OPQ13DFgLWXPo9HATYldmlKn3Y8H/flKflvJiDhZuxMkB e/ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=YangW0nZxTvuxMasR2T71zvAAP15OctV2hgPwvy27lg=; b=TRR7hYnF/uXeISOR5H6N5b6tg0G0DTKtSGGFPG/Vf9ga+ngTdUKzJnJxAdO3vwMMlU XC/BnmEau2xQkbS6kiYxIGk80pKr3vl7bkLSLJz69EBrCV0hx6Jy5BxXmcPJNwE/fy1h J3o/1vpLiK+Kkdmin7+5cw5gXd4T0djsQG6KMomnprw07BJUW+YBvUxQMYTYUQ5rIZT8 dYL5rc1jcvK4arsUzWNg4zFz9fSFHPkm8lMlpvj0VhjzonYVWL634yoCBliiRJKwjc+e hMMhM3SAsktlyma47dWphUoUboZSQvNSX4Rkl5mnaokwf4+Fa9+xp7QzM/pqE162WhlB a4uw== X-Gm-Message-State: APjAAAUSMB6HY3vVAeN81qOh3TFOPlYwNX49cObzhXdjrqnlEULOy+zi 1+cIsnFKWDxvBHJ2zgn/EweI1A== X-Google-Smtp-Source: APXvYqxU70mxnPTmi2ptT3akvixZSFIEhcR1gb+O4j9tliEriL3aAlVfx0PwNFAE3sW28jupZdNinA== X-Received: by 2002:a2e:7801:: with SMTP id t1mr16881585ljc.140.1568404576977; Fri, 13 Sep 2019 12:56:16 -0700 (PDT) Received: from khorivan (168-200-94-178.pool.ukrtel.net. [178.94.200.168]) by smtp.gmail.com with ESMTPSA id p8sm6581687ljn.93.2019.09.13.12.56.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 13 Sep 2019 12:56:16 -0700 (PDT) Date: Fri, 13 Sep 2019 22:56:14 +0300 From: Ivan Khoronzhuk To: Sergei Shtylyov Cc: ast@kernel.org, daniel@iogearbox.net, yhs@fb.com, davem@davemloft.net, jakub.kicinski@netronome.com, hawk@kernel.org, john.fastabend@gmail.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, clang-built-linux@googlegroups.com Subject: Re: [PATCH bpf-next 01/11] samples: bpf: makefile: fix HDR_PROBE "echo" Message-ID: <20190913195612.GA26724@khorivan> Mail-Followup-To: Sergei Shtylyov , ast@kernel.org, daniel@iogearbox.net, yhs@fb.com, davem@davemloft.net, jakub.kicinski@netronome.com, hawk@kernel.org, john.fastabend@gmail.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, clang-built-linux@googlegroups.com References: <20190910103830.20794-1-ivan.khoronzhuk@linaro.org> <20190910103830.20794-2-ivan.khoronzhuk@linaro.org> <55803f7e-a971-d71a-fcc2-76ae1cf813bf@cogentembedded.com> <20190910145359.GD3053@khorivan> <4251fe86-ccc7-f1ce-e954-2d488d2a95a9@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4251fe86-ccc7-f1ce-e954-2d488d2a95a9@cogentembedded.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Wed, Sep 11, 2019 at 02:02:11PM +0300, Sergei Shtylyov wrote: >On 10.09.2019 17:54, Ivan Khoronzhuk wrote: > >>>Hello! >>> >>>On 10.09.2019 13:38, Ivan Khoronzhuk wrote: >>> >>>>echo should be replaced on echo -e to handle \n correctly, but instead, >>> >>> s/on/with/? >>s/echo/printf/ instead of s/echo/echo -e/ > > I only pointed that 'on' is incorrect there. You replace something >/with/ something other... > >> >>printf looks better. >> >>> >>>>replace it on printf as some systems can't handle echo -e. >>> >>>  Likewise? > > Same grammatical mistake. Oh, will correct it next v. -- Regards, Ivan Khoronzhuk