From: kbuild test robot <lkp@intel.com>
To: Daniel Xu <dxu@dxuuu.xyz>
Cc: kbuild-all@01.org, bpf@vger.kernel.org, songliubraving@fb.com,
yhs@fb.com, andriin@fb.com, peterz@infradead.org,
mingo@redhat.com, acme@kernel.org, Daniel Xu <dxu@dxuuu.xyz>,
ast@fb.com, alexander.shishkin@linux.intel.com, jolsa@redhat.com,
namhyung@kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH bpf-next 1/5] perf/core: Add PERF_FORMAT_LOST read_format
Date: Tue, 17 Sep 2019 22:32:34 +0800 [thread overview]
Message-ID: <201909172200.sXLlokCN%lkp@intel.com> (raw)
In-Reply-To: <20190917133056.5545-2-dxu@dxuuu.xyz>
[-- Attachment #1: Type: text/plain, Size: 1672 bytes --]
Hi Daniel,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on bpf-next/master]
url: https://github.com/0day-ci/linux/commits/Daniel-Xu/perf-core-Add-PERF_FORMAT_LOST-read_format/20190917-213515
base: https://kernel.googlesource.com/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: i386-tinyconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-11) 7.4.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
kernel/events/core.c: In function 'perf_event_lost':
>> kernel/events/core.c:4753:11: error: implicit declaration of function 'perf_kprobe_missed'; did you mean 'perf_release'? [-Werror=implicit-function-declaration]
lost += perf_kprobe_missed(event);
^~~~~~~~~~~~~~~~~~
perf_release
cc1: some warnings being treated as errors
vim +4753 kernel/events/core.c
4739
4740 static struct pmu perf_kprobe;
4741 static u64 perf_event_lost(struct perf_event *event)
4742 {
4743 struct ring_buffer *rb;
4744 u64 lost = 0;
4745
4746 rcu_read_lock();
4747 rb = rcu_dereference(event->rb);
4748 if (likely(!!rb))
4749 lost += local_read(&rb->lost);
4750 rcu_read_unlock();
4751
4752 if (event->attr.type == perf_kprobe.type)
> 4753 lost += perf_kprobe_missed(event);
4754
4755 return lost;
4756 }
4757
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 7185 bytes --]
next prev parent reply other threads:[~2019-09-17 14:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-17 13:30 [PATCH bpf-next 0/5] Add PERF_FORMAT_LOST read_format Daniel Xu
2019-09-17 13:30 ` [PATCH bpf-next 1/5] perf/core: " Daniel Xu
2019-09-17 14:32 ` kbuild test robot [this message]
2019-09-17 15:22 ` kbuild test robot
2019-09-24 8:33 ` Jiri Olsa
2019-09-27 21:28 ` Daniel Xu
2019-10-25 18:19 ` Daniel Xu
2019-10-28 9:12 ` Peter Zijlstra
2023-03-08 12:20 ` Lorenz Bauer
2019-09-17 13:30 ` [PATCH bpf-next 2/5] perf/core: Sync perf_event.h to tools Daniel Xu
2019-09-17 13:30 ` [PATCH bpf-next 3/5] libbpf: Add helpers to extract perf fd from bpf_link Daniel Xu
2019-09-17 13:30 ` [PATCH bpf-next 4/5] libbpf: Set read_format PERF_FORMAT_LOST on kprobe perf fds Daniel Xu
2019-09-17 13:30 ` [PATCH bpf-next 5/5] libbpf: Add selftest for PERF_FORMAT_LOST perf read_format Daniel Xu
2019-09-17 15:14 [PATCH bpf-next 1/5] perf/core: Add PERF_FORMAT_LOST read_format Daniel Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201909172200.sXLlokCN%lkp@intel.com \
--to=lkp@intel.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andriin@fb.com \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=dxu@dxuuu.xyz \
--cc=jolsa@redhat.com \
--cc=kbuild-all@01.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).