From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C0ADC3A5A6 for ; Thu, 19 Sep 2019 16:05:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D0C6220665 for ; Thu, 19 Sep 2019 16:05:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Aa3gf0rV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404074AbfISQF0 (ORCPT ); Thu, 19 Sep 2019 12:05:26 -0400 Received: from mail-lj1-f169.google.com ([209.85.208.169]:44262 "EHLO mail-lj1-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404079AbfISQFZ (ORCPT ); Thu, 19 Sep 2019 12:05:25 -0400 Received: by mail-lj1-f169.google.com with SMTP id m13so4110615ljj.11 for ; Thu, 19 Sep 2019 09:05:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=oWulYD7B080MVQfmnSpp87cWzUMLXTr6wp3qPP73Jlc=; b=Aa3gf0rVn+UXxcLOYGQp70TrEQPIIequrVJ9zMGiCp6udjxIQ8Kazoqh0wDrR1dL3N yqKZoRPPm7sZMHI8bNu37kRoDwIEEEUgxrySM8ACD7NkvswaYk7QwaH4ANDK6MjGFA2B lymG274elFcNkvhcm4UvZELFHgciyvp7B2JANal60jVrLsft5ciknrwg8idEJ7Qnzkgi XaBAcDXAC3wmCBjxZDMvr4RVewwrLrw85eBlc5UrIaRQBR6gfjHLemcDQZ20AYhVDHG3 YfKVexILIlZOhKWWVPl+fuzx2uAYBFDh3pp+tnXPPmTmFkFqgj9L+LyKvHo8b/yyvdMR jJaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=oWulYD7B080MVQfmnSpp87cWzUMLXTr6wp3qPP73Jlc=; b=auhW1B03I+ZgWOo5YARfmVqmzCx7S83eWEYyeAMMC4uBn7n/Q2pJNaIovgMyzSg5rU lawvcBDb5mJvecb4IjMY9XmQaRpPDrrTIZDkX2DfcHhWGY3PiIwy5iGORbDOJhyfWejN FcLju3p/BeEnX4f4nxXlS4l5MuUR4b8LUJN1SH+6ack0OL5yuqYgXZzZltPB8iW+WcOr bQi0sqJWNv9/wwW+kL+i/zpSVoeqvlAwCrujmZufCCoLcjn20D/WXjYvnHx8X7V1d45K CQ2kwcW6cZH3uiiNccqLou0XHXl+y8Qp7PNK3NnKuXWV9OizEg0QojDi6QO3h1smvEzd KTKg== X-Gm-Message-State: APjAAAVUsL3p4kSKMcwX/9v7tAtgDNxQ9x0o95dwEC1RBZFJ6s/E+txQ 8gJNmOdoeUGslBrbw6y2HeeR+w== X-Google-Smtp-Source: APXvYqz/YDgxnx5B4g6INq61NG3EDGiHS7/lv1YfTLwHNxtOzep+r5dUzDw8bxPOTGNKDifK1CzjYg== X-Received: by 2002:a05:651c:21b:: with SMTP id y27mr2636904ljn.219.1568909122191; Thu, 19 Sep 2019 09:05:22 -0700 (PDT) Received: from localhost.localdomain (168-200-94-178.pool.ukrtel.net. [178.94.200.168]) by smtp.gmail.com with ESMTPSA id t6sm1719039ljd.102.2019.09.19.09.05.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Sep 2019 09:05:21 -0700 (PDT) From: Ivan Khoronzhuk To: ast@kernel.org, daniel@iogearbox.net, kafai@fb.com, andriin@fb.com Cc: yhs@fb.com, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, Ivan Khoronzhuk Subject: [PATCH bpf] libbpf: fix version identification on busybox Date: Thu, 19 Sep 2019 19:05:18 +0300 Message-Id: <20190919160518.25901-1-ivan.khoronzhuk@linaro.org> X-Mailer: git-send-email 2.17.1 Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org It's very often for embedded to have stripped version of sort in busybox, when no -V option present. It breaks build natively on target board causing recursive loop. BusyBox v1.24.1 (2019-04-06 04:09:16 UTC) multi-call binary. \ Usage: sort [-nrugMcszbdfimSTokt] [-o FILE] [-k \ start[.offset][opts][,end[.offset][opts]] [-t CHAR] [FILE]... Lets modify command a little to avoid -V option. Fixes: dadb81d0afe732 ("libbpf: make libbpf.map source of truth for libbpf version") Signed-off-by: Ivan Khoronzhuk --- Based on bpf/master tools/lib/bpf/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/lib/bpf/Makefile b/tools/lib/bpf/Makefile index c6f94cffe06e..a12490ad6215 100644 --- a/tools/lib/bpf/Makefile +++ b/tools/lib/bpf/Makefile @@ -3,7 +3,7 @@ LIBBPF_VERSION := $(shell \ grep -oE '^LIBBPF_([0-9.]+)' libbpf.map | \ - sort -rV | head -n1 | cut -d'_' -f2) + cut -d'_' -f2 | sort -r | head -n1) LIBBPF_MAJOR_VERSION := $(firstword $(subst ., ,$(LIBBPF_VERSION))) MAKEFLAGS += --no-print-directory -- 2.17.1