From: kbuild test robot <lkp@intel.com>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>
Cc: kbuild-all@01.org, Daniel Borkmann <daniel@iogearbox.net>,
Alexei Starovoitov <ast@kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>,
Marek Majkowski <marek@cloudflare.com>,
Lorenz Bauer <lmb@cloudflare.com>,
Alan Maguire <alan.maguire@oracle.com>,
Jesper Dangaard Brouer <brouer@redhat.com>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next v2 1/5] bpf: Support injecting chain calls into BPF programs on load
Date: Sat, 5 Oct 2019 04:51:16 +0800 [thread overview]
Message-ID: <201910050413.cga9NhOg%lkp@intel.com> (raw)
In-Reply-To: <157020976144.1824887.10249946730258092768.stgit@alrua-x1>
[-- Attachment #1: Type: text/plain, Size: 1665 bytes --]
Hi "Toke,
I love your patch! Yet something to improve:
[auto build test ERROR on bpf-next/master]
url: https://github.com/0day-ci/linux/commits/Toke-H-iland-J-rgensen/bpf-Support-injecting-chain-calls-into-BPF-programs-on-load/20191005-035650
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: i386-defconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-13) 7.4.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
kernel/bpf/core.c: In function '__bpf_prog_free':
>> kernel/bpf/core.c:266:4: error: implicit declaration of function 'bpf_map_area_free'; did you mean 'bpf_prog_free'? [-Werror=implicit-function-declaration]
bpf_map_area_free(array);
^~~~~~~~~~~~~~~~~
bpf_prog_free
cc1: some warnings being treated as errors
vim +266 kernel/bpf/core.c
253
254 void __bpf_prog_free(struct bpf_prog *fp)
255 {
256 if (fp->aux) {
257 free_percpu(fp->aux->stats);
258 if (fp->aux->chain_progs) {
259 struct bpf_array *array = fp->aux->chain_progs;
260 int i;
261
262 for (i = 0; i < BPF_NUM_CHAIN_SLOTS; i++)
263 if (array->ptrs[i])
264 bpf_prog_put(array->ptrs[i]);
265
> 266 bpf_map_area_free(array);
267 }
268 kfree(fp->aux);
269 }
270 vfree(fp);
271 }
272
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28158 bytes --]
next prev parent reply other threads:[~2019-10-04 20:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 17:22 [PATCH bpf-next v2 0/5] xdp: Support multiple programs on a single interface through chain calls Toke Høiland-Jørgensen
2019-10-04 17:22 ` [PATCH bpf-next v2 1/5] bpf: Support injecting chain calls into BPF programs on load Toke Høiland-Jørgensen
2019-10-04 20:51 ` kbuild test robot [this message]
2019-10-04 21:12 ` kbuild test robot
2019-10-04 23:17 ` Jakub Kicinski
2019-10-05 10:29 ` Toke Høiland-Jørgensen
2019-10-06 3:39 ` Jakub Kicinski
2019-10-06 15:52 ` Toke Høiland-Jørgensen
2019-10-05 10:32 ` Toke Høiland-Jørgensen
2019-10-07 0:27 ` Alexei Starovoitov
2019-10-07 10:11 ` Toke Høiland-Jørgensen
2019-10-07 20:22 ` Daniel Borkmann
2019-10-08 9:00 ` Toke Høiland-Jørgensen
2019-10-07 20:45 ` Alexei Starovoitov
2019-10-08 9:02 ` Toke Høiland-Jørgensen
2019-10-04 17:22 ` [PATCH bpf-next v2 2/5] bpf: Add support for setting chain call sequence for programs Toke Høiland-Jørgensen
2019-10-04 23:18 ` Jakub Kicinski
2019-10-05 10:30 ` Toke Høiland-Jørgensen
2019-10-04 17:22 ` [PATCH bpf-next v2 3/5] tools: Update bpf.h header for program chain calls Toke Høiland-Jørgensen
2019-10-04 17:22 ` [PATCH bpf-next v2 4/5] libbpf: Add syscall wrappers for BPF_PROG_CHAIN_* commands Toke Høiland-Jørgensen
2019-10-04 17:22 ` [PATCH bpf-next v2 5/5] selftests: Add tests for XDP chain calls Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201910050413.cga9NhOg%lkp@intel.com \
--to=lkp@intel.com \
--cc=alan.maguire@oracle.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=kafai@fb.com \
--cc=kbuild-all@01.org \
--cc=lmb@cloudflare.com \
--cc=marek@cloudflare.com \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=toke@redhat.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).