From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B1E5C47404 for ; Tue, 8 Oct 2019 02:23:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1A2F3206BB for ; Tue, 8 Oct 2019 02:23:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="mH+C7BS4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729699AbfJHCXk (ORCPT ); Mon, 7 Oct 2019 22:23:40 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:46883 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729472AbfJHCXk (ORCPT ); Mon, 7 Oct 2019 22:23:40 -0400 Received: by mail-pf1-f193.google.com with SMTP id q5so9828909pfg.13 for ; Mon, 07 Oct 2019 19:23:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=+SSvTX+QixrK9T0VspY303Q2XI9nw32esh6WHH9QsbY=; b=mH+C7BS4j+h83TR/36+HsnUASf8nQZLKzV9t8bANu+lz3unOLrDXms8wbfNmiaUeC6 XpiqxUfHipZs1eg6Jzdlp/Mk8kPW1dV0IWi+YYaf6rZsg4/PGFtghYSKCNPnlqqQvNnc NaC8cMx8yw0kjjLKCZ3b9z7JmciNclbtgDnWLbnwhemDUqOUOBF58C3HSbbRyRn9MMdR ADkD2zt5wa4Av29lRQO+3Q4oYjseK2gcygUGCHP1QJ8Du8unn44fERwn4wv082cVTFjN 65QmvtqDrsNVE0qnl6lnC3s5yUmy8a9qF0/3TMsTlz4CqcsII+sY9fAsNXvfpgxn5CZu hhNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=+SSvTX+QixrK9T0VspY303Q2XI9nw32esh6WHH9QsbY=; b=VWQ5mOdrk+7gmj/n6uhyMynHNSIhqvh1Nmd/cDvz56UH94KHyGqz4ZneHmM7UmYY3F /8ayf36Kd5gUaVTLbjMjHMuqW6k2W2URZAkayWqZqslHERaWnzwfy0dF9S10dhFRmRur oggxMT0Jx3ILVZ2WuwP76C8DG/z6BKXHjIjbDrnPKTDAL4OiwF1oycqk6QJdjyTTnz88 qmOyZKBIhhz2bAbKWwW/uw/3a3AE9Q/v+kyOutwgVXTimN6r2dXlHndeC2xcPp+XfAYP bwX+CpqayEiGQWWe67qe9ek4+8r0WDi6AmzVaSLldHyGlB1lJLMluNRckPWW+FqwIcbs ySBQ== X-Gm-Message-State: APjAAAW4E3hwdxZCHSSIATN5BOPlZLriEqTlV24xDdGrjLDc8XqFKKn8 g6q1ZySrtgYMEbOTPwqHHZlf6A== X-Google-Smtp-Source: APXvYqxZmmyeqztLzWaYDLbZRLY9AIp2zymckuGJgUrFrsa+dGmrJSn6jUleJhbh7Q+PsjFa3GdeBw== X-Received: by 2002:a05:6a00:8c:: with SMTP id c12mr35295871pfj.200.1570501418511; Mon, 07 Oct 2019 19:23:38 -0700 (PDT) Received: from cakuba.netronome.com (c-73-202-202-92.hsd1.ca.comcast.net. [73.202.202.92]) by smtp.gmail.com with ESMTPSA id i190sm8368842pgc.93.2019.10.07.19.23.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Oct 2019 19:23:38 -0700 (PDT) Date: Mon, 7 Oct 2019 19:23:28 -0700 From: Jakub Kicinski To: Alexei Starovoitov Cc: Andrii Nakryiko , bpf , Network Development , Alexei Starovoitov , Daniel Borkmann , Stanislav Fomichev , Andrii Nakryiko , Kernel Team Subject: Re: [PATCH v2 bpf-next] bpftool: fix bpftool build by switching to bpf_object__open_file() Message-ID: <20191007192328.2d89f63e@cakuba.netronome.com> In-Reply-To: References: <20191007225604.2006146-1-andriin@fb.com> <20191007185932.24d00391@cakuba.netronome.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Mon, 7 Oct 2019 19:16:45 -0700, Alexei Starovoitov wrote: > On Mon, Oct 7, 2019 at 7:00 PM Jakub Kicinski wrote: > > On Mon, 7 Oct 2019 15:56:04 -0700, Andrii Nakryiko wrote: > > > diff --git a/tools/bpf/bpftool/prog.c b/tools/bpf/bpftool/prog.c > > > index 43fdbbfe41bb..27da96a797ab 100644 > > > --- a/tools/bpf/bpftool/prog.c > > > +++ b/tools/bpf/bpftool/prog.c > > > @@ -1092,9 +1092,7 @@ static int do_run(int argc, char **argv) > > > static int load_with_options(int argc, char **argv, bool first_prog_only) > > > { > > > struct bpf_object_load_attr load_attr = { 0 }; > > > - struct bpf_object_open_attr open_attr = { > > > - .prog_type = BPF_PROG_TYPE_UNSPEC, > > > - }; > > > + enum bpf_prog_type common_prog_type = BPF_PROG_TYPE_UNSPEC; > > > enum bpf_attach_type expected_attach_type; > > > struct map_replace *map_replace = NULL; > > > struct bpf_program *prog = NULL, *pos; > > > > Please maintain reverse xmas tree.. > > There are exceptions. I don't think it's worth doing everywhere. Rule #0 stick to the existing code style. "Previous line of code declaring this variable in a different way was in this place" is a really weak argument and the only one which can be made here...