From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E94E6C47404 for ; Tue, 8 Oct 2019 02:50:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BB7DD206C0 for ; Tue, 8 Oct 2019 02:50:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="mA3bNLh9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729815AbfJHCuN (ORCPT ); Mon, 7 Oct 2019 22:50:13 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:34222 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729627AbfJHCuN (ORCPT ); Mon, 7 Oct 2019 22:50:13 -0400 Received: by mail-pf1-f194.google.com with SMTP id b128so9932321pfa.1 for ; Mon, 07 Oct 2019 19:50:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=SnvVQ/EzvqOCzbAnO9hVrTvDIptEI4+VavfPumW1v9U=; b=mA3bNLh9xeJTxheDBXnxHp8LysvFis+b/BMv1BbfmL1faamZOzTGrWr0EDS8UkA9AG Qevo/es4qy9/cl96z0pRPOCVyBk7IyoBiMec5eiMQLlABSo4eu2P+yf3YKGLQx9Gl8kc rG3nHk0Z52n5mIV2hn0+c4Pi1vcu5XATAHmoJLVIvDp3TzGi3lrnnz8TJiuH9z63Hnng D+2S/ZtUe5Ft1mxw4jqLj975j5l/wBCHmzxX7hiXE4TiZYfRtohmRJIUIUyjoCO7xHhl gAfHc0Aej1IiDAeDYTde6hBQXTs3nXnUF4kQAtGbujj0loxJ90CetSf+VyE2GbKVXSFI WTXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=SnvVQ/EzvqOCzbAnO9hVrTvDIptEI4+VavfPumW1v9U=; b=EVTeaV7lArYHhD75lK+xR/DOiGmqvzHljitTzgxxjr4NkywND8T9+MLD8/Jtd61qOu fPqIQK1JIiQILTh8AuUv13Qq4kO2WlkvSJm3pZwVD1OUuERJXHY2OecjJdVQNrWLXUpZ yTaGSiUuLhvhQ6EDbY6qu4FvAaPPGmVUDWFcmi6Xl0JbgZ1x/ti0ZDyblQ+HGIEepad5 2vU5/8J4WeF3SOl+cUnXZQKQzAaAI8YBnW2sYn1uCXMkgNih2jue8O8X3OKKkk0iIy4D q5/YTu2wZRsHjhokjAwDd44DpYrYVd44LOJlfT7YKsO8fWMdPNCQHv+W4IBMxbY4m05R jvbw== X-Gm-Message-State: APjAAAUGAUH4obIOVkDc4+r8jsqCkbB4ab4x5MKcwUWT35z/3+5FzbVQ q2hbdUsom+g/c6LHv2uDYi7Y7w== X-Google-Smtp-Source: APXvYqwvBB9deBauQloqA9P1Cs/C0DVWNaziW70egUTa97uoHeiIbeUN2t7ujVtigVXLllR6cBz26w== X-Received: by 2002:aa7:8b49:: with SMTP id i9mr37199326pfd.255.1570503012500; Mon, 07 Oct 2019 19:50:12 -0700 (PDT) Received: from cakuba.netronome.com (c-73-202-202-92.hsd1.ca.comcast.net. [73.202.202.92]) by smtp.gmail.com with ESMTPSA id y8sm16245460pgr.28.2019.10.07.19.50.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Oct 2019 19:50:12 -0700 (PDT) Date: Mon, 7 Oct 2019 19:50:01 -0700 From: Jakub Kicinski To: Alexei Starovoitov Cc: Andrii Nakryiko , bpf , Network Development , Alexei Starovoitov , Daniel Borkmann , Stanislav Fomichev , Andrii Nakryiko , Kernel Team Subject: Re: [PATCH v2 bpf-next] bpftool: fix bpftool build by switching to bpf_object__open_file() Message-ID: <20191007195001.4cb47f99@cakuba.netronome.com> In-Reply-To: References: <20191007225604.2006146-1-andriin@fb.com> <20191007185932.24d00391@cakuba.netronome.com> <20191007192328.2d89f63e@cakuba.netronome.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Mon, 7 Oct 2019 19:38:15 -0700, Alexei Starovoitov wrote: > On Mon, Oct 7, 2019 at 7:23 PM Jakub Kicinski wrote: > > On Mon, 7 Oct 2019 19:16:45 -0700, Alexei Starovoitov wrote: > > > On Mon, Oct 7, 2019 at 7:00 PM Jakub Kicinski wrote: > > > > On Mon, 7 Oct 2019 15:56:04 -0700, Andrii Nakryiko wrote: > > > > > diff --git a/tools/bpf/bpftool/prog.c b/tools/bpf/bpftool/prog.c > > > > > index 43fdbbfe41bb..27da96a797ab 100644 > > > > > --- a/tools/bpf/bpftool/prog.c > > > > > +++ b/tools/bpf/bpftool/prog.c > > > > > @@ -1092,9 +1092,7 @@ static int do_run(int argc, char **argv) > > > > > static int load_with_options(int argc, char **argv, bool first_prog_only) > > > > > { > > > > > struct bpf_object_load_attr load_attr = { 0 }; > > > > > - struct bpf_object_open_attr open_attr = { > > > > > - .prog_type = BPF_PROG_TYPE_UNSPEC, > > > > > - }; > > > > > + enum bpf_prog_type common_prog_type = BPF_PROG_TYPE_UNSPEC; > > > > > enum bpf_attach_type expected_attach_type; > > > > > struct map_replace *map_replace = NULL; > > > > > struct bpf_program *prog = NULL, *pos; > > > > > > > > Please maintain reverse xmas tree.. > > > > > > There are exceptions. I don't think it's worth doing everywhere. > > > > Rule #0 stick to the existing code style. > > > > "Previous line of code declaring this variable in a different way was > > in this place" is a really weak argument and the only one which can be > > made here... > > do you seriously think that arguing about xmas tree is a good > spend of yours and my time?! Hahaha I really don't, I was about to say. I'm just registering my disgruntlement :) I can't stay silent when I see hasty submissions that make the code of which I'm the original author deteriorate. I hope that's understandable.