From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA6A7C4360C for ; Tue, 8 Oct 2019 19:13:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8E16521835 for ; Tue, 8 Oct 2019 19:13:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="LOXRHIcZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729658AbfJHTNV (ORCPT ); Tue, 8 Oct 2019 15:13:21 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:35925 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727220AbfJHTNU (ORCPT ); Tue, 8 Oct 2019 15:13:20 -0400 Received: by mail-qt1-f194.google.com with SMTP id o12so26938814qtf.3 for ; Tue, 08 Oct 2019 12:13:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=B9rf+VBuWjx1PPlnlyQtG5L/QPp7gUPZolyg4GuyibI=; b=LOXRHIcZeA6ePEYLSqol3MkRA+IsiTAYOlNbx58hWKKoEQD9iUJEttMhPRV+DkYrJk 8fNZOXJxUvymRqrDYBLAcZbRqKDzhPncxFmN29JojvA/J7CKicUtq8537UO3cgclRY+7 XYZfdLow19wUcwG1UarnuVql5wgbRYO9i5uie8nERCIJ7gsXrfHe/fmQHyCgrCy0Kha2 yu3GCGW7hn81vC8O7h/hyLo17hevn6ehYVjhqi2Lk1FfMSTjX8OMw1D+Gc64RNuIMnm1 AaZW9UqaFoah6rkyRNMS1x7tt720Z5ImScaUBTCKvS9TShc88MvcmcnQ1tq9U3GWLkxw UPAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=B9rf+VBuWjx1PPlnlyQtG5L/QPp7gUPZolyg4GuyibI=; b=stUtJKPXQyIWpWUy4Afe3yo3qbUOWXVtizsNnbv3cbagFNwd/2dduRc6QHx1Xsu/Hw XaAonlEiD5XJlr6No9tbBpzdHVklYq9iqa3LXcvxPGKu4967rYGssDEpnOZYeaj7hT7a RDuDHbCYYG90Rg0cMp7BFpyeD3gqPlh6mkydQifx4zJEDgk8uIkceisEDa/zAevT4+II 6bEVs4gRd7efNjMqy98yksMxkxWdkelo4zfmhkSNITRK1nCYTun9WlijhdVdG0TGR08z r6V59KHsyRRB9oHi8tfTRhI9OkFoM+OFsBc3OX4sHIO20elAwYqV+J6CN0ddCw6upOjk jwqQ== X-Gm-Message-State: APjAAAU1ZkANYHTFqwzVaSxRdWs989hKd/XjzZUKMJRRmRdklvG5BUBZ aJo1+aeY1x5wR0vhxg67NQ14Kw== X-Google-Smtp-Source: APXvYqxZYBoQmp2JX9+sjZaGwUNjG/XJ53dm/PlE8/teJVUjUIwQMnfn776A15fICR/1WALAiztJwQ== X-Received: by 2002:a05:6214:2e4:: with SMTP id h4mr35227322qvu.127.1570561999863; Tue, 08 Oct 2019 12:13:19 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id z46sm12187717qth.62.2019.10.08.12.13.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Oct 2019 12:13:19 -0700 (PDT) Date: Tue, 8 Oct 2019 12:13:08 -0700 From: Jakub Kicinski To: Colin King Cc: "David S . Miller" , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , netdev@vger.kernel.org, bpf@vger.kernel.org, oss-drivers@netronome.com, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] nfp: bpf: make array exp_mask static, makes object smaller Message-ID: <20191008121308.121c2748@cakuba.netronome.com> In-Reply-To: <20191007115239.1742-1-colin.king@canonical.com> References: <20191007115239.1742-1-colin.king@canonical.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Mon, 7 Oct 2019 12:52:39 +0100, Colin King wrote: > From: Colin Ian King > > Don't populate the array exp_mask on the stack but instead make it > static. Makes the object code smaller by 224 bytes. > > Before: > text data bss dec hex filename > 77832 2290 0 80122 138fa ethernet/netronome/nfp/bpf/jit.o > > After: > text data bss dec hex filename > 77544 2354 0 79898 1381a ethernet/netronome/nfp/bpf/jit.o > > (gcc version 9.2.1, amd64) > > Signed-off-by: Colin Ian King Applied to net-next, thanks.