From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE298ECE58C for ; Wed, 9 Oct 2019 16:54:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9004721848 for ; Wed, 9 Oct 2019 16:54:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="tyktbH9E" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731426AbfJIQyO (ORCPT ); Wed, 9 Oct 2019 12:54:14 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:37363 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730490AbfJIQyO (ORCPT ); Wed, 9 Oct 2019 12:54:14 -0400 Received: by mail-pg1-f196.google.com with SMTP id p1so1783226pgi.4 for ; Wed, 09 Oct 2019 09:54:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=FWquouYqKBd7amD18urRls6Y6gtLx6j4gbRFX8vfpcA=; b=tyktbH9E1xZYVxbf2IRLPSbtOnJAiG0rW/0c5WCWbuy8c4r8FPIL0X55nHn53qkQpd N/0S+JB9m39QziSsYYKCAt0JSnU9ZCny5eS0E0tEEUUs5p8ASxnapxafcxo3iwTuogAO lewh/W1lUFpKc43PnicB0nJs4hSDJF/47m+ONJ6pGRydxBwaILK1HUmGWqgLQiHKgsBN Sgmga5tkGNm+JYjXzDP+5PJotOy0P/8CgN/GOFbUsnDIGrUh0gZwDhpwaL3n7/OoLspN TPJD813EHaDL77sT6jHyKq86NZHc+V0V+lIM86k95Rpb9eCTfmAlm3U2rC/cuQYVmwV3 kUcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=FWquouYqKBd7amD18urRls6Y6gtLx6j4gbRFX8vfpcA=; b=kppSItKzmP3ZzjiyJtemPhz+3B2oNUM4BVlxMWZHjx2kCVJeSxJMKnF7Ht0BGNXMz9 aDC+pygSfJEHXj6hdbfNESTnPFucHdHPkpstMtmYE25VaB8Sr+vh51Ws5H8FpAh7200V 01YzIZtrIGI8X6GqwMxZDvFVf3PrvARczIOBHbRsWT/aIl3fkQYIJ+SN4JbymTl5IxfN FzyqkRqUg7Eqb4ZNtYCUJDhJf8PGycNmRIWliOAIUj6dVpXQFs2FABIRNLcWlYVw9RrA qsYnCh9f+JQa4mVkAHj9LiAQeOkJckv+Q1lfWRCrrj2dUZ7sxAXnoU4Hg3UQDfMkgj4e 5sUA== X-Gm-Message-State: APjAAAX6sOJ6rZlyyFhvpVG6GA9uiAdsAIpVPUo9Ppy7PN6Mq5iTiIPj duxN4o/l6wIPycSDlBCHSzYooAtwoIc= X-Google-Smtp-Source: APXvYqz33xg6mGHwZzY2rBVPIF3+9OEjT1Iym8OqIXZgdg5lCtvXcB+wk3KGe6fY9b73P2JfvTAQ4g== X-Received: by 2002:a17:90a:9e2:: with SMTP id 89mr5312445pjo.67.1570640051867; Wed, 09 Oct 2019 09:54:11 -0700 (PDT) Received: from cakuba.netronome.com (c-73-202-202-92.hsd1.ca.comcast.net. [73.202.202.92]) by smtp.gmail.com with ESMTPSA id r18sm4172935pfc.3.2019.10.09.09.54.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Oct 2019 09:54:11 -0700 (PDT) Date: Wed, 9 Oct 2019 09:53:58 -0700 From: Jakub Kicinski To: "Samudrala, Sridhar" Cc: magnus.karlsson@intel.com, bjorn.topel@intel.com, netdev@vger.kernel.org, bpf@vger.kernel.org, intel-wired-lan@lists.osuosl.org, maciej.fijalkowski@intel.com, tom.herbert@intel.com Subject: Re: [PATCH bpf-next 0/4] Enable direct receive on AF_XDP sockets Message-ID: <20191009095358.34cddd95@cakuba.netronome.com> In-Reply-To: References: <1570515415-45593-1-git-send-email-sridhar.samudrala@intel.com> <20191008174919.2160737a@cakuba.netronome.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Tue, 8 Oct 2019 23:29:59 -0700, Samudrala, Sridhar wrote: > On 10/8/2019 5:49 PM, Jakub Kicinski wrote: > > I asked you to add numbers for handling those use cases in the kernel > > directly. > > Forgot to explicitly mention that I didn't see any regressions with > xdp1, xdp2 or xdpsock in default mode with these patches. Performance > remained the same. I'm not looking for regressions. The in-kernel path is faster, and should be used for speeding things up rather than a "direct path to user space". Your comparison should have 3 numbers - current AF_XDP, patched AF_XDP, in-kernel handling.