From: Peter Zijlstra <peterz@infradead.org>
To: Song Liu <songliubraving@fb.com>
Cc: linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
netdev@vger.kernel.org, kernel-team@fb.com,
stable@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>
Subject: Re: [PATCH bpf-next 2/2] bpf/stackmap: fix A-A deadlock in bpf_get_stack()
Date: Thu, 10 Oct 2019 09:36:08 +0200 [thread overview]
Message-ID: <20191010073608.GO2311@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20191010061916.198761-3-songliubraving@fb.com>
On Wed, Oct 09, 2019 at 11:19:16PM -0700, Song Liu wrote:
> bpf stackmap with build-id lookup (BPF_F_STACK_BUILD_ID) can trigger A-A
> deadlock on rq_lock():
>
> rcu: INFO: rcu_sched detected stalls on CPUs/tasks:
> [...]
> Call Trace:
> try_to_wake_up+0x1ad/0x590
> wake_up_q+0x54/0x80
> rwsem_wake+0x8a/0xb0
> bpf_get_stack+0x13c/0x150
> bpf_prog_fbdaf42eded9fe46_on_event+0x5e3/0x1000
> bpf_overflow_handler+0x60/0x100
> __perf_event_overflow+0x4f/0xf0
> perf_swevent_overflow+0x99/0xc0
> ___perf_sw_event+0xe7/0x120
> __schedule+0x47d/0x620
> schedule+0x29/0x90
> futex_wait_queue_me+0xb9/0x110
> futex_wait+0x139/0x230
> do_futex+0x2ac/0xa50
> __x64_sys_futex+0x13c/0x180
> do_syscall_64+0x42/0x100
> entry_SYSCALL_64_after_hwframe+0x44/0xa9
>
> diff --git a/kernel/bpf/stackmap.c b/kernel/bpf/stackmap.c
> index 052580c33d26..3b278f6b0c3e 100644
> --- a/kernel/bpf/stackmap.c
> +++ b/kernel/bpf/stackmap.c
> @@ -287,7 +287,7 @@ static void stack_map_get_build_id_offset(struct bpf_stack_build_id *id_offs,
> bool irq_work_busy = false;
> struct stack_map_irq_work *work = NULL;
>
> - if (in_nmi()) {
> + if (in_nmi() || this_rq_is_locked()) {
> work = this_cpu_ptr(&up_read_work);
> if (work->irq_work.flags & IRQ_WORK_BUSY)
> /* cannot queue more up_read, fallback */
This is horrific crap. Just say no to that get_build_id_offset()
trainwreck.
next prev parent reply other threads:[~2019-10-10 7:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 6:19 [PATCH bpf-next 0/2] bpf/stackmap: fix A-A deadlock in bpf_get_stack() Song Liu
2019-10-10 6:19 ` [PATCH bpf-next 1/2] sched: introduce this_rq_is_locked() Song Liu
2019-10-10 6:19 ` [PATCH bpf-next 2/2] bpf/stackmap: fix A-A deadlock in bpf_get_stack() Song Liu
2019-10-10 7:36 ` Peter Zijlstra [this message]
2019-10-10 17:19 ` Alexei Starovoitov
2019-10-10 17:46 ` Peter Zijlstra
2019-10-10 18:06 ` Alexei Starovoitov
2019-10-14 9:09 ` Peter Zijlstra
2019-10-14 20:12 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191010073608.GO2311@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).