From: Daniel Borkmann <daniel@iogearbox.net>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Martin Lau <kafai@fb.com>, Andrii Nakryiko <andriin@fb.com>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Alexei Starovoitov <ast@fb.com>, Kernel Team <Kernel-team@fb.com>
Subject: Re: [Potential Spoof] [PATCH bpf-next 2/2] selftests/bpf: remove obsolete pahole/BTF support detection
Date: Fri, 11 Oct 2019 23:17:58 +0200 [thread overview]
Message-ID: <20191011211758.GA12673@pc-63.home> (raw)
In-Reply-To: <CAEf4BzZmWLQRxW_gnJEbxZPp6K_RPGXn-MYKetVD0P-yCHwTtw@mail.gmail.com>
On Fri, Oct 11, 2019 at 10:28:39AM -0700, Andrii Nakryiko wrote:
> On Fri, Oct 11, 2019 at 9:21 AM Martin Lau <kafai@fb.com> wrote:
> > On Thu, Oct 10, 2019 at 08:13:18PM -0700, Andrii Nakryiko wrote:
> > > Given lots of selftests won't work without recent enough Clang/LLVM that
> > > fully supports BTF, there is no point in maintaining outdated BTF
> > > support detection and fall-back to pahole logic. Just assume we have
> > > everything we need.
> > May be an error message to tell which llvm is needed?
>
> Not sure where we'd want this to be checked/printed. We don't do this
> today, so what I'm doing here is not really a regression.
> There is no single llvm version I'd want to pin down. For most tests
> LLVM w/ basic BTF support would be enough, for CO-RE stuff we need the
> latest Clang 10 (not yet released officially), though. So essentially
> the stance right now is that you need latest Clang built from sources
> to have all the tests compiled and I don't think it's easy to check
> for that.
At some point once bpf-gcc gets more mature, we might need something
more elaborate than just telling everyone to use latest clang/llvm
from git, but so far that's our convention we have in place today.
> > $(CPU) and $(PROBE) are no longer needed also?
>
> Good catch, removing them as well.
Ok, expecting v2 then.
Thanks,
Daniel
prev parent reply other threads:[~2019-10-11 21:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 3:13 [PATCH bpf-next 0/2] selftests/bpf Makefile cleanup and fixes Andrii Nakryiko
2019-10-11 3:13 ` [PATCH bpf-next 1/2] selftests/bpf: enforce libbpf build before BPF programs are built Andrii Nakryiko
2019-10-11 20:22 ` Martin Lau
2019-10-11 3:13 ` [PATCH bpf-next 2/2] selftests/bpf: remove obsolete pahole/BTF support detection Andrii Nakryiko
2019-10-11 16:21 ` [Potential Spoof] " Martin Lau
2019-10-11 17:28 ` Andrii Nakryiko
2019-10-11 21:17 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191011211758.GA12673@pc-63.home \
--to=daniel@iogearbox.net \
--cc=Kernel-team@fb.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=kafai@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).