From: Petr Mladek <pmladek@suse.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>,
linux-kernel@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>,
bpf@vger.kernel.org, Andrii Nakryiko <andriin@fb.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: [PATCH v2 31/33] tools lib bpf: Renaming pr_warning to pr_warn
Date: Fri, 18 Oct 2019 09:04:57 +0200 [thread overview]
Message-ID: <20191018070457.ge3wcpdle6pwtsxd@pathway.suse.cz> (raw)
In-Reply-To: <20191018042416.r4fffxzbxb3u4csg@ast-mbp>
On Thu 2019-10-17 21:24:19, Alexei Starovoitov wrote:
> On Fri, Oct 18, 2019 at 11:18:48AM +0800, Kefeng Wang wrote:
> > For kernel logging macro, pr_warning is completely removed and
> > replaced by pr_warn, using pr_warn in tools lib bpf for symmetry
> > to kernel logging macro, then we could drop pr_warning in the
> > whole linux code.
> >
> > Cc: Alexei Starovoitov <ast@kernel.org>
> > Cc: Daniel Borkmann <daniel@iogearbox.net>
> > Cc: Martin KaFai Lau <kafai@fb.com>
> > Cc: Song Liu <songliubraving@fb.com>
> > Cc: Yonghong Song <yhs@fb.com>
> > Cc: bpf@vger.kernel.org
> > Acked-by: Andrii Nakryiko <andriin@fb.com>
> > Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> > Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> > ---
> > tools/lib/bpf/btf.c | 56 +--
> > tools/lib/bpf/btf_dump.c | 18 +-
> > tools/lib/bpf/libbpf.c | 679 ++++++++++++++++----------------
> > tools/lib/bpf/libbpf_internal.h | 8 +-
> > tools/lib/bpf/xsk.c | 4 +-
> > 5 files changed, 379 insertions(+), 386 deletions(-)
>
> Nack.
> I prefer this type of renaming to go via bpf tree.
> It's not a kernel patch. It's touching user space library
> which is under heavy development.
> Doing any other way will cause a ton of conflicts.
Fair enough. I'll ignore this patch. Could I assume that it will
be taken via bpf tree, please?
I'll also postpone the patch that removes pr_warning() to avoid
synchronization problems. I'll push it later when changes in
bpf[*] subsystem are merged.
[*] I am going to check conflicts against 5.4-rc1. I'll probably
ask more subsystems to take their changes to avoid conflicts
and make it smooth.
Best Regards,
Petr
next prev parent reply other threads:[~2019-10-18 7:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191018031710.41052-1-wangkefeng.wang@huawei.com>
[not found] ` <20191018031850.48498-1-wangkefeng.wang@huawei.com>
2019-10-18 3:18 ` [PATCH v2 31/33] tools lib bpf: Renaming pr_warning to pr_warn Kefeng Wang
2019-10-18 4:24 ` Alexei Starovoitov
2019-10-18 7:04 ` Petr Mladek [this message]
2019-10-18 18:52 ` Daniel Borkmann
2019-10-21 5:55 ` [bpf-next] " Kefeng Wang
2019-10-21 12:55 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191018070457.ge3wcpdle6pwtsxd@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kafai@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=songliubraving@fb.com \
--cc=wangkefeng.wang@huawei.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).