From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE293CA9EA9 for ; Fri, 18 Oct 2019 19:11:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BE1A12070B for ; Fri, 18 Oct 2019 19:11:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2502874AbfJRTLB (ORCPT ); Fri, 18 Oct 2019 15:11:01 -0400 Received: from www62.your-server.de ([213.133.104.62]:60092 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2502792AbfJRTLB (ORCPT ); Fri, 18 Oct 2019 15:11:01 -0400 Received: from 55.249.197.178.dynamic.dsl-lte-bonding.lssmb00p-msn.res.cust.swisscom.ch ([178.197.249.55] helo=localhost) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1iLXeM-0005sD-1a; Fri, 18 Oct 2019 21:10:58 +0200 Date: Fri, 18 Oct 2019 21:10:57 +0200 From: Daniel Borkmann To: YueHaibing Cc: rostedt@goodmis.org, mingo@redhat.com, ast@kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com, andriin@fb.com, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH bpf-next] bpf: Fix build error without CONFIG_NET Message-ID: <20191018191057.GG26267@pc-63.home> References: <20191018090344.26936-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191018090344.26936-1-yuehaibing@huawei.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.101.4/25606/Fri Oct 18 10:58:40 2019) Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Fri, Oct 18, 2019 at 05:03:44PM +0800, YueHaibing wrote: > If CONFIG_NET is n, building fails: > > kernel/trace/bpf_trace.o: In function `raw_tp_prog_func_proto': > bpf_trace.c:(.text+0x1a34): undefined reference to `bpf_skb_output_proto' > > Wrap it into a #ifdef to fix this. > > Reported-by: Hulk Robot > Fixes: a7658e1a4164 ("bpf: Check types of arguments passed into helpers") > Signed-off-by: YueHaibing Applied, thanks!