bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Borkmann <daniel@iogearbox.net>
To: John Fastabend <john.fastabend@gmail.com>
Cc: andriin@fb.com, ast@kernel.org, netdev@vger.kernel.org,
	bpf@vger.kernel.org
Subject: Re: [bpf-next PATCH] bpf: libbpf, add kernel version section parsing back
Date: Fri, 18 Oct 2019 21:11:27 +0200	[thread overview]
Message-ID: <20191018191127.GH26267@pc-63.home> (raw)
In-Reply-To: <157140968634.9073.6407090804163937103.stgit@john-XPS-13-9370>

On Fri, Oct 18, 2019 at 07:41:26AM -0700, John Fastabend wrote:
> With commit "libbpf: stop enforcing kern_version,..." we removed the
> kernel version section parsing in favor of querying for the kernel
> using uname() and populating the version using the result of the
> query. After this any version sections were simply ignored.
> 
> Unfortunately, the world of kernels is not so friendly. I've found some
> customized kernels where uname() does not match the in kernel version.
> To fix this so programs can load in this environment this patch adds
> back parsing the section and if it exists uses the user specified
> kernel version to override the uname() result. However, keep most the
> kernel uname() discovery bits so users are not required to insert the
> version except in these odd cases.
> 
> Fixes: 5e61f27070292 ("libbpf: stop enforcing kern_version, populate it for users")
> Signed-off-by: John Fastabend <john.fastabend@gmail.com>

Applied, thanks!

      parent reply	other threads:[~2019-10-18 19:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-18 14:41 John Fastabend
2019-10-18 16:51 ` Andrii Nakryiko
2019-10-19  1:33   ` Alexei Starovoitov
2019-10-19  4:41     ` John Fastabend
2019-10-18 19:11 ` Daniel Borkmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191018191127.GH26267@pc-63.home \
    --to=daniel@iogearbox.net \
    --cc=andriin@fb.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=john.fastabend@gmail.com \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [bpf-next PATCH] bpf: libbpf, add kernel version section parsing back' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).