bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Borkmann <daniel@iogearbox.net>
To: Andrii Nakryiko <andriin@fb.com>
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org, ast@fb.com,
	andrii.nakryiko@gmail.com, kernel-team@fb.com
Subject: Re: [PATCH bpf-next 0/7] Auto-guess program type on bpf_object__open
Date: Mon, 21 Oct 2019 14:55:57 +0200	[thread overview]
Message-ID: <20191021125557.GM26267@pc-63.home> (raw)
In-Reply-To: <20191021033902.3856966-1-andriin@fb.com>

On Sun, Oct 20, 2019 at 08:38:55PM -0700, Andrii Nakryiko wrote:
> This patch set's main goal is to teach bpf_object__open() (and its variants)
> to automatically derive BPF program type/expected attach type from section
> names, similarly to how bpf_prog_load() was doing it. This significantly
> improves user experience by eliminating yet another
> obvious-only-in-the-hindsight surprise, when using libbpf APIs.
> 
> There are a bunch of auxiliary clean-ups and improvements. E.g.,
> bpf_program__get_type() and bpf_program__get_expected_attach_type() are added
> for completeness and symmetry with corresponding setter APIs. Some clean up
> and fixes in selftests/bpf are done as well.
> 
> Andrii Nakryiko (7):
>   tools: sync if_link.h
>   libbpf: add bpf_program__get_{type, expected_attach_type) APIs
>   libbpf: add uprobe/uretprobe and tp/raw_tp section suffixes
>   libbpf: teach bpf_object__open to guess program types
>   selftests/bpf: make a copy of subtest name
>   selftests/bpf: make reference_tracking test use subtests
>   selftest/bpf: get rid of a bunch of explicit BPF program type setting

Looks good, applied, thanks!

      parent reply	other threads:[~2019-10-21 12:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-21  3:38 Andrii Nakryiko
2019-10-21  3:38 ` [PATCH bpf-next 1/7] tools: sync if_link.h Andrii Nakryiko
2019-10-21  3:38 ` [PATCH bpf-next 2/7] libbpf: add bpf_program__get_{type, expected_attach_type) APIs Andrii Nakryiko
2019-10-21  3:38 ` [PATCH bpf-next 3/7] libbpf: add uprobe/uretprobe and tp/raw_tp section suffixes Andrii Nakryiko
2019-10-21  3:38 ` [PATCH bpf-next 4/7] libbpf: teach bpf_object__open to guess program types Andrii Nakryiko
     [not found]   ` <20191023042444.GJ12647@shao2-debian>
2019-10-23  6:12     ` [libbpf] 651b775f02: kernel_selftests.bpf.test_section_names.fail Andrii Nakryiko
2019-10-21  3:39 ` [PATCH bpf-next 5/7] selftests/bpf: make a copy of subtest name Andrii Nakryiko
2019-10-21  3:39 ` [PATCH bpf-next 6/7] selftests/bpf: make reference_tracking test use subtests Andrii Nakryiko
2019-10-21  3:39 ` [PATCH bpf-next 7/7] selftest/bpf: get rid of a bunch of explicit BPF program type setting Andrii Nakryiko
2019-10-21 12:55 ` Daniel Borkmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191021125557.GM26267@pc-63.home \
    --to=daniel@iogearbox.net \
    --cc=andrii.nakryiko@gmail.com \
    --cc=andriin@fb.com \
    --cc=ast@fb.com \
    --cc=bpf@vger.kernel.org \
    --cc=kernel-team@fb.com \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [PATCH bpf-next 0/7] Auto-guess program type on bpf_object__open' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).