BPF Archive on lore.kernel.org
 help / color / Atom feed
From: "Daniel T. Lee" <danieltimlee@gmail.com>
To: "Daniel Borkmann" <daniel@iogearbox.net>,
	"Alexei Starovoitov" <ast@kernel.org>,
	"Björn Töpel" <bjorn.topel@intel.com>,
	"Andrii Nakryiko" <andriin@fb.com>
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org
Subject: [PATCH] samples: bpf: fix outdated README build command
Date: Sun, 10 Nov 2019 17:19:01 +0900
Message-ID: <20191110081901.20851-1-danieltimlee@gmail.com> (raw)

Currently, building the bpf samples under samples/bpf directory isn't
working. Running make from the directory 'samples/bpf' will just shows
following result without compiling any samples.

 $ make
 make -C ../../ /git/linux/samples/bpf/ BPF_SAMPLES_PATH=/git/linux/samples/bpf
 make[1]: Entering directory '/git/linux'
   CALL    scripts/checksyscalls.sh
   CALL    scripts/atomic/check-atomics.sh
   DESCEND  objtool
 make[1]: Leaving directory '/git/linux'

Due to commit 394053f4a4b3 ("kbuild: make single targets work more
correctly"), building samples/bpf without support of samples/Makefile
is unavailable. Instead, building the samples with 'make M=samples/bpf'
from the root source directory will solve this issue.[1]

This commit fixes the outdated README build command with samples/bpf.

[0]: https://patchwork.kernel.org/patch/11168393/

Signed-off-by: Daniel T. Lee <danieltimlee@gmail.com>
---
 samples/bpf/README.rst | 19 +++++++++----------
 1 file changed, 9 insertions(+), 10 deletions(-)

diff --git a/samples/bpf/README.rst b/samples/bpf/README.rst
index 5f27e4faca50..bfd2405705ed 100644
--- a/samples/bpf/README.rst
+++ b/samples/bpf/README.rst
@@ -32,12 +32,10 @@ Compiling
 For building the BPF samples, issue the below command from the kernel
 top level directory::
 
- make samples/bpf/
+ make M=samples/bpf
 
-Do notice the "/" slash after the directory name.
-
-It is also possible to call make from this directory.  This will just
-hide the the invocation of make as above with the appended "/".
+Due to samples/bpf cannot be built without support in the
+samples/Makefile, it is unavailable to call make from this directory.
 
 Manually compiling LLVM with 'bpf' support
 ------------------------------------------
@@ -63,14 +61,15 @@ Quick sniplet for manually compiling LLVM and clang
 It is also possible to point make to the newly compiled 'llc' or
 'clang' command via redefining LLC or CLANG on the make command line::
 
- make samples/bpf/ LLC=~/git/llvm/build/bin/llc CLANG=~/git/llvm/build/bin/clang
+ make M=samples/bpf LLC=~/git/llvm/build/bin/llc CLANG=~/git/llvm/build/bin/clang
 
 Cross compiling samples
 -----------------------
 In order to cross-compile, say for arm64 targets, export CROSS_COMPILE and ARCH
 environment variables before calling make. This will direct make to build
-samples for the cross target.
+samples for the cross target.::
+
+ export ARCH=arm64
+ export CROSS_COMPILE="aarch64-linux-gnu-"
+ make M=samples/bpf LLC=~/git/llvm/build/bin/llc CLANG=~/git/llvm/build/bin/clang
 
-export ARCH=arm64
-export CROSS_COMPILE="aarch64-linux-gnu-"
-make samples/bpf/ LLC=~/git/llvm/build/bin/llc CLANG=~/git/llvm/build/bin/clang
-- 
2.20.1


             reply index

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-10  8:19 Daniel T. Lee [this message]
2019-11-11  6:09 ` Andrii Nakryiko
2019-11-11  9:24   ` Toke Høiland-Jørgensen
2019-11-12 11:47     ` Daniel T. Lee
2019-11-12 11:45   ` Daniel T. Lee
2019-11-11 13:58 ` Daniel Borkmann
2019-11-12 11:48   ` Daniel T. Lee

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191110081901.20851-1-danieltimlee@gmail.com \
    --to=danieltimlee@gmail.com \
    --cc=andriin@fb.com \
    --cc=ast@kernel.org \
    --cc=bjorn.topel@intel.com \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

BPF Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/bpf/0 bpf/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 bpf bpf/ https://lore.kernel.org/bpf \
		bpf@vger.kernel.org
	public-inbox-index bpf

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.bpf


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git