BPF Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH bpf-next 1/2] selftests: bpf: test_lwt_ip_encap: add missing object file to TEST_FILES
@ 2019-11-10  9:26 Anders Roxell
  2019-11-10  9:26 ` [PATCH bpf-next 2/2] selftests: bpf: test_tc_edt: " Anders Roxell
  0 siblings, 1 reply; 5+ messages in thread
From: Anders Roxell @ 2019-11-10  9:26 UTC (permalink / raw)
  To: ast, daniel, davem
  Cc: netdev, bpf, linux-kselftest, linux-kernel, shuah,
	songliubraving, Anders Roxell

When installing kselftests to its own directory and running the
test_lwt_ip_encap.sh it will complain that test_lwt_ip_encap.o can't be
find.

$ ./test_lwt_ip_encap.sh
starting egress IPv4 encap test
Error opening object test_lwt_ip_encap.o: No such file or directory
Object hashing failed!
Cannot initialize ELF context!
Failed to parse eBPF program: Invalid argument

Rework to add test_lwt_ip_encap.o to TEST_FILES so the object file gets
installed when installing kselftest.

Fixes: 74b5a5968fe8 ("selftests/bpf: Replace test_progs and test_maps w/ general rule")
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
Acked-by: Song Liu <songliubraving@fb.com>
---
 tools/testing/selftests/bpf/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
index b334a6db15c1..cc09b5df9403 100644
--- a/tools/testing/selftests/bpf/Makefile
+++ b/tools/testing/selftests/bpf/Makefile
@@ -38,7 +38,7 @@ TEST_GEN_PROGS += test_progs-bpf_gcc
 endif
 
 TEST_GEN_FILES =
-TEST_FILES =
+TEST_FILES = test_lwt_ip_encap.o
 
 # Order correspond to 'make run_tests' order
 TEST_PROGS := test_kmod.sh \
-- 
2.20.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH bpf-next 2/2] selftests: bpf: test_tc_edt: add missing object file to TEST_FILES
  2019-11-10  9:26 [PATCH bpf-next 1/2] selftests: bpf: test_lwt_ip_encap: add missing object file to TEST_FILES Anders Roxell
@ 2019-11-10  9:26 ` " Anders Roxell
  2019-11-11 12:45   ` Simon Horman
  0 siblings, 1 reply; 5+ messages in thread
From: Anders Roxell @ 2019-11-10  9:26 UTC (permalink / raw)
  To: ast, daniel, davem
  Cc: netdev, bpf, linux-kselftest, linux-kernel, shuah,
	songliubraving, Anders Roxell

When installing kselftests to its own directory and running the
test_tc_edt.sh it will complain that test_tc_edt.o can't be find.

$ ./test_tc_edt.sh
Error opening object test_tc_edt.o: No such file or directory
Object hashing failed!
Cannot initialize ELF context!
Unable to load program

Rework to add test_tc_edt.o to TEST_FILES so the object file gets
installed when installing kselftest.

Fixes: 74b5a5968fe8 ("selftests/bpf: Replace test_progs and test_maps w/ general rule")
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
Acked-by: Song Liu <songliubraving@fb.com>
---
 tools/testing/selftests/bpf/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
index cc09b5df9403..b03dc2298fea 100644
--- a/tools/testing/selftests/bpf/Makefile
+++ b/tools/testing/selftests/bpf/Makefile
@@ -38,7 +38,8 @@ TEST_GEN_PROGS += test_progs-bpf_gcc
 endif
 
 TEST_GEN_FILES =
-TEST_FILES = test_lwt_ip_encap.o
+TEST_FILES = test_lwt_ip_encap.o \
+	test_tc_edt.o
 
 # Order correspond to 'make run_tests' order
 TEST_PROGS := test_kmod.sh \
-- 
2.20.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH bpf-next 2/2] selftests: bpf: test_tc_edt: add missing object file to TEST_FILES
  2019-11-10  9:26 ` [PATCH bpf-next 2/2] selftests: bpf: test_tc_edt: " Anders Roxell
@ 2019-11-11 12:45   ` Simon Horman
  2019-11-11 13:01     ` Daniel Borkmann
  0 siblings, 1 reply; 5+ messages in thread
From: Simon Horman @ 2019-11-11 12:45 UTC (permalink / raw)
  To: Anders Roxell
  Cc: ast, daniel, davem, netdev, bpf, linux-kselftest, linux-kernel,
	shuah, songliubraving

On Sun, Nov 10, 2019 at 10:26:16AM +0100, Anders Roxell wrote:
> When installing kselftests to its own directory and running the
> test_tc_edt.sh it will complain that test_tc_edt.o can't be find.
> 
> $ ./test_tc_edt.sh
> Error opening object test_tc_edt.o: No such file or directory
> Object hashing failed!
> Cannot initialize ELF context!
> Unable to load program
> 
> Rework to add test_tc_edt.o to TEST_FILES so the object file gets
> installed when installing kselftest.
> 
> Fixes: 74b5a5968fe8 ("selftests/bpf: Replace test_progs and test_maps w/ general rule")
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> Acked-by: Song Liu <songliubraving@fb.com>

It seems to me that the two patches that comprise this series
should be combined as they seem to be fixing two halves of the same
problem.

> ---
>  tools/testing/selftests/bpf/Makefile | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
> index cc09b5df9403..b03dc2298fea 100644
> --- a/tools/testing/selftests/bpf/Makefile
> +++ b/tools/testing/selftests/bpf/Makefile
> @@ -38,7 +38,8 @@ TEST_GEN_PROGS += test_progs-bpf_gcc
>  endif
>  
>  TEST_GEN_FILES =
> -TEST_FILES = test_lwt_ip_encap.o
> +TEST_FILES = test_lwt_ip_encap.o \
> +	test_tc_edt.o
>  
>  # Order correspond to 'make run_tests' order
>  TEST_PROGS := test_kmod.sh \
> -- 
> 2.20.1
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH bpf-next 2/2] selftests: bpf: test_tc_edt: add missing object file to TEST_FILES
  2019-11-11 12:45   ` Simon Horman
@ 2019-11-11 13:01     ` Daniel Borkmann
  2019-11-11 14:22       ` Anders Roxell
  0 siblings, 1 reply; 5+ messages in thread
From: Daniel Borkmann @ 2019-11-11 13:01 UTC (permalink / raw)
  To: Simon Horman, Anders Roxell
  Cc: ast, davem, netdev, bpf, linux-kselftest, linux-kernel, shuah,
	songliubraving

On 11/11/19 1:45 PM, Simon Horman wrote:
> On Sun, Nov 10, 2019 at 10:26:16AM +0100, Anders Roxell wrote:
>> When installing kselftests to its own directory and running the
>> test_tc_edt.sh it will complain that test_tc_edt.o can't be find.
>>
>> $ ./test_tc_edt.sh
>> Error opening object test_tc_edt.o: No such file or directory
>> Object hashing failed!
>> Cannot initialize ELF context!
>> Unable to load program
>>
>> Rework to add test_tc_edt.o to TEST_FILES so the object file gets
>> installed when installing kselftest.
>>
>> Fixes: 74b5a5968fe8 ("selftests/bpf: Replace test_progs and test_maps w/ general rule")
>> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
>> Acked-by: Song Liu <songliubraving@fb.com>
> 
> It seems to me that the two patches that comprise this series
> should be combined as they seem to be fixing two halves of the same
> problem.

Yep, agree, please respin as single patch.

Thanks,
Daniel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH bpf-next 2/2] selftests: bpf: test_tc_edt: add missing object file to TEST_FILES
  2019-11-11 13:01     ` Daniel Borkmann
@ 2019-11-11 14:22       ` Anders Roxell
  0 siblings, 0 replies; 5+ messages in thread
From: Anders Roxell @ 2019-11-11 14:22 UTC (permalink / raw)
  To: Daniel Borkmann
  Cc: Simon Horman, Alexei Starovoitov, David Miller, Networking, bpf,
	open list:KERNEL SELFTEST FRAMEWORK, Linux Kernel Mailing List,
	Shuah Khan, songliubraving

On Mon, 11 Nov 2019 at 14:01, Daniel Borkmann <daniel@iogearbox.net> wrote:
>
> On 11/11/19 1:45 PM, Simon Horman wrote:
> > On Sun, Nov 10, 2019 at 10:26:16AM +0100, Anders Roxell wrote:
> >> When installing kselftests to its own directory and running the
> >> test_tc_edt.sh it will complain that test_tc_edt.o can't be find.
> >>
> >> $ ./test_tc_edt.sh
> >> Error opening object test_tc_edt.o: No such file or directory
> >> Object hashing failed!
> >> Cannot initialize ELF context!
> >> Unable to load program
> >>
> >> Rework to add test_tc_edt.o to TEST_FILES so the object file gets
> >> installed when installing kselftest.
> >>
> >> Fixes: 74b5a5968fe8 ("selftests/bpf: Replace test_progs and test_maps w/ general rule")
> >> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> >> Acked-by: Song Liu <songliubraving@fb.com>
> >
> > It seems to me that the two patches that comprise this series
> > should be combined as they seem to be fixing two halves of the same
> > problem.
>
> Yep, agree, please respin as single patch.

OK I'll respin it to a single patch.

Cheers,
Anders

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-10  9:26 [PATCH bpf-next 1/2] selftests: bpf: test_lwt_ip_encap: add missing object file to TEST_FILES Anders Roxell
2019-11-10  9:26 ` [PATCH bpf-next 2/2] selftests: bpf: test_tc_edt: " Anders Roxell
2019-11-11 12:45   ` Simon Horman
2019-11-11 13:01     ` Daniel Borkmann
2019-11-11 14:22       ` Anders Roxell

BPF Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/bpf/0 bpf/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 bpf bpf/ https://lore.kernel.org/bpf \
		bpf@vger.kernel.org
	public-inbox-index bpf

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.bpf


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git