From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Andrii Nakryiko <andriin@fb.com>
Cc: <bpf@vger.kernel.org>, <netdev@vger.kernel.org>, <ast@fb.com>,
<daniel@iogearbox.net>, <andrii.nakryiko@gmail.com>,
<kernel-team@fb.com>, Rik van Riel <riel@surriel.com>,
Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH v2 bpf-next 1/3] bpf: add mmap() support for BPF_MAP_TYPE_ARRAY
Date: Mon, 11 Nov 2019 10:39:16 -0800 [thread overview]
Message-ID: <20191111103916.0af3ac5b@cakuba> (raw)
In-Reply-To: <20191109080633.2855561-2-andriin@fb.com>
On Sat, 9 Nov 2019 00:06:30 -0800, Andrii Nakryiko wrote:
> @@ -74,7 +78,7 @@ static struct bpf_map *array_map_alloc(union bpf_attr *attr)
> int ret, numa_node = bpf_map_attr_numa_node(attr);
> u32 elem_size, index_mask, max_entries;
> bool unpriv = !capable(CAP_SYS_ADMIN);
> - u64 cost, array_size, mask64;
> + u64 cost, array_size, data_size, mask64;
> struct bpf_map_memory mem;
> struct bpf_array *array;
>
Please don't break reverse xmas tree where it exists.
next prev parent reply other threads:[~2019-11-11 19:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-09 8:06 [PATCH v2 bpf-next 0/3] Add support for memory-mapping BPF array maps Andrii Nakryiko
2019-11-09 8:06 ` [PATCH v2 bpf-next 1/3] bpf: add mmap() support for BPF_MAP_TYPE_ARRAY Andrii Nakryiko
2019-11-11 16:40 ` Song Liu
2019-11-11 18:37 ` Jakub Kicinski
2019-11-12 2:06 ` Andrii Nakryiko
2019-11-12 19:17 ` Jakub Kicinski
2019-11-12 22:03 ` Andrii Nakryiko
2019-11-12 22:38 ` Jakub Kicinski
2019-11-13 3:19 ` Andrii Nakryiko
2019-11-11 18:39 ` Jakub Kicinski [this message]
2019-11-12 2:01 ` Andrii Nakryiko
2019-11-09 8:06 ` [PATCH v2 bpf-next 2/3] libbpf: make global data internal arrays mmap()-able, if possible Andrii Nakryiko
2019-11-11 18:40 ` Jakub Kicinski
2019-11-12 2:11 ` Andrii Nakryiko
2019-11-09 8:06 ` [PATCH v2 bpf-next 3/3] selftests/bpf: add BPF_TYPE_MAP_ARRAY mmap() tests Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191111103916.0af3ac5b@cakuba \
--to=jakub.kicinski@netronome.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=riel@surriel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).