From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9B77C43331 for ; Mon, 11 Nov 2019 10:54:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8BC432184C for ; Mon, 11 Nov 2019 10:54:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b="m/C0zTKI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726819AbfKKKyn (ORCPT ); Mon, 11 Nov 2019 05:54:43 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:40497 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726768AbfKKKym (ORCPT ); Mon, 11 Nov 2019 05:54:42 -0500 Received: by mail-wm1-f66.google.com with SMTP id f3so12681293wmc.5 for ; Mon, 11 Nov 2019 02:54:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=lToaTmvr8fy0RpR4xphta47cdM5tajY9+snWlAWAmmk=; b=m/C0zTKIOmGC5v630lFUm3qIJArxvuUUaaagoZd/CTNqt14WZj7HquPC7t+WgpqiDD AE7/WfQ6ispw1Ey8zKxbxi7kQOJsQ+xaLbKs+8pwDec4LCiyFfElohL+DVNOn7R2sRr9 NTEHJ5I2Xj77N1pC05GLg8mcd/8eX4UpNpLYk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=lToaTmvr8fy0RpR4xphta47cdM5tajY9+snWlAWAmmk=; b=ayLxnpUPIAjbBRunUY6c6nylc8zcsGJy2L/wkcSQAma/AnYmx6s6iRfiSy5w3mI+b2 wkSr+QmrbedyGvpjfFwv8GgfD3h1qSGG/EOP0lhZJ4PX/Bp5hYp1Q577CehR4WvcOtoD okSS98zoSRL/Z3Yyb3Au/HBIs87nWO0g4KxFE5PPV/YKntSeyl8G+hHYRegBtqJbHT21 GYEn9ZD4Zdjsu7zMt7eEQ4kDMJblPaEF+9j9oSrMPTegcq5ZEVQ5DW50xHSLP4UWTak7 SBriM8D6FWInrgKAIi89HCFukwiVaoaPYEqnXnL4po8IwYNNhl4MHVJ9/135XR7nF4NY GeRg== X-Gm-Message-State: APjAAAUZ+d+T4wkXCddotC+paJIMcjqABLP+V6zQdtMrqGIn1hdWL6s9 aDHRHS1aTdRc93WowNCftB0aRg== X-Google-Smtp-Source: APXvYqzEHvqlLf7DlW4OFCMB7eDjAjua2in9y4YUdN6gCY38kbdvIzivc2fryHjd8+TbjBf6uTTvbw== X-Received: by 2002:a1c:a406:: with SMTP id n6mr21168439wme.90.1573469680641; Mon, 11 Nov 2019 02:54:40 -0800 (PST) Received: from localhost.localdomain ([2a06:98c0:1000:8250:6be3:785e:4546:dd8f]) by smtp.gmail.com with ESMTPSA id z9sm6172585wrv.35.2019.11.11.02.54.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Nov 2019 02:54:39 -0800 (PST) From: Arthur Fabre To: Solarflare linux maintainers , Edward Cree , Charles McLachlan , Martin Habets , David Miller , Alexei Starovoitov , Daniel Borkmann , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend , netdev@vger.kernel.org, bpf@vger.kernel.org Cc: kernel-team@cloudflare.com, Arthur Fabre Subject: [PATCH net-next] sfc: trace_xdp_exception on XDP failure Date: Mon, 11 Nov 2019 10:51:00 +0000 Message-Id: <20191111105100.2992-1-afabre@cloudflare.com> X-Mailer: git-send-email 2.24.0.rc2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org The sfc driver can drop packets processed with XDP, notably when running out of buffer space on XDP_TX, or returning an unknown XDP action. This increments the rx_xdp_bad_drops ethtool counter. Call trace_xdp_exception everywhere rx_xdp_bad_drops is incremented to easily monitor this from userspace. This mirrors the behavior of other drivers. Signed-off-by: Arthur Fabre --- drivers/net/ethernet/sfc/rx.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/sfc/rx.c b/drivers/net/ethernet/sfc/rx.c index a7d9841105d8..5bfe1f6112a1 100644 --- a/drivers/net/ethernet/sfc/rx.c +++ b/drivers/net/ethernet/sfc/rx.c @@ -678,6 +678,7 @@ static bool efx_do_xdp(struct efx_nic *efx, struct efx_channel *channel, "XDP is not possible with multiple receive fragments (%d)\n", channel->rx_pkt_n_frags); channel->n_rx_xdp_bad_drops++; + trace_xdp_exception(efx->net_dev, xdp_prog, xdp_act); return false; } @@ -724,6 +725,7 @@ static bool efx_do_xdp(struct efx_nic *efx, struct efx_channel *channel, netif_err(efx, rx_err, efx->net_dev, "XDP TX failed (%d)\n", err); channel->n_rx_xdp_bad_drops++; + trace_xdp_exception(efx->net_dev, xdp_prog, xdp_act); } else { channel->n_rx_xdp_tx++; } @@ -737,6 +739,7 @@ static bool efx_do_xdp(struct efx_nic *efx, struct efx_channel *channel, netif_err(efx, rx_err, efx->net_dev, "XDP redirect failed (%d)\n", err); channel->n_rx_xdp_bad_drops++; + trace_xdp_exception(efx->net_dev, xdp_prog, xdp_act); } else { channel->n_rx_xdp_redirect++; } @@ -746,6 +749,7 @@ static bool efx_do_xdp(struct efx_nic *efx, struct efx_channel *channel, bpf_warn_invalid_xdp_action(xdp_act); efx_free_rx_buffers(rx_queue, rx_buf, 1); channel->n_rx_xdp_bad_drops++; + trace_xdp_exception(efx->net_dev, xdp_prog, xdp_act); break; case XDP_ABORTED: -- 2.24.0.rc2