From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A79FAC432C3 for ; Thu, 21 Nov 2019 14:36:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7AFA7206B6 for ; Thu, 21 Nov 2019 14:36:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="XkP12c/i" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726992AbfKUOgr (ORCPT ); Thu, 21 Nov 2019 09:36:47 -0500 Received: from mail-qv1-f66.google.com ([209.85.219.66]:39112 "EHLO mail-qv1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726573AbfKUOgq (ORCPT ); Thu, 21 Nov 2019 09:36:46 -0500 Received: by mail-qv1-f66.google.com with SMTP id v16so1480955qvq.6 for ; Thu, 21 Nov 2019 06:36:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=rv5c3PJEtM2ffNdfZuVl2p9Xs+FPDxJaOjEmQ2G8DAo=; b=XkP12c/ibS/aRyryTCd4qjn/PXxyYCusK1THaNAzNjypEGkjhmCt9LtT+qYEnSe3fB R0spZ8YqysCDI95uGLLvFVswmZUjEqJ9cNCyHcavEFwClRwZ6y4PKDy88MyzZlAfM967 hisIg3vRQPZ469GZRWnqA3CNAZUY/hKDr+kXV7+2R0BibPU9CM1KGy5uODfMlNXxTJJo tHEs5mFWOzUwzAdEjcr2fH3dCNIBIBIgehoNt8ki1/1o3yu01BkPAihfF+3/v5R6c6NG mm7J2IKwvLhTCpGsMr85umCSjimcUeH9XgLjTylXIMq1THOPpUYiNcR9NxoGX25nyfzV YKKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=rv5c3PJEtM2ffNdfZuVl2p9Xs+FPDxJaOjEmQ2G8DAo=; b=DjSm0V5CzgvcWQFwkktqQxpJdOkG0f01HSaOPs18Wc2+nTv1DqTnr2UIeJbeK3L/dt yTXPXyubCitEVEDaAJDFFzhLu0UxWH+U+2rE+AqYrAVBZ/w93jv/e9xZGvJMFJ69J9dI pz3bZag0FZMuTApYuP3p+Wu5xYvPApgefmrkxiX8yCDg385rZ0IznB4Y6vTZ1mFJ6no/ nUixmNXrI0KxRK7Z6igTSxQV4jKfpQJwuXG/N2n7V8a5w7yAzAwRVQzRLcZI0/02U9oa 65mLG4qF7wrrSFAmUHETq2Ly9DNQmvm31EjROwwlBH5YCyQHMMIu+vbpk5mBFbwNtjwd 5vwQ== X-Gm-Message-State: APjAAAUdgvg5QxTRbicgM1GXzXfl7Au19LJzLNFOab+AvNjhtyrJ5Cd6 iVW+zGN5XZivlAUvUkaMPYx2pg== X-Google-Smtp-Source: APXvYqxiPTD6uqfSlGreW7CNwXwCXJOA4tNSbO40QzzV7IhKLzuaPAx4PWY7OQoHdNILaiGopmJlAA== X-Received: by 2002:a0c:e74a:: with SMTP id g10mr8540002qvn.29.1574347005412; Thu, 21 Nov 2019 06:36:45 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-113-180.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.180]) by smtp.gmail.com with ESMTPSA id 40sm1584912qtc.95.2019.11.21.06.36.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Nov 2019 06:36:44 -0800 (PST) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1iXnZb-0004bF-SZ; Thu, 21 Nov 2019 10:36:43 -0400 Date: Thu, 21 Nov 2019 10:36:43 -0400 From: Jason Gunthorpe To: Christoph Hellwig Cc: John Hubbard , Andrew Morton , Al Viro , Alex Williamson , Benjamin Herrenschmidt , =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= , Dan Williams , Daniel Vetter , Dave Chinner , David Airlie , "David S . Miller" , Ira Weiny , Jan Kara , Jens Axboe , Jonathan Corbet , =?utf-8?B?SsOpcsO0bWU=?= Glisse , Magnus Karlsson , Mauro Carvalho Chehab , Michael Ellerman , Michal Hocko , Mike Kravetz , Paul Mackerras , Shuah Khan , Vlastimil Babka , bpf@vger.kernel.org, dri-devel@lists.freedesktop.org, kvm@vger.kernel.org, linux-block@vger.kernel.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-media@vger.kernel.org, linux-rdma@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org, linux-mm@kvack.org, LKML Subject: Re: [PATCH v7 07/24] IB/umem: use get_user_pages_fast() to pin DMA pages Message-ID: <20191121143643.GC7448@ziepe.ca> References: <20191121071354.456618-1-jhubbard@nvidia.com> <20191121071354.456618-8-jhubbard@nvidia.com> <20191121080746.GC30991@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191121080746.GC30991@infradead.org> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Thu, Nov 21, 2019 at 12:07:46AM -0800, Christoph Hellwig wrote: > On Wed, Nov 20, 2019 at 11:13:37PM -0800, John Hubbard wrote: > > And get rid of the mmap_sem calls, as part of that. Note > > that get_user_pages_fast() will, if necessary, fall back to > > __gup_longterm_unlocked(), which takes the mmap_sem as needed. > > > > Reviewed-by: Jan Kara > > Reviewed-by: Jason Gunthorpe > > Reviewed-by: Ira Weiny > > Signed-off-by: John Hubbard > > Looks fine, > > Reviewed-by: Christoph Hellwig > > Jason, can you queue this up for 5.5 to reduce this patch stack a bit? Yes, I said I'd do this in an earlier revision. Now that it is clear this won't go through Andrew's tree, applied to rdma for-next Thanks, Jason