From: Dan Carpenter <dan.carpenter@oracle.com>
To: Anton Ivanov <anton.ivanov@cambridgegreys.com>
Cc: Wei Yongjun <weiyongjun1@huawei.com>,
Song Liu <songliubraving@fb.com>,
Daniel Borkmann <daniel@iogearbox.net>,
kernel-janitors@vger.kernel.org,
Richard Weinberger <richard@nod.at>,
Jeff Dike <jdike@addtoit.com>,
linux-um@lists.infradead.org, Alexei Starovoitov <ast@kernel.org>,
netdev@vger.kernel.org, bpf@vger.kernel.org,
Martin KaFai Lau <kafai@fb.com>
Subject: Re: [PATCH -next] um: vector: use GFP_ATOMIC under spin lock
Date: Thu, 28 Nov 2019 11:37:35 +0300 [thread overview]
Message-ID: <20191128083735.GE1781@kadam> (raw)
In-Reply-To: <5892ee7c-ff24-fb3c-6911-44e0b1d5895f@cambridgegreys.com>
On Thu, Nov 28, 2019 at 08:18:30AM +0000, Anton Ivanov wrote:
>
>
> On 28/11/2019 08:06, Dan Carpenter wrote:
> > On Thu, Nov 28, 2019 at 02:01:47AM +0000, Wei Yongjun wrote:
> > > A spin lock is taken here so we should use GFP_ATOMIC.
> > >
> > > Fixes: 9807019a62dc ("um: Loadable BPF "Firmware" for vector drivers")
> > > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> > > ---
> > > arch/um/drivers/vector_kern.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/arch/um/drivers/vector_kern.c b/arch/um/drivers/vector_kern.c
> > > index 92617e16829e..6ff0065a271d 100644
> > > --- a/arch/um/drivers/vector_kern.c
> > > +++ b/arch/um/drivers/vector_kern.c
> > > @@ -1402,7 +1402,7 @@ static int vector_net_load_bpf_flash(struct net_device *dev,
> > > kfree(vp->bpf->filter);
> > > vp->bpf->filter = NULL;
> > > } else {
> > > - vp->bpf = kmalloc(sizeof(struct sock_fprog), GFP_KERNEL);
> > > + vp->bpf = kmalloc(sizeof(struct sock_fprog), GFP_ATOMIC);
> > > if (vp->bpf == NULL) {
> > > netdev_err(dev, "failed to allocate memory for firmware\n");
> > > goto flash_fail;
> > > @@ -1414,7 +1414,7 @@ static int vector_net_load_bpf_flash(struct net_device *dev,
> > > if (request_firmware(&fw, efl->data, &vdevice->pdev.dev))
> > ^^^^^^^^^^^^^^^^
> >
> > Is it really possible to call request_firmware() while holding a
> > spin_lock? I was so sure that read from the disk.
>
> Works, I tested the patch quite a few times.
>
Do you have CONFIG_DEBUG_ATOMIC_SLEEP enabled? The GFP_KERNEL calls
should have triggered a warning if so.
regards,
dan carpenter
next prev parent reply other threads:[~2019-11-28 8:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-28 2:01 [PATCH -next] um: vector: use GFP_ATOMIC under spin lock Wei Yongjun
2019-11-28 7:51 ` Anton Ivanov
2019-11-28 8:06 ` Dan Carpenter
2019-11-28 8:18 ` Anton Ivanov
2019-11-28 8:37 ` Dan Carpenter [this message]
2019-11-28 9:22 ` Anton Ivanov
2019-11-28 8:41 ` Richard Weinberger
2019-11-28 9:24 ` Anton Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191128083735.GE1781@kadam \
--to=dan.carpenter@oracle.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jdike@addtoit.com \
--cc=kafai@fb.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=richard@nod.at \
--cc=songliubraving@fb.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).