From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D3A2C43603 for ; Wed, 4 Dec 2019 23:39:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 59959206DB for ; Wed, 4 Dec 2019 23:39:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QC9uba6k" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728053AbfLDXjy (ORCPT ); Wed, 4 Dec 2019 18:39:54 -0500 Received: from mail-pg1-f194.google.com ([209.85.215.194]:34076 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727989AbfLDXjx (ORCPT ); Wed, 4 Dec 2019 18:39:53 -0500 Received: by mail-pg1-f194.google.com with SMTP id r11so650219pgf.1; Wed, 04 Dec 2019 15:39:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=T+fmIAcbvPunjOne4lSVzDFj12f4dda2gaEWlkYAhO4=; b=QC9uba6k0eil9dabA/dnJu+IfZoCjL9HkwHTeIfZ+PvQfEaylkJZq80YcxGpIVce4D +ZO5pgMqjg+Oiefmbv1wppCCjVejhHdyZyDCh8JfeRXomomdyoHZzx5gnxRf4vOXxU2Z ARnlPk2dCZStJ27MIPhSdwb8Fl1Gf+zSpcPWqX8A16j/jDKkJ4dZY1jJiCeD0EYTUX9Y iFjAN+GCdi0GTJ+EGs1G1NsitP4FGspIHa/ZBpIAc9prEZT37p20N0HUDMo2ApYRGxv8 HQTWCZoXgU68jZ2e9y3t5Yh78Jak00gmDgnb71iBDcyq6ccpCv7Ca5sPx85OfDLrFrAB JYwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=T+fmIAcbvPunjOne4lSVzDFj12f4dda2gaEWlkYAhO4=; b=kRgn+2TQjAKOnR6t+dGuo0mo2mbK3j+bLZu+in9JOev5oyyZNqNr65mWBBtmRBkHz9 PWXo+/YmNuEBlatq5jRwx7BYKktbvB1bWGpqC6odgmBPkFb+7ZWJ/2p+YeCbE8XlqmW4 tQjtF7uvxbLxqSQ2bpZwlEkjL77kETuuaSI5k+tuyP7bPfVfhfvh3VrXPOCes/vqUFAH 7ZJpBjDtQ9ldAq5P83K8fRtX0yaUwGUcnYX3OIIYwep9lGvy7AnZ6CLSp7sF6U2MbGt+ COfZpQAqYjoQPqnWOFCMPr9ZG65DHS9VtCmbqIr2J4JMAazcW3C1bHEYktCW1vxHD6HS xIag== X-Gm-Message-State: APjAAAVRDgHQ8rFwPzLBodfzv3hALoKHrgqWtFjjidH9VZuayCmbiOlz AQxDdzhvBwfBlLKn56b75eU= X-Google-Smtp-Source: APXvYqwGFrV46HuiqLpRY8kXemfGVnefFTlDWtqzEP44TXsqp4AkeVHfpn7V9XR9DokKpMf9Db4i9w== X-Received: by 2002:a62:e210:: with SMTP id a16mr6209696pfi.123.1575502792921; Wed, 04 Dec 2019 15:39:52 -0800 (PST) Received: from ast-mbp.dhcp.thefacebook.com ([2620:10d:c090:180::f9fe]) by smtp.gmail.com with ESMTPSA id r193sm3923243pfr.100.2019.12.04.15.39.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Dec 2019 15:39:52 -0800 (PST) Date: Wed, 4 Dec 2019 15:39:49 -0800 From: Alexei Starovoitov To: Jakub Kicinski Cc: Andrii Nakryiko , Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= , Jiri Olsa , Arnaldo Carvalho de Melo , lkml , Networking , bpf , Ingo Molnar , Namhyung Kim , Alexander Shishkin , Peter Zijlstra , Michael Petlan , Jesper Dangaard Brouer , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , Quentin Monnet Subject: Re: [PATCHv4 0/6] perf/bpftool: Allow to link libbpf dynamically Message-ID: <20191204233948.opvlopjkxe5o66lr@ast-mbp.dhcp.thefacebook.com> References: <20191202131847.30837-1-jolsa@kernel.org> <87wobepgy0.fsf@toke.dk> <20191204135405.3ffb9ad6@cakuba.netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191204135405.3ffb9ad6@cakuba.netronome.com> User-Agent: NeoMutt/20180223 Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Wed, Dec 04, 2019 at 01:54:05PM -0800, Jakub Kicinski wrote: > On Wed, 4 Dec 2019 13:16:13 -0800, Andrii Nakryiko wrote: > > I wonder what big advantage having bpftool in libbpf's Github repo > > brings, actually? The reason we need libbpf on github is to allow > > other projects like pahole to be able to use libbpf from submodule. > > There is no such need for bpftool. > > > > I agree about preference to release them in sync, but that could be > > easily done by releasing based on corresponding commits in github's > > libbpf repo and kernel repo. bpftool doesn't have to physically live > > next to libbpf on Github, does it? > > +1 > > > Calling github repo a "mirror" is incorrect. It's not a 1:1 copy of > > files. We have a completely separate Makefile for libbpf, and we have > > a bunch of stuff we had to re-implement to detach libbpf code from > > kernel's non-UAPI headers. Doing this for bpftool as well seems like > > just more maintenance. Keeping github's Makefile in sync with kernel's > > Makefile (for libbpf) is PITA, I'd rather avoid similar pains for > > bpftool without a really good reason. > > Agreed. Having libbpf on GH is definitely useful today, but one can hope > a day will come when distroes will get up to speed on packaging libbpf, > and perhaps we can retire it? Maybe 2, 3 years from now? Putting > bpftool in the same boat is just more baggage. Distros should be packaging libbpf and bpftool from single repo on github. Kernel tree is for packaging kernel.