From: Alexei Starovoitov <alexei.starovoitov@gmail.com> To: Jakub Kicinski <jakub.kicinski@netronome.com> Cc: "Andrii Nakryiko" <andrii.nakryiko@gmail.com>, "Toke Høiland-Jørgensen" <toke@redhat.com>, "Jiri Olsa" <jolsa@kernel.org>, "Arnaldo Carvalho de Melo" <acme@kernel.org>, lkml <linux-kernel@vger.kernel.org>, Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>, "Ingo Molnar" <mingo@kernel.org>, "Namhyung Kim" <namhyung@kernel.org>, "Alexander Shishkin" <alexander.shishkin@linux.intel.com>, "Peter Zijlstra" <a.p.zijlstra@chello.nl>, "Michael Petlan" <mpetlan@redhat.com>, "Jesper Dangaard Brouer" <brouer@redhat.com>, "Daniel Borkmann" <daniel@iogearbox.net>, "Martin KaFai Lau" <kafai@fb.com>, "Song Liu" <songliubraving@fb.com>, "Yonghong Song" <yhs@fb.com>, "Andrii Nakryiko" <andriin@fb.com>, "Quentin Monnet" <quentin.monnet@netronome.com> Subject: Re: [PATCHv4 0/6] perf/bpftool: Allow to link libbpf dynamically Date: Wed, 4 Dec 2019 17:09:32 -0800 Message-ID: <20191205010930.izft6kv5xlnejgog@ast-mbp.dhcp.thefacebook.com> (raw) In-Reply-To: <20191204162348.49be5f1b@cakuba.netronome.com> On Wed, Dec 04, 2019 at 04:23:48PM -0800, Jakub Kicinski wrote: > On Wed, 4 Dec 2019 15:39:49 -0800, Alexei Starovoitov wrote: > > > Agreed. Having libbpf on GH is definitely useful today, but one can hope > > > a day will come when distroes will get up to speed on packaging libbpf, > > > and perhaps we can retire it? Maybe 2, 3 years from now? Putting > > > bpftool in the same boat is just more baggage. > > > > Distros should be packaging libbpf and bpftool from single repo on github. > > Kernel tree is for packaging kernel. > > Okay, single repo on GitHub: > > https://github.com/torvalds/linux and how will you git submodule only libbpf part of kernel github into bcc and other projects? > You also said a few times you don't want to merge fixes into bpf/net. > That divergence from kernel development process is worrying. worrying - why? what exactly the concern you see? Tying user space release into kernel release and user space process into kernel process makes little sense to me. Packaging is different. Compatibility requirements are different. CI is different. Integration with other projects is different. libbpf source code is in the kernel tree only because kernel changes plus libbpf changes plus selftests changes come as single patchset. That is really the only reason. Packaging scripts, CI scripts, etc should be kept out of kernel tree. All that stuff belongs at github/libbpf. > None of this makes very much sense to me. We're diverging from well > established development practices without as much as a justification. The kernel development process was never used for libbpf. Even coding style is different. I'm puzzled why you think user space should be tied to kernel. Everything is so vastly different. Some people say that 8 weeks to bump libbpf version is too long. Other people say that it's too often. libbpf version numbers != kernel version numbers. There is no definition of LTS for libbpf. One day it will be and the version of libbpf picked for LTS will likely have nothing to do with kernel LTS choices. libbpf has to run on all kernels. Newer and older. How do you support that if libbpf is tied with the kernel? > Perhaps I'm not clever enough to follow. But if I'm allowed to make an > uneducated guess it would be that it's some Facebook internal reason, > like it's hard to do backports? :/ hard to do backports? of what?
next prev parent reply index Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-02 13:18 Jiri Olsa 2019-12-02 13:18 ` [PATCH 1/6] perf tools: Allow to specify libbpf install directory Jiri Olsa 2019-12-02 13:18 ` [PATCH 2/6] bpftool: Allow to link libbpf dynamically Jiri Olsa 2019-12-02 13:18 ` [PATCH 3/6] bpftool: Rename BPF_DIR Makefile variable to LIBBPF_SRC_DIR Jiri Olsa 2019-12-02 13:18 ` [PATCH 4/6] bpftool: Rename LIBBPF_OUTPUT Makefile variable to LIBBPF_BUILD_OUTPUT Jiri Olsa 2019-12-02 13:18 ` [PATCH 5/6] bpftool: Rename LIBBPF_PATH Makefile variable to LIBBPF_BUILD_PATH Jiri Olsa 2019-12-02 13:18 ` [PATCH 6/6] selftests, bpftool: Add build test for libbpf dynamic linking Jiri Olsa 2019-12-02 15:38 ` Quentin Monnet 2019-12-02 19:41 ` [PATCHv4 0/6] perf/bpftool: Allow to link libbpf dynamically Andrii Nakryiko 2019-12-02 21:15 ` Toke Høiland-Jørgensen 2019-12-04 5:52 ` Alexei Starovoitov 2019-12-04 9:01 ` Jiri Olsa 2019-12-04 10:57 ` Toke Høiland-Jørgensen 2019-12-04 17:39 ` Alexei Starovoitov 2019-12-04 18:27 ` Daniel Borkmann 2019-12-04 20:22 ` Toke Høiland-Jørgensen 2019-12-04 21:16 ` Andrii Nakryiko 2019-12-04 21:54 ` Jakub Kicinski 2019-12-04 23:39 ` Alexei Starovoitov 2019-12-05 0:23 ` Jakub Kicinski 2019-12-05 0:29 ` David Miller 2019-12-05 1:25 ` Alexei Starovoitov 2019-12-05 1:09 ` Alexei Starovoitov [this message] 2019-12-05 2:10 ` Jakub Kicinski 2019-12-05 3:17 ` Alexei Starovoitov 2019-12-05 4:26 ` Jakub Kicinski 2019-12-05 6:44 ` Alexei Starovoitov 2019-12-05 8:35 ` Jesper Dangaard Brouer 2019-12-05 12:09 ` Michal Rostecki
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191205010930.izft6kv5xlnejgog@ast-mbp.dhcp.thefacebook.com \ --to=alexei.starovoitov@gmail.com \ --cc=a.p.zijlstra@chello.nl \ --cc=acme@kernel.org \ --cc=alexander.shishkin@linux.intel.com \ --cc=andrii.nakryiko@gmail.com \ --cc=andriin@fb.com \ --cc=bpf@vger.kernel.org \ --cc=brouer@redhat.com \ --cc=daniel@iogearbox.net \ --cc=jakub.kicinski@netronome.com \ --cc=jolsa@kernel.org \ --cc=kafai@fb.com \ --cc=linux-kernel@vger.kernel.org \ --cc=mingo@kernel.org \ --cc=mpetlan@redhat.com \ --cc=namhyung@kernel.org \ --cc=netdev@vger.kernel.org \ --cc=quentin.monnet@netronome.com \ --cc=songliubraving@fb.com \ --cc=toke@redhat.com \ --cc=yhs@fb.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
BPF Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/bpf/0 bpf/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 bpf bpf/ https://lore.kernel.org/bpf \ bpf@vger.kernel.org public-inbox-index bpf Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.bpf AGPL code for this site: git clone https://public-inbox.org/public-inbox.git