From: Andrii Nakryiko <andriin@fb.com>
To: <bpf@vger.kernel.org>, <netdev@vger.kernel.org>, <ast@fb.com>,
<daniel@iogearbox.net>
Cc: <andrii.nakryiko@gmail.com>, <kernel-team@fb.com>,
Andrii Nakryiko <andriin@fb.com>
Subject: [PATCH bpf-next 0/4] Fix perf_buffer creation on systems with offline CPUs
Date: Wed, 11 Dec 2019 17:35:20 -0800 [thread overview]
Message-ID: <20191212013521.1689228-1-andriin@fb.com> (raw)
This patch set fixes perf_buffer__new() behavior on systems which have some of
the CPUs offline/missing (due to difference between "possible" and "online"
sets). perf_buffer will create per-CPU buffer and open/attach to corresponding
perf_event only on CPUs present and online at the moment of perf_buffer
creation. Without this logic, perf_buffer creation has no chances of
succeeding on such systems, preventing valid and correct BPF applications from
starting.
Andrii Nakryiko (4):
libbpf: extract and generalize CPU mask parsing logic
selftests/bpf: add CPU mask parsing tests
libbpf: don't attach perf_buffer to offline/missing CPUs
selftests/bpf: fix perf_buffer test on systems w/ offline CPUs
tools/lib/bpf/libbpf.c | 157 ++++++++++++------
tools/lib/bpf/libbpf_internal.h | 2 +
.../selftests/bpf/prog_tests/cpu_mask.c | 78 +++++++++
.../selftests/bpf/prog_tests/perf_buffer.c | 29 +++-
4 files changed, 213 insertions(+), 53 deletions(-)
create mode 100644 tools/testing/selftests/bpf/prog_tests/cpu_mask.c
--
2.17.1
next reply other threads:[~2019-12-12 1:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 1:35 Andrii Nakryiko [this message]
2019-12-13 21:04 ` [PATCH bpf-next 0/4] Fix perf_buffer creation on systems with offline CPUs Alexei Starovoitov
2019-12-16 14:44 ` Daniel Borkmann
2019-12-16 17:59 ` Andrii Nakryiko
2019-12-17 13:00 ` Daniel Borkmann
2019-12-20 17:46 ` Andrii Nakryiko
2020-02-09 17:18 ` Naresh Kamboju
2020-02-09 18:32 ` Andrii Nakryiko
2020-02-09 21:03 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191212013521.1689228-1-andriin@fb.com \
--to=andriin@fb.com \
--cc=andrii.nakryiko@gmail.com \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).