From: Andrey Ignatov <rdna@fb.com>
To: Martin Lau <kafai@fb.com>
Cc: "bpf@vger.kernel.org" <bpf@vger.kernel.org>,
"ast@kernel.org" <ast@kernel.org>,
"daniel@iogearbox.net" <daniel@iogearbox.net>,
"Andrii Nakryiko" <andrii.nakryiko@gmail.com>,
Kernel Team <Kernel-team@fb.com>
Subject: Re: [PATCH bpf-next 5/5] selftests/bpf: Cover BPF_F_REPLACE in test_cgroup_attach
Date: Thu, 12 Dec 2019 18:51:20 +0000 [thread overview]
Message-ID: <20191212185118.GB65217@rdna-mbp> (raw)
In-Reply-To: <20191212182616.le7deuzfis2r2sah@kafai-mbp>
Martin Lau <kafai@fb.com> [Thu, 2019-12-12 10:26 -0800]:
> On Tue, Dec 10, 2019 at 06:33:31PM -0800, Andrey Ignatov wrote:
...
> > + attach_attr.replace_prog_fd = -1;
> > + if (!bpf_prog_attach_xattr(&attach_attr)) {
> The whole set LGTM. I expect this attach bit will change based on
> the discussion in patch 4.
Right, I'll change libbpf part and this test according to the feedback
from Andrii and send v2.
Thank you!
--
Andrey Ignatov
prev parent reply other threads:[~2019-12-12 18:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 2:33 [PATCH bpf-next 0/5] bpf: Support replacing cgroup-bpf program in MULTI mode Andrey Ignatov
2019-12-11 2:33 ` [PATCH bpf-next 1/5] bpf: Simplify __cgroup_bpf_attach Andrey Ignatov
2019-12-12 17:57 ` Martin Lau
2019-12-11 2:33 ` [PATCH bpf-next 2/5] bpf: Remove unused new_flags in hierarchy_allows_attach() Andrey Ignatov
2019-12-12 17:57 ` [Potential Spoof] " Martin Lau
2019-12-11 2:33 ` [PATCH bpf-next 3/5] bpf: Support replacing cgroup-bpf program in MULTI mode Andrey Ignatov
2019-12-12 18:18 ` [Potential Spoof] " Martin Lau
2019-12-12 18:46 ` Andrey Ignatov
2019-12-11 2:33 ` [PATCH bpf-next 4/5] libbpf: Introduce bpf_prog_attach_xattr Andrey Ignatov
2019-12-12 8:08 ` Andrii Nakryiko
2019-12-11 2:33 ` [PATCH bpf-next 5/5] selftests/bpf: Cover BPF_F_REPLACE in test_cgroup_attach Andrey Ignatov
2019-12-12 18:26 ` Martin Lau
2019-12-12 18:51 ` Andrey Ignatov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191212185118.GB65217@rdna-mbp \
--to=rdna@fb.com \
--cc=Kernel-team@fb.com \
--cc=andrii.nakryiko@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kafai@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).