From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B735C43603 for ; Fri, 13 Dec 2019 23:59:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4B84422527 for ; Fri, 13 Dec 2019 23:59:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nRid5sBt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725818AbfLMX7l (ORCPT ); Fri, 13 Dec 2019 18:59:41 -0500 Received: from mail-pj1-f65.google.com ([209.85.216.65]:45766 "EHLO mail-pj1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725747AbfLMX7k (ORCPT ); Fri, 13 Dec 2019 18:59:40 -0500 Received: by mail-pj1-f65.google.com with SMTP id r11so376732pjp.12; Fri, 13 Dec 2019 15:59:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=50HvCH/NJ2dLPO5jG5aDUZzY5nY5WRo3l9wOsKfsOnc=; b=nRid5sBtQ62gETY1104+QYi3O4qKkqX//t7jb2Y9DX8V58VAqM8EFzy26x3f2+mobJ kuYEMXB4qz+xxWOLdasoMzOBZbKgmYokADZB1MzEqtisDKvYdYsd1n2xftJltUNHkFo+ y7+NSLRFVFSCCg8/iI0rX7e/bYLWfFdbOaKUJW3rcGGihzYtdfLCLgbmUFHQ9BPW0LHi r3NDhpw9ApsQ9XGmAs5qSF6LEBfc8Htv5/BFmHjLL9PzGiAV6NTFpSpCBJrA2v9ZZbaP dXq9+bBYP2206N5Aun8Eqkd525GQ7sksRvtMnar0NOb+DS8VeQ3fYtHyAYB3RCpO0zqZ GC5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=50HvCH/NJ2dLPO5jG5aDUZzY5nY5WRo3l9wOsKfsOnc=; b=oUZzZRhbA1tSuBpOIwRAHs5JYOibWaz2Exxu8rK7T+8I4Zj8BIgf5MJIb5zJMFmCvp tVSRjsLkzeVhiclfiE1d354hq38yFWCgDzA5cXyorkAtGeg/syj6W0JMPXzuR1XanhqM BVYdQIAq8r4nNdesEQUcR3btG6euq+wBDk/Ld/5Cp/kGpUG1IwM5mOydIjEHUhi392VU j0TKv5dwxUFQ09j9VgEeXJhTgOap+HQnXgOu8xZo5HzffC28oXfIoQS/c0DczPpZwGKf KB6m2+18FzhjT+K4tnVn4W9gPwAzj/t30WA918uptsEnO7ste2TTcYe5kKqbYBZsCSCK PnSQ== X-Gm-Message-State: APjAAAVSrdMC61tl8fJKd0fn6bjuwZgKoW4GrebRwqKCrpAxYbQ+OfTd SKrREjP3pPmXenl0GJiW95Q= X-Google-Smtp-Source: APXvYqxu8KMEvc+vDWyAyRr0PW/0wwFib4pYM/tMW/RJVLiE3WDUc0ictK0xn1vJcVagVUvKYYPUFA== X-Received: by 2002:a17:902:b188:: with SMTP id s8mr2223210plr.206.1576281580008; Fri, 13 Dec 2019 15:59:40 -0800 (PST) Received: from ast-mbp.dhcp.thefacebook.com ([2620:10d:c090:200::de66]) by smtp.gmail.com with ESMTPSA id c1sm12840655pfa.51.2019.12.13.15.59.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Dec 2019 15:59:39 -0800 (PST) Date: Fri, 13 Dec 2019 15:59:38 -0800 From: Alexei Starovoitov To: Andrii Nakryiko Cc: bpf@vger.kernel.org, netdev@vger.kernel.org, ast@fb.com, daniel@iogearbox.net, andrii.nakryiko@gmail.com, kernel-team@fb.com Subject: Re: [PATCH v3 bpf-next 12/17] libbpf: add BPF object skeleton support Message-ID: <20191213235937.naddjeklvds7akz7@ast-mbp.dhcp.thefacebook.com> References: <20191213223214.2791885-1-andriin@fb.com> <20191213223214.2791885-13-andriin@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191213223214.2791885-13-andriin@fb.com> User-Agent: NeoMutt/20180223 Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Fri, Dec 13, 2019 at 02:32:09PM -0800, Andrii Nakryiko wrote: > Add new set of APIs, allowing to open/load/attach BPF object through BPF > object skeleton, generated by bpftool for a specific BPF object file. All the > xxx_skeleton() APIs wrap up corresponding bpf_object_xxx() APIs, but > additionally also automate map/program lookups by name, global data > initialization and mmap()-ing, etc. All this greatly improves and simplifies > userspace usability of working with BPF programs. See follow up patches for > examples. > > Acked-by: Martin KaFai Lau > Signed-off-by: Andrii Nakryiko ... > +int bpf_object__open_skeleton(struct bpf_object_skeleton *s, > + const struct bpf_object_open_opts *opts); > +int bpf_object__load_skeleton(struct bpf_object_skeleton *s); > +int bpf_object__attach_skeleton(struct bpf_object_skeleton *s); > +void bpf_object__detach_skeleton(struct bpf_object_skeleton *s); > +void bpf_object__destroy_skeleton(struct bpf_object_skeleton *s); libbpf.map and LIBBPF_API update for them is missing ? The intent was to expose them as stable libbpf api, right?