From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 393E1C43603 for ; Sat, 14 Dec 2019 11:35:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 08F8924679 for ; Sat, 14 Dec 2019 11:35:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hF+NJEqw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726666AbfLNLf1 (ORCPT ); Sat, 14 Dec 2019 06:35:27 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:20388 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725995AbfLNLf1 (ORCPT ); Sat, 14 Dec 2019 06:35:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576323326; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fnFLoseAIUqVaLCUCqNEVG0PWtrK90uaCn6K4I9qTxs=; b=hF+NJEqw8icZC7gJzoYLY0KF+M6SZNK1dF0W4DvSfPz8rd6xV4fW7ChgON+vUhy/xDE1ps l4XipFH06X9pde8KDf5euFeVAgPsqSdMRNYqzCapYI2pVFaZtQK1KrNg1/Ewci04dqO8N8 cpGnwMfVqlE593M0lZwPyeQEvNkNtdI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-84-nKIjVvFUOI-I_KmJ5HcbXg-1; Sat, 14 Dec 2019 06:35:25 -0500 X-MC-Unique: nKIjVvFUOI-I_KmJ5HcbXg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B6B6B100550E; Sat, 14 Dec 2019 11:35:22 +0000 (UTC) Received: from krava (ovpn-204-62.brq.redhat.com [10.40.204.62]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EE62E61348; Sat, 14 Dec 2019 11:35:13 +0000 (UTC) Date: Sat, 14 Dec 2019 12:35:10 +0100 From: Jiri Olsa To: Steven Rostedt Cc: Peter Zijlstra , Alexei Starovoitov , Toke =?iso-8859-1?Q?H=F8iland-J=F8rgensen?= , Andrii Nakryiko , Jiri Olsa , Arnaldo Carvalho de Melo , lkml , Networking , bpf , Ingo Molnar , Namhyung Kim , Alexander Shishkin , Jesper Dangaard Brouer , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , Quentin Monnet Subject: Re: [RFC] btf: Some structs are doubled because of struct ring_buffer Message-ID: <20191214113510.GB12440@krava> References: <20191213153553.GE20583@krava> <20191213112438.773dff35@gandalf.local.home> <20191213165155.vimm27wo7brkh3yu@ast-mbp.dhcp.thefacebook.com> <20191213121118.236f55b8@gandalf.local.home> <20191213180223.GE2844@hirez.programming.kicks-ass.net> <20191213132941.6fa2d1bd@gandalf.local.home> <20191213184621.GG2844@hirez.programming.kicks-ass.net> <20191213140349.5a42a8af@gandalf.local.home> <20191213140531.116b3200@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191213140531.116b3200@gandalf.local.home> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Fri, Dec 13, 2019 at 02:05:31PM -0500, Steven Rostedt wrote: SNIP > struct trace_array *tr = filp->private_data; > - struct ring_buffer *buffer = tr->trace_buffer.buffer; > + struct trace_buffer *buffer = tr->trace_buffer.buffer; > unsigned long val; > int ret; > > diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h > index 63bf60f79398..308fcd673102 100644 > --- a/kernel/trace/trace.h > +++ b/kernel/trace/trace.h > @@ -178,7 +178,7 @@ struct trace_option_dentry; > > struct trace_buffer { > struct trace_array *tr; > - struct ring_buffer *buffer; > + struct trace_buffer *buffer; perf change is fine, but 'trace_buffer' won't work because we already have 'struct trace_buffer' defined in here maybe we could change this name to trace_buffer_array? thanks, jirka