From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E473C43603 for ; Tue, 17 Dec 2019 11:28:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 251AB207FF for ; Tue, 17 Dec 2019 11:28:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YCcPaSmb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727466AbfLQL2X (ORCPT ); Tue, 17 Dec 2019 06:28:23 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:35214 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726623AbfLQL2X (ORCPT ); Tue, 17 Dec 2019 06:28:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576582101; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Q61b8NZiNglATLygY8DSz74dZVTZ21KejyMo2z3MExs=; b=YCcPaSmbwTS4Rwvg+EMqgbRV15UENcXT24PD0H9WyjCYwb/FgyUqJp5UlQnJ1VmtsWz0kh Dj3rvdjHD2txq96CZIkIiYdwtwuCKr1vZ/ftCrFmxUA5mmQdqU/pEef3RfgEYhXu6dKkqU 8yG65d9ZI2gvFCsCXUJzKGbm9fi+H/U= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-377-OjzvsmhXP7aawy9juLbxXw-1; Tue, 17 Dec 2019 06:28:20 -0500 X-MC-Unique: OjzvsmhXP7aawy9juLbxXw-1 Received: by mail-lj1-f197.google.com with SMTP id b12so3136357ljo.11 for ; Tue, 17 Dec 2019 03:28:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Q61b8NZiNglATLygY8DSz74dZVTZ21KejyMo2z3MExs=; b=gNQjwaJFEBaTayv/VhO2XJ36c/d7MgyG1ev3lBOroU143572b4/bdLN63T02Z0DT/O 7aDvgABhuBAzOo3Izb5PH0nknejXaUAk1fr4b7ddUbwsC7ihuHoJOmKvtROtN4sfaj43 c+pED6W13AkT4DU66VnoLaZ/3shmPhbs8K8UPKpra9GR284XeskNZl1uA6TVMWSStVVm 149YjqPrDxIivkKAWXk3UK9F18AbYhSZgF4CPLJlMG7J/zwRvSzp8AC0c90jDTF8RxPz AAJGVLaV8NWMInB5rVyX285foK64b3Skthc/vWK2P6/sg1qA+SlZGCOWi5QaW35aJzab mn1g== X-Gm-Message-State: APjAAAUfkWDsIDHZy8zamVYA0aj74UuoO46FwmvbHC8RgRd1CAL9rAS/ AYuA3Kp8Z92X9wSeFe5IV1GQUvtgSbe9gPpWFxlirQcOkaZXZx4QvZNAtHMXtRBtXRTLkqWKBt4 kin/fI5AZNbpb X-Received: by 2002:a2e:b010:: with SMTP id y16mr2836006ljk.238.1576582099147; Tue, 17 Dec 2019 03:28:19 -0800 (PST) X-Google-Smtp-Source: APXvYqyIH5Q5OdQH6gcERzOp/eAcntIeffs5mFBn4uuIFZewUEQ+Uus+enM8p4BfdhFU/HZqLE/fQw== X-Received: by 2002:a2e:b010:: with SMTP id y16mr2835998ljk.238.1576582098973; Tue, 17 Dec 2019 03:28:18 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk ([45.145.92.2]) by smtp.gmail.com with ESMTPSA id b6sm7289731lfq.11.2019.12.17.03.28.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Dec 2019 03:28:18 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 943471800B3; Tue, 17 Dec 2019 12:28:16 +0100 (CET) From: =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= To: Alexei Starovoitov , Daniel Borkmann Cc: =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= , netdev@vger.kernel.org, bpf@vger.kernel.org Subject: [PATCH bpf-next] libbpf: Fix libbpf_common.h when installing libbpf through 'make install' Date: Tue, 17 Dec 2019 12:28:10 +0100 Message-Id: <20191217112810.768078-1-toke@redhat.com> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org This fixes two issues with the newly introduced libbpf_common.h file: - The header failed to include for the definition of memset() - The new file was not included in the install_headers rule in the Makefile Both of these issues cause breakage when installing libbpf with 'make install' and trying to use it in applications. Fixes: 544402d4b493 ("libbpf: Extract common user-facing helpers") Signed-off-by: Toke Høiland-Jørgensen --- tools/lib/bpf/Makefile | 1 + tools/lib/bpf/libbpf_common.h | 2 ++ 2 files changed, 3 insertions(+) diff --git a/tools/lib/bpf/Makefile b/tools/lib/bpf/Makefile index a3718cb275f2..d4790121adf4 100644 --- a/tools/lib/bpf/Makefile +++ b/tools/lib/bpf/Makefile @@ -251,6 +251,7 @@ install_headers: bpf_helper_defs.h $(call do_install,libbpf.h,$(prefix)/include/bpf,644); \ $(call do_install,btf.h,$(prefix)/include/bpf,644); \ $(call do_install,libbpf_util.h,$(prefix)/include/bpf,644); \ + $(call do_install,libbpf_common.h,$(prefix)/include/bpf,644); \ $(call do_install,xsk.h,$(prefix)/include/bpf,644); \ $(call do_install,bpf_helpers.h,$(prefix)/include/bpf,644); \ $(call do_install,bpf_helper_defs.h,$(prefix)/include/bpf,644); \ diff --git a/tools/lib/bpf/libbpf_common.h b/tools/lib/bpf/libbpf_common.h index 4fb833840961..a23ae1ac27eb 100644 --- a/tools/lib/bpf/libbpf_common.h +++ b/tools/lib/bpf/libbpf_common.h @@ -9,6 +9,8 @@ #ifndef __LIBBPF_LIBBPF_COMMON_H #define __LIBBPF_LIBBPF_COMMON_H +#include + #ifndef LIBBPF_API #define LIBBPF_API __attribute__((visibility("default"))) #endif -- 2.24.1