bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Andrii Nakryiko <andriin@fb.com>
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org, ast@fb.com,
	daniel@iogearbox.net, andrii.nakryiko@gmail.com,
	kernel-team@fb.com
Subject: Re: [PATCH v3 bpf-next 0/3] Skeleton improvements and documentation
Date: Tue, 17 Dec 2019 22:23:36 -0800	[thread overview]
Message-ID: <20191218062335.folwsve44bkawsvi@ast-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <20191218052552.2915188-1-andriin@fb.com>

On Tue, Dec 17, 2019 at 09:25:49PM -0800, Andrii Nakryiko wrote:
> Simplify skeleton usage by embedding source BPF object file inside skeleton
> itself. This allows to keep skeleton and object file in sync at all times with
> no chance of confusion.
> 
> Also, add bpftool-gen.rst manpage, explaining concepts and ideas behind
> skeleton. In examples section it also includes a complete small BPF
> application utilizing skeleton, as a demonstration of API.
> 
> Patch #2 also removes BPF_EMBED_OBJ, as there is currently no use of it.
> 
> v2->v3:
> - (void) in no-args function (Alexei);
> - bpftool-gen.rst code block formatting fix (Alexei);
> - simplified xxx__create_skeleton to fill in obj and return error code;
> 
> v1->v2:
> - remove whitespace from empty lines in code blocks (Yonghong).

Applied. Thanks.

This bit:
+		  layout will be created. Currently supported ones are: .data,
+		  .bss, .rodata, and .extern structs/data sections. These
didn't render correctly in the man page for me.
Not sure whehther it's an issue in my setup or .rst is invalid.
Please take a look.
Overall new man page looks great.


  parent reply	other threads:[~2019-12-18  6:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-18  5:25 [PATCH v3 bpf-next 0/3] Skeleton improvements and documentation Andrii Nakryiko
2019-12-18  5:25 ` [PATCH v3 bpf-next 1/3] bpftool, selftests/bpf: embed object file inside skeleton Andrii Nakryiko
2019-12-18  5:25 ` [PATCH v3 bpf-next 2/3] libbpf: remove BPF_EMBED_OBJ macro from libbpf.h Andrii Nakryiko
2019-12-18  5:25 ` [PATCH v3 bpf-next 3/3] bpftool: add gen subcommand manpage Andrii Nakryiko
2019-12-18  6:23 ` Alexei Starovoitov [this message]
2019-12-18 18:31   ` [PATCH v3 bpf-next 0/3] Skeleton improvements and documentation Andrii Nakryiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191218062335.folwsve44bkawsvi@ast-mbp.dhcp.thefacebook.com \
    --to=alexei.starovoitov@gmail.com \
    --cc=andrii.nakryiko@gmail.com \
    --cc=andriin@fb.com \
    --cc=ast@fb.com \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=kernel-team@fb.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).