From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C054C43603 for ; Wed, 18 Dec 2019 16:22:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7897C24650 for ; Wed, 18 Dec 2019 16:22:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727160AbfLRQWY (ORCPT ); Wed, 18 Dec 2019 11:22:24 -0500 Received: from mail.kernel.org ([198.145.29.99]:55844 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727021AbfLRQWX (ORCPT ); Wed, 18 Dec 2019 11:22:23 -0500 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AC2CC20717; Wed, 18 Dec 2019 16:22:21 +0000 (UTC) Date: Wed, 18 Dec 2019 11:22:19 -0500 From: Steven Rostedt To: Jiri Olsa Cc: Peter Zijlstra , Alexei Starovoitov , Toke =?UTF-8?B?SMO4aWxhbmQtSsO4cmdlbnNl?= =?UTF-8?B?bg==?= , Andrii Nakryiko , Jiri Olsa , Arnaldo Carvalho de Melo , lkml , Networking , bpf , Ingo Molnar , Namhyung Kim , Alexander Shishkin , Jesper Dangaard Brouer , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , Quentin Monnet Subject: Re: [RFC] btf: Some structs are doubled because of struct ring_buffer Message-ID: <20191218112219.309d1031@gandalf.local.home> In-Reply-To: <20191218161401.GC15571@krava> References: <20191213153553.GE20583@krava> <20191213112438.773dff35@gandalf.local.home> <20191213165155.vimm27wo7brkh3yu@ast-mbp.dhcp.thefacebook.com> <20191213121118.236f55b8@gandalf.local.home> <20191213180223.GE2844@hirez.programming.kicks-ass.net> <20191213132941.6fa2d1bd@gandalf.local.home> <20191213184621.GG2844@hirez.programming.kicks-ass.net> <20191213140349.5a42a8af@gandalf.local.home> <20191213140531.116b3200@gandalf.local.home> <20191214113510.GB12440@krava> <20191218161401.GC15571@krava> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Wed, 18 Dec 2019 17:14:01 +0100 Jiri Olsa wrote: > On Sat, Dec 14, 2019 at 12:35:10PM +0100, Jiri Olsa wrote: > > On Fri, Dec 13, 2019 at 02:05:31PM -0500, Steven Rostedt wrote: > > > > SNIP > > > > > struct trace_array *tr = filp->private_data; > > > - struct ring_buffer *buffer = tr->trace_buffer.buffer; > > > + struct trace_buffer *buffer = tr->trace_buffer.buffer; > > > unsigned long val; > > > int ret; > > > > > > diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h > > > index 63bf60f79398..308fcd673102 100644 > > > --- a/kernel/trace/trace.h > > > +++ b/kernel/trace/trace.h > > > @@ -178,7 +178,7 @@ struct trace_option_dentry; > > > > > > struct trace_buffer { > > > struct trace_array *tr; > > > - struct ring_buffer *buffer; > > > + struct trace_buffer *buffer; > > > > perf change is fine, but 'trace_buffer' won't work because > > we already have 'struct trace_buffer' defined in here > > > > maybe we could change this name to trace_buffer_array? > > ..like in patch below? it's independent of your previous changes > > Actually, I would prefer to call it either trace_array_buffer, or just array_buffer. -- Steve