From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andriin@fb.com>, bpf <bpf@vger.kernel.org>,
Networking <netdev@vger.kernel.org>,
Alexei Starovoitov <ast@fb.com>, Kernel Team <kernel-team@fb.com>
Subject: Re: [PATCH bpf-next 2/3] libbpf/tools: add runqslower tool to libbpf
Date: Thu, 19 Dec 2019 14:04:47 -0800 [thread overview]
Message-ID: <20191219220446.fhtn4i7w5wczuahq@ast-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <CAEf4BzZ8+_GYecvgGUXdOFj4Oca=U3_23PLWBJSAi0A8=gwReg@mail.gmail.com>
On Thu, Dec 19, 2019 at 01:14:46PM -0800, Andrii Nakryiko wrote:
> On Thu, Dec 19, 2019 at 7:41 AM Daniel Borkmann <daniel@iogearbox.net> wrote:
> >
> > On Wed, Dec 18, 2019 at 11:06:57PM -0800, Andrii Nakryiko wrote:
> > > Convert one of BCC tools (runqslower [0]) to BPF CO-RE + libbpf. It matches
> > > its BCC-based counterpart 1-to-1, supporting all the same parameters and
> > > functionality.
> > >
> > > runqslower tool utilizes BPF skeleton, auto-generated from BPF object file,
> > > as well as memory-mapped interface to global (read-only, in this case) data.
> > > Its makefile also ensures auto-generation of "relocatable" vmlinux.h, which is
> > > necessary for BTF-typed raw tracepoints with direct memory access.
> > >
> > > [0] https://github.com/iovisor/bcc/blob/11bf5d02c895df9646c117c713082eb192825293/tools/runqslower.py
> > >
> > > Signed-off-by: Andrii Nakryiko <andriin@fb.com>
> > > ---
> > > tools/lib/bpf/tools/runqslower/.gitignore | 2 +
> > > tools/lib/bpf/tools/runqslower/Makefile | 60 ++++++
> > > .../lib/bpf/tools/runqslower/runqslower.bpf.c | 101 ++++++++++
> > > tools/lib/bpf/tools/runqslower/runqslower.c | 187 ++++++++++++++++++
> > > tools/lib/bpf/tools/runqslower/runqslower.h | 13 ++
> >
> > tools/lib/bpf/tools/ is rather weird, please add to tools/bpf/ which is the
> > more appropriate place we have for small tools. Could also live directly in
> > there, e.g. tools/bpf/runqslower.{c,h,bpf.c} and then built/run from selftests,
> > but under libbpf directly is too odd.
>
> runqslower is as much as a showcase of how to build a stand-alone tool
> with libbpf and CO-RE, as a separate tool, which is why I put it under
> libbpf directory. It's also not really BPF-specific tool, wouldn't
> that make it weird to put it under tools/bpf along the bpftool? If we
> added few more such tools using BPF CO-RE + libbpf, would you feel
> it's still a good idea to put them under tools/bpf?
I agree with Daniel tools/bpf/ seems like better location.
next prev parent reply other threads:[~2019-12-19 22:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 7:06 [PATCH bpf-next 0/3] Implement runqslower BCC tool with BPF CO-RE Andrii Nakryiko
2019-12-19 7:06 ` [PATCH bpf-next 1/3] bpftool: add extra CO-RE mode to btf dump command Andrii Nakryiko
2019-12-19 17:06 ` Alexei Starovoitov
2019-12-19 21:07 ` Andrii Nakryiko
2019-12-19 22:04 ` Alexei Starovoitov
2019-12-20 17:40 ` Andrii Nakryiko
2019-12-21 3:21 ` Alexei Starovoitov
2019-12-21 5:40 ` Andrii Nakryiko
2019-12-19 7:06 ` [PATCH bpf-next 2/3] libbpf/tools: add runqslower tool to libbpf Andrii Nakryiko
2019-12-19 15:41 ` Daniel Borkmann
2019-12-19 21:14 ` Andrii Nakryiko
2019-12-19 22:04 ` Alexei Starovoitov [this message]
2019-12-19 18:13 ` Yonghong Song
2019-12-19 21:16 ` Andrii Nakryiko
2019-12-19 7:06 ` [PATCH bpf-next 3/3] selftests/bpf: build runqslower from selftests Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191219220446.fhtn4i7w5wczuahq@ast-mbp.dhcp.thefacebook.com \
--to=alexei.starovoitov@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).