From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Andrey Ignatov <rdna@fb.com>
Cc: bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
kafai@fb.com, andriin@fb.com, kernel-team@fb.com
Subject: Re: [PATCH v4 bpf-next 0/6] bpf: Support replacing cgroup-bpf program in MULTI mode
Date: Thu, 19 Dec 2019 21:33:13 -0800 [thread overview]
Message-ID: <20191220053311.menmpnootqshkzrw@ast-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <cover.1576741281.git.rdna@fb.com>
On Wed, Dec 18, 2019 at 11:44:32PM -0800, Andrey Ignatov wrote:
> v3->v4:
> - use OPTS_VALID and OPTS_GET to handle bpf_prog_attach_opts.
>
> v2->v3:
> - rely on DECLARE_LIBBPF_OPTS from libbpf_common.h;
> - separate "required" and "optional" arguments in bpf_prog_attach_xattr;
> - convert test_cgroup_attach to prog_tests;
> - move the new selftest to prog_tests/cgroup_attach_multi.
>
> v1->v2:
> - move DECLARE_LIBBPF_OPTS from libbpf.h to bpf.h (patch 4);
> - switch new libbpf API to OPTS framework;
> - switch selftest to libbpf OPTS framework.
>
> This patch set adds support for replacing cgroup-bpf programs attached with
> BPF_F_ALLOW_MULTI flag so that any program in a list can be updated to a new
> version without service interruption and order of programs can be preserved.
>
> Please see patch 3 for details on the use-case and API changes.
>
> Other patches:
> Patch 1 is preliminary refactoring of __cgroup_bpf_attach to simplify it.
> Patch 2 is minor cleanup of hierarchy_allows_attach.
> Patch 4 extends libbpf API to support new set of attach attributes.
> Patch 5 converts test_cgroup_attach to prog_tests.
> Patch 6 adds selftest coverage for the new API.
Applied, Thanks
prev parent reply other threads:[~2019-12-20 5:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 7:44 [PATCH v4 bpf-next 0/6] bpf: Support replacing cgroup-bpf program in MULTI mode Andrey Ignatov
2019-12-19 7:44 ` [PATCH v4 bpf-next 1/6] bpf: Simplify __cgroup_bpf_attach Andrey Ignatov
2019-12-19 22:31 ` Andrii Nakryiko
2019-12-19 7:44 ` [PATCH v4 bpf-next 2/6] bpf: Remove unused new_flags in hierarchy_allows_attach() Andrey Ignatov
2019-12-19 7:44 ` [PATCH v4 bpf-next 3/6] bpf: Support replacing cgroup-bpf program in MULTI mode Andrey Ignatov
2019-12-19 22:41 ` Andrii Nakryiko
2019-12-19 7:44 ` [PATCH v4 bpf-next 4/6] libbpf: Introduce bpf_prog_attach_xattr Andrey Ignatov
2019-12-19 22:42 ` Andrii Nakryiko
2019-12-19 7:44 ` [PATCH v4 bpf-next 5/6] selftests/bpf: Convert test_cgroup_attach to prog_tests Andrey Ignatov
2019-12-19 22:46 ` Andrii Nakryiko
2019-12-19 7:44 ` [PATCH v4 bpf-next 6/6] selftests/bpf: Test BPF_F_REPLACE in cgroup_attach_multi Andrey Ignatov
2019-12-19 22:48 ` Andrii Nakryiko
2019-12-20 5:33 ` Alexei Starovoitov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191220053311.menmpnootqshkzrw@ast-mbp.dhcp.thefacebook.com \
--to=alexei.starovoitov@gmail.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kafai@fb.com \
--cc=kernel-team@fb.com \
--cc=rdna@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).