From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EDFAC43603 for ; Fri, 20 Dec 2019 09:26:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 300B12146E for ; Fri, 20 Dec 2019 09:26:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="drnfjb+f" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727193AbfLTJ0b (ORCPT ); Fri, 20 Dec 2019 04:26:31 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:36593 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727169AbfLTJ0b (ORCPT ); Fri, 20 Dec 2019 04:26:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576833990; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qqR8lwUOuBpvxH2x8/pvM8hypDpbA173h4KwuaI5cck=; b=drnfjb+f7uClnw0hktizhZORoD07ZP0PaXTGXl9faU+ajlbiWLUHum9d6DpD0TTy4FzV+p C9my1Fs7woiqPSyySg6/Km0jJr6wtUZkYnj2abbrgBSt/MAOmMEyFJMVzbLBGD0EdKEBax IzrUC++chiHRdHiVAhiZHS10wEDSSKc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-110-MQtIfutfNFe_4eI-r0rmsw-1; Fri, 20 Dec 2019 04:26:24 -0500 X-MC-Unique: MQtIfutfNFe_4eI-r0rmsw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B0A44593C6; Fri, 20 Dec 2019 09:26:22 +0000 (UTC) Received: from carbon (ovpn-200-18.brq.redhat.com [10.40.200.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id B5EC15C1B0; Fri, 20 Dec 2019 09:26:16 +0000 (UTC) Date: Fri, 20 Dec 2019 10:26:15 +0100 From: Jesper Dangaard Brouer To: Alexei Starovoitov Cc: =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Network Development , Alexei Starovoitov , Daniel Borkmann , bpf , "David S. Miller" , Jakub Kicinski , John Fastabend , "Karlsson, Magnus" , Jonathan Lemon , brouer@redhat.com Subject: Re: [PATCH bpf-next v2 0/8] Simplify xdp_do_redirect_map()/xdp_do_flush_map() and XDP maps Message-ID: <20191220102615.45fe022d@carbon> In-Reply-To: <20191220084651.6dacb941@carbon> References: <20191219061006.21980-1-bjorn.topel@gmail.com> <20191220084651.6dacb941@carbon> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Fri, 20 Dec 2019 08:46:51 +0100 Jesper Dangaard Brouer wrote: > On Thu, 19 Dec 2019 21:21:39 -0800 > Alexei Starovoitov wrote: >=20 > > > v1->v2 [1]: > > > * Removed 'unused-variable' compiler warning (Jakub) > > > > > > [1] https://lore.kernel.org/bpf/20191218105400.2895-1-bjorn.topel@gma= il.com/ =20 > >=20 > > My understanding that outstanding discussions are not objecting to the > > core ideas of the patch set, hence applied. Thanks =20 >=20 > I had hoped to have time to review it in details today. But as I don't > have any objecting to the core ideas, then I don't mind it getting > applied. We can just fix things in followups. I have now went over the entire patchset, and everything look perfect, I will go as far as saying it is brilliant. We previously had the issue, that using different redirect maps in a BPF-prog would cause the bulking effect to be reduced, as map_to_flush cause previous map to get flushed. This is now solved :-) Thanks you Bj=C3=B8rn! --=20 Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer