* [PATCH] net: ena: remove set but not used variable 'rx_ring'
@ 2020-01-03 12:07 yu kuai
2020-01-03 20:33 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: yu kuai @ 2020-01-03 12:07 UTC (permalink / raw)
To: netanel, saeedb, zorik, davem, ast, daniel, jakub.kicinski, hawk,
john.fastabend, sameehj, akiyano
Cc: netdev, linux-kernel, bpf, yukuai3, yi.zhang, zhengbin13
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/ethernet/amazon/ena/ena_netdev.c: In function
‘ena_xdp_xmit_buff’:
drivers/net/ethernet/amazon/ena/ena_netdev.c:316:19: warning:
variable ‘rx_ring’ set but not used [-Wunused-but-set-variable]
It is never used, and so can be removed.
Signed-off-by: yu kuai <yukuai3@huawei.com>
---
drivers/net/ethernet/amazon/ena/ena_netdev.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c
index 081acf077bb5..894e8c1a8cf1 100644
--- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
+++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
@@ -313,7 +313,6 @@ static int ena_xdp_xmit_buff(struct net_device *dev,
struct ena_com_tx_ctx ena_tx_ctx = {0};
struct ena_tx_buffer *tx_info;
struct ena_ring *xdp_ring;
- struct ena_ring *rx_ring;
u16 next_to_use, req_id;
int rc;
void *push_hdr;
@@ -324,8 +323,6 @@ static int ena_xdp_xmit_buff(struct net_device *dev,
req_id = xdp_ring->free_ids[next_to_use];
tx_info = &xdp_ring->tx_buffer_info[req_id];
tx_info->num_of_bufs = 0;
- rx_ring = &xdp_ring->adapter->rx_ring[qid -
- xdp_ring->adapter->xdp_first_ring];
page_ref_inc(rx_info->page);
tx_info->xdp_rx_page = rx_info->page;
--
2.17.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: ena: remove set but not used variable 'rx_ring'
2020-01-03 12:07 [PATCH] net: ena: remove set but not used variable 'rx_ring' yu kuai
@ 2020-01-03 20:33 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-01-03 20:33 UTC (permalink / raw)
To: yukuai3
Cc: netanel, saeedb, zorik, ast, daniel, jakub.kicinski, hawk,
john.fastabend, sameehj, akiyano, netdev, linux-kernel, bpf,
yi.zhang, zhengbin13
From: yu kuai <yukuai3@huawei.com>
Date: Fri, 3 Jan 2020 20:07:01 +0800
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/ethernet/amazon/ena/ena_netdev.c: In function
> ‘ena_xdp_xmit_buff’:
> drivers/net/ethernet/amazon/ena/ena_netdev.c:316:19: warning:
> variable ‘rx_ring’ set but not used [-Wunused-but-set-variable]
>
> It is never used, and so can be removed.
>
> Signed-off-by: yu kuai <yukuai3@huawei.com>
Does not apply to net-next.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-03 20:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-03 12:07 [PATCH] net: ena: remove set but not used variable 'rx_ring' yu kuai
2020-01-03 20:33 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).