BPF Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH net-next] sfc: remove duplicated include from ef10.c
@ 2020-01-10  1:35 YueHaibing
  2020-01-10 11:57 ` Edward Cree
  2020-01-11  7:11 ` David Miller
  0 siblings, 2 replies; 4+ messages in thread
From: YueHaibing @ 2020-01-10  1:35 UTC (permalink / raw)
  To: David S . Miller, Alexei Starovoitov, Daniel Borkmann, Jakub Kicinski
  Cc: YueHaibing, netdev, bpf, linux-kernel, kernel-janitors

Remove duplicated include.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/net/ethernet/sfc/ef10.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/sfc/ef10.c b/drivers/net/ethernet/sfc/ef10.c
index dc037dd927f8..fa460831af7d 100644
--- a/drivers/net/ethernet/sfc/ef10.c
+++ b/drivers/net/ethernet/sfc/ef10.c
@@ -16,7 +16,6 @@
 #include "workarounds.h"
 #include "selftest.h"
 #include "ef10_sriov.h"
-#include "rx_common.h"
 #include <linux/in.h>
 #include <linux/jhash.h>
 #include <linux/wait.h>




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH net-next] sfc: remove duplicated include from ef10.c
  2020-01-10  1:35 [PATCH net-next] sfc: remove duplicated include from ef10.c YueHaibing
@ 2020-01-10 11:57 ` Edward Cree
  2020-01-11  1:56   ` Yuehaibing
  2020-01-11  7:11 ` David Miller
  1 sibling, 1 reply; 4+ messages in thread
From: Edward Cree @ 2020-01-10 11:57 UTC (permalink / raw)
  To: YueHaibing, David S . Miller, Alexei Starovoitov,
	Daniel Borkmann, Jakub Kicinski
  Cc: netdev, bpf, linux-kernel, kernel-janitors

On 10/01/2020 01:35, YueHaibing wrote:
> Remove duplicated include.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Edward Cree <ecree@solarflare.com>
but you seem to have come up with a strange CC list, full of bpf maintainers
 rather than sfc driver maintainers; check your submission scripts?  (AFAIK
 the MAINTAINERS file has the right things in.)

-Ed
> ---
>  drivers/net/ethernet/sfc/ef10.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/sfc/ef10.c b/drivers/net/ethernet/sfc/ef10.c
> index dc037dd927f8..fa460831af7d 100644
> --- a/drivers/net/ethernet/sfc/ef10.c
> +++ b/drivers/net/ethernet/sfc/ef10.c
> @@ -16,7 +16,6 @@
>  #include "workarounds.h"
>  #include "selftest.h"
>  #include "ef10_sriov.h"
> -#include "rx_common.h"
>  #include <linux/in.h>
>  #include <linux/jhash.h>
>  #include <linux/wait.h>
>
>
>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH net-next] sfc: remove duplicated include from ef10.c
  2020-01-10 11:57 ` Edward Cree
@ 2020-01-11  1:56   ` Yuehaibing
  0 siblings, 0 replies; 4+ messages in thread
From: Yuehaibing @ 2020-01-11  1:56 UTC (permalink / raw)
  To: Edward Cree, David S . Miller, Alexei Starovoitov,
	Daniel Borkmann, Jakub Kicinski
  Cc: netdev, bpf, linux-kernel, kernel-janitors

On 2020/1/10 19:57, Edward Cree wrote:
> On 10/01/2020 01:35, YueHaibing wrote:
>> Remove duplicated include.
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> Acked-by: Edward Cree <ecree@solarflare.com>
> but you seem to have come up with a strange CC list, full of bpf maintainers
>  rather than sfc driver maintainers; check your submission scripts?  (AFAIK
>  the MAINTAINERS file has the right things in.)

Thanks, I will check this.
> 
> -Ed
>> ---
>>  drivers/net/ethernet/sfc/ef10.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/sfc/ef10.c b/drivers/net/ethernet/sfc/ef10.c
>> index dc037dd927f8..fa460831af7d 100644
>> --- a/drivers/net/ethernet/sfc/ef10.c
>> +++ b/drivers/net/ethernet/sfc/ef10.c
>> @@ -16,7 +16,6 @@
>>  #include "workarounds.h"
>>  #include "selftest.h"
>>  #include "ef10_sriov.h"
>> -#include "rx_common.h"
>>  #include <linux/in.h>
>>  #include <linux/jhash.h>
>>  #include <linux/wait.h>
>>
>>
>>
> 
> 
> .
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH net-next] sfc: remove duplicated include from ef10.c
  2020-01-10  1:35 [PATCH net-next] sfc: remove duplicated include from ef10.c YueHaibing
  2020-01-10 11:57 ` Edward Cree
@ 2020-01-11  7:11 ` David Miller
  1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2020-01-11  7:11 UTC (permalink / raw)
  To: yuehaibing
  Cc: ast, daniel, jakub.kicinski, netdev, bpf, linux-kernel, kernel-janitors

From: YueHaibing <yuehaibing@huawei.com>
Date: Fri, 10 Jan 2020 01:35:17 +0000

> Remove duplicated include.
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-10  1:35 [PATCH net-next] sfc: remove duplicated include from ef10.c YueHaibing
2020-01-10 11:57 ` Edward Cree
2020-01-11  1:56   ` Yuehaibing
2020-01-11  7:11 ` David Miller

BPF Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/bpf/0 bpf/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 bpf bpf/ https://lore.kernel.org/bpf \
		bpf@vger.kernel.org
	public-inbox-index bpf

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.bpf


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git